From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 097151B295 for ; Thu, 12 Jul 2018 11:11:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2018 02:11:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,342,1526367600"; d="scan'208";a="71727200" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.102]) ([10.237.220.102]) by fmsmga001.fm.intel.com with ESMTP; 12 Jul 2018 02:11:00 -0700 To: Takeshi Yoshimura , dev@dpdk.org References: <20180712024455.4807-1-t.yoshimura8869@gmail.com> <20180712030833.4887-1-t.yoshimura8869@gmail.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 12 Jul 2018 10:10:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <20180712030833.4887-1-t.yoshimura8869@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] vfio: fix workaround of BAR0 mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 09:11:09 -0000 On 12-Jul-18 4:08 AM, Takeshi Yoshimura wrote: > The workaround of BAR0 mapping does not work if BAR0 area is smaller > than page size (64KB in ppc). In addition, we no longer need the > workaround in recent Linux because VFIO allows MSIX mapping (*). > This fix is just to skip the workaround if BAR0 is smarller than a page. > > (*): "vfio-pci: Allow mapping MSIX BAR", > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ > commit/id=a32295c612c57990d17fb0f41e7134394b2f35f6 > > Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables") > > Signed-off-by: Takeshi Yoshimura > --- Minimum support kernel version in DPDK is 3.2, we cannot rely on functionality provided by the recent kernel versions. It would be better if you modified the check at line 350 instead (or added a new check, specifically testing for whether BAR size is less than page size). -- Thanks, Anatoly