From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0078.outbound.protection.outlook.com [104.47.38.78]) by dpdk.org (Postfix) with ESMTP id 77AE925A1 for ; Mon, 18 Sep 2017 16:31:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qx2GYElPlWElW5qV8TXCwk6BIWUHewssdrR0F9Lc78U=; b=XjOHRgWfZqeuSnuSPWAHs/Ix3TG5ipMKC5oWtEtk/52N+SNwBbiqc7KbtDvp+f/wivY0uC4jHModQSAzbz1q/46HsTnCQ2+vx5i+8OIjpmZRLWdYQBJyyZ+XgvJg/7GbZzmO5niLQBEVubZEpVcUrOxDxnkjy4lgtvToAIB8JTU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [192.168.0.105] (103.76.56.167) by DM5PR07MB3098.namprd07.prod.outlook.com (10.172.85.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8; Mon, 18 Sep 2017 14:31:35 +0000 To: "Burakov, Anatoly" , dev@dpdk.org References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com> <20170814151537.29454-2-santosh.shukla@caviumnetworks.com> <2a655cea-340a-1b7a-d0ba-01db39dbcd24@intel.com> From: santosh Message-ID: Date: Mon, 18 Sep 2017 20:01:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <2a655cea-340a-1b7a-d0ba-01db39dbcd24@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [103.76.56.167] X-ClientProxiedBy: SG2PR06CA0173.apcprd06.prod.outlook.com (10.175.208.27) To DM5PR07MB3098.namprd07.prod.outlook.com (10.172.85.8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b48118e-91b3-40df-7b04-08d4fea1f792 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR07MB3098; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 3:8tNkHqx9TXcIO9pLAu3XEFy84tdi+dSvFPR+s4keAKDewxfP6MpErQcKS1D5256ZIGl+sIXeoKDRL/OmR+pEPwsK9DxcQ+YMhCye7tcNmLlghRnXQFTC+DKQIk5n8POWqfVrlOZkFnzoTcvhnanbP+GjkFE8rm6ec8/sIu1peoQZGTMC5mCDCAvBvNoCQ8PrpLWDhc5YOoYzJAozFhP8B9QnTYuW6fxi8b7PU2GtRn9Tds4tKxqKARbsdybZm/Pu; 25:ErSGoVRHT57lA5R+0QbKzMeQYYnyjmNrqebD9n00Yrpg56yxw31aTLXNSQQj2W5vbJ/7e6rNaMKkxgP7XsWTtOPSDd3aYNQo6lFxqWlFW7KndwycC01N+Ofxgp0htKUBtRUDJhbdaShuEY5a/3B+FD3kSHdx1ee3YnoEmoGCLMzVQVhLjEFK4A/BliZGmgpyPlvWeQJbJNiWbawaSDJVj8zGm+g40j2Qzndc29h8FSXSMfdzNmQb9ynZiBBxEyU+HIJZKxB4tsF6/xxvOEYeqPLdrmFM/IW6sYzDK9/kg410NHtK4rK+0ipftG3pOednf0nT0GmI2mUkoub96En1Qg==; 31:/mqy07SMyp34tAiOljjRO05d2/DbcN+LacsSkJSG8TwxL38IY8Q+h3XbirAjR8JrXPBGRCLmo1v3HThCNT5p2v9I9x2k6mB6zb51gW/AD+wZYE/Ie9zvaUorLcBKYOS+J0mptPr3L9esJylOoVpNS7+Koj/c6CGMyTM3apEC1VJAoV3PeLpZBJq+7dY8uQp9iEdIGbmfdU4mJ02YZSVgPLSThAEANXS6r8Q/n9VW3Ek= X-MS-TrafficTypeDiagnostic: DM5PR07MB3098: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 20:Hrf+zAmNQ51bZdgHe3Z5h4AVxZnGzPKtieyQhrQfHqOrnr8YOv8XUN1RzKKmI1XVHPXQj+/UdkZrz58msA4VJcWPsDjyz6+bj98Lc+5DO1/q7R1DHvk1gpUM9beimwAqCvfL7dDTlZU9u7gUMDiyWgo7i0CRx6ax7+ehTOlvrSQKB5SOzggYtSeNsIIZxYAXUjKl5F+Aj/wz6oqvHzfDVkHXFFzu6867nxoz2IbavX46lve8WkM+AaKqs8dFBfthG8sMVX392TUYLFmodyvpAuDdpAcDLeH+knXhLyPeFVHDd1rNxyyj+l91U/4Ot34RPd2sdAtXJ9z5LAMfstYv/4IfTkPbUAvoBDshXUnnEAO0nMkfO41fYBccJeT46S5Vm1qB9ky1TufDqQ4HimzuZPbZU8XtZdJ1P5rGnZE9Hr0tSfA2OpJ6uJbs6/FuAeRRFs7qtO/vsYlynVq4260w9W7cQMFbdbTeBYXsRjQ2G5IOR2AcAhO52idoqrL3s4NfmlHBjkOk+yvCukfmFLRhCgSlelwa68YoZ/0i8NHc8lMMgPtYMzNtIG36d+EV8m9mkasaAYD/buaA6DwEwqgIYVUrHvrrygIWRPRAfAjv+hk=; 4:oDG7uHbUkZZd9hDQAQdoKhqubcicpDjWFl3MbOL4yIFNGVtLNcweam/zao8fIO1NgH6YBF/zt3xB1SKHLwslHs2257f6v4Oq4gtwSTsgtKM1H/I3CFpf5u4dLoo7RlFmg3VZr9CmgcsUsmWYqduxCeDKTCFzXihTA58rk2Enql+k+Zp4pZh9ulCk9UMN51CbjCC3G/Nn7mq2UHc0IraSM0WEaSP9mwmW4E+tONonsTgl35Pk7Prq/kGOhoW+uzeEGw3Mb6ZsKh7bdlT3O/cLRdh+Y4i6ovwJNh3i2PVusM8= X-Exchange-Antispam-Report-Test: UriScan:(275809806118684); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(100000703101)(100105400095)(6041248)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3098; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3098; X-Forefront-PRVS: 04347F8039 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(376002)(346002)(24454002)(377454003)(199003)(189002)(50466002)(101416001)(86152003)(50986999)(23676002)(76176999)(54356999)(229853002)(5660300001)(64126003)(6486002)(90366009)(478600001)(230700001)(77096006)(33646002)(72206003)(68736007)(53936002)(105586002)(65806001)(25786009)(31686004)(117156002)(6246003)(110136004)(53376002)(47776003)(66066001)(65956001)(6306002)(106356001)(2906002)(6666003)(83506001)(7736002)(189998001)(36756003)(305945005)(6116002)(3846002)(966005)(8936002)(8676002)(81166006)(81156014)(2950100002)(16526017)(16576012)(42882006)(31696002)(316002)(65826007)(53546010)(58126008)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3098; H:[192.168.0.105]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjA3TUIzMDk4OzIzOkxrd2NmUUhZcVFhUTBKMDIxOWsyUC9tUGNL?= =?utf-8?B?clRWaGJubkpJU28yMkJ6VC85UzNrRHQ0QUh6am5abkRWNXNGWk40OVd1cXNj?= =?utf-8?B?T0RBS1FHUlk2azEvVkhCb0ZjS3VGRk9SZ1d0SmUwbTRtNTE3akpMUEZhR2xO?= =?utf-8?B?N2NxUDNIZ1B4QW9BM0pzRWcxSStWZitGNHJPK2xxTHNMK2JESGtuL3NJNFBs?= =?utf-8?B?WDVHRGtsbmFPZWNkdjE2ZEc3c0FQamUzU0d0K2JFd0t2VzRiU1hSU29oeVdr?= =?utf-8?B?Y2dvc0VRWDNSMUNWRkRDbDQyZ1BEd0ZPdm1nVTJiM2VobGFXUVNhUjdxM1lN?= =?utf-8?B?WFZnemlPblJtNlR6elFNMzZuSk91TXhqbFZnZnlXeUd4c01BY1VkcXVUam9u?= =?utf-8?B?eTgvbXRLNFRFc092YnBQNURQbGtGZXVGaksza2lyV0hoMHpZTDNDblIvemcv?= =?utf-8?B?bUtubWVzeHRKNHdrOVZxYVZZYXovMWNnNUNERjBrTUp3S1hOcHBSdkNjTDJn?= =?utf-8?B?cEVvcHdadEZsZXF1WnNjdk9mZmQyeEI1Z2Y2d0orNXp1a1RYaFZDSWFRMUdG?= =?utf-8?B?Q0dPU21hT29qNmRxS1lsb25UNGhtVzlDV29meHlhcm9UamZrVFpybDE2Mjl5?= =?utf-8?B?MkdEa3RTdWxsK0g2UjUyN0RDRDRIRmcxcEJuaExxQ05oR1pJeGRhcERrbTd4?= =?utf-8?B?ZzZvcUU5Tm5yVlhKc0xNMDlqTC90TWZpNmxvRjFiZHBmSXFCb3I4Y2RBSW15?= =?utf-8?B?NXhZbWJDMTRTcC9nalk4ZW1sQmYzZmZUN2ttWmJiNTUrSWp0ZXVzUEJxV2FY?= =?utf-8?B?VEVpbVRUOFVienFwMUdxc1gxa2Rld2VaNCt4cExlS1lwV1hQcS9Ja1I5bm1U?= =?utf-8?B?aTBObmRTQWJoYTh2cElpRWpzaUhMZUJPS0NzbjJXWlFUQVRPWVYva1ZqZVZ0?= =?utf-8?B?OVB1MnBPa1ZrMW5BbFgrOVV1VWNlTU5OcmVOQlQwSExJbmRteGlSZjRiQzFP?= =?utf-8?B?RHZpdThEOUhFaDl3cEFGenJrbm9VT1IwWWFTbmhRdEhTUmdJRGpWVDd1d01u?= =?utf-8?B?ZHhhdkF2OHZnTlh5bCsyY25HM1cyOGZEVTFVMVRydnVTa1dGSGRNS085Yk1Z?= =?utf-8?B?QWRqOTllOFNyT3QyQ1VyNEQ0bXVBU0R4ZnU4eTY2QS9yc1NxZHE4ZndndHho?= =?utf-8?B?SzZPaHV3aU5heWVTbEQwVkFVQWRybUJVcGUrL3BCc0xWMkQwN0dBd1BEa0x4?= =?utf-8?B?eGp3cWVJN3AySzZHM3B4aWlNa2ZobU9CNDJOUHVFN2llZElmSTNwb0Z6Undv?= =?utf-8?B?SUJQMmNwa0VWRFA3Y2FlckdIWlpaaWp4ejNETFQrWmcveWNkWnpxY3VBQ1gr?= =?utf-8?B?eitqM1dMeVJ5TEFwWTdqSWFqN3dzQzJNZ296d1dZTXJpWS9qaUJpa0hRKzAx?= =?utf-8?B?NXNrWms0cStvNXVOTGdjaGdyUVhuYUZWcWdicDE4OXFEOC80M1VCTzdzZmFD?= =?utf-8?B?dWdzcDFsNllXQzBENnAyNlBIbkdzZ0syNDhvbUR0R1hqSjluZUlBbkViYklV?= =?utf-8?B?ZklKaTE4R1pra0N4YU1tR1VaL2pLQzlFdkI5M1J2bk5rUmhMMHBqT09hK3dK?= =?utf-8?B?UlZUandocGtNa0FNaFJDazhoZG9NdVptbFNVSnFZNDl1TW90bU1NUkJtZFZQ?= =?utf-8?B?ZHBndUZnOG12MzdJVTNZTWd4eE1PQnZ4M05DS3g1bURVRTFBbmM3QXpLTVVZ?= =?utf-8?B?REJEcXdPeEI2NTRhdFBac3RrK25xRW1tTVZBbjFzb3Y3Ylo3dlo1WjFEdTVR?= =?utf-8?B?VWplSVdSMzRud09GREkyWUZXMXZBYzgzVzI4bldyc0ZpTHg4WldITVJXbFl3?= =?utf-8?B?WlpMSTl1dHZEeXcxTDlaMksraEFyZlpPdXp3SFE3QTFmMkxSUDN3VXZJVXRx?= =?utf-8?B?NkZNNlM0dW9YMXdCbW9pL1lMbktLcHo0SkJ0Mm9LZlh4ZXBGNzJ1dTlCdnho?= =?utf-8?Q?1MbUoG?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3098; 6:tihiVy71R0iz/LGY3UVlUVrjmrA7yHngFo1HNkI7L+jKGYZq6PVXj6FH7L7jXmonBBDfsyUuJyRARJYGCRhp/iODhON6ccvjmS/ntchsucxUcvhfBAz7O3rkmNys4ru+74XktjAahcm1PVQV59kahPYRQ17T5s5Yuz0eq+y7Clunh9AXlPF4FqZMAfc14IJuL30ObEgjMSj7k3s8jZ28zL1IvduR10xdgoq/f0vBl8M13xBbP8BqUhebSA0eQKksdU7aCupIFLvqv5QULzjQGODW2o3DUno/dhZ5Iibt51H9TLP100eTWTwwRuCT7Ds1zh17o8PULJCPViHPttVwOg==; 5:yzvzOXo96ShyrPWouGLtPHBLq4ZpzJoNzrNB7hQQ8ETbLeP6/uyHJJbDKO0ezQ4qKousuVzXacybz1sBdO37I1R5YeFNp9j9LFW66jWuonuWEd3fzrOrqeMCIdO5vxmTKI0d8ti+sk2/t8kuy/tmdA==; 24:8YEIX19rg7fSMIY/r6zI7HOthbYAQ+c3dTi8QwAAgr07NxKUG9eLlCLCiHnb+hlZWri20p0+X3nY6xqgNi3JPyl2uEcAmjWQgIBixrv1/XI=; 7:DLe1aY8uk46/UWARFBwrO3Wn0dU7eMkVmFzkD/kFLlbAhe6K+Hdulvv2bhWBRK69nynXnnQ4a234qYtLxUa62eesCo4OqSJ3yxoQgLeMOsC+LkdVl4CKTSnxTOKCqazFbQwLorWgNlZAY1o5HeWQozqd4i7Igy/OXvgqXvpgK/qc5G9eLuNyq1fZUtPJWuUqAq6Tg5LSSFin7k+9zznswdfLbM/+gCJ/ycsQantXDEw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2017 14:31:35.1750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3098 Subject: Re: [dpdk-dev] [PATCH v1 1/4] eal: rename phys_addr_t to iova_addr_t X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 14:31:38 -0000 On Monday 18 September 2017 07:36 PM, Burakov, Anatoly wrote: > Hi Santosh, > > On 14-Aug-17 4:15 PM, Santosh Shukla wrote: >> Signed-off-by: Santosh Shukla >> --- >> v1 note: >> - As changes percolate to all possible dpdk subsystem.. >> so its difficult to tag subject with one common title, >> but since, core of changeset is at eal layer so keeping 'eal:' >> as title. >> >> app/test-crypto-perf/cperf_test_vectors.h | 4 +-- >> doc/guides/contributing/documentation.rst | 4 +-- >> doc/guides/prog_guide/cryptodev_lib.rst | 6 ++-- >> drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 14 ++++---- >> drivers/crypto/qat/qat_adf/qat_algs.h | 6 ++-- >> drivers/crypto/qat/qat_crypto.h | 2 +- >> drivers/mempool/dpaa2/dpaa2_hw_mempool.h | 2 +- >> drivers/net/ark/ark_ddm.c | 2 +- >> drivers/net/ark/ark_ddm.h | 4 +-- >> drivers/net/ark/ark_ethdev_rx.c | 12 +++---- >> drivers/net/ark/ark_ethdev_tx.c | 2 +- >> drivers/net/ark/ark_mpu.c | 2 +- >> drivers/net/ark/ark_mpu.h | 4 +-- >> drivers/net/ark/ark_udm.c | 2 +- >> drivers/net/ark/ark_udm.h | 4 +-- >> drivers/net/avp/avp_ethdev.c | 2 +- >> drivers/net/avp/rte_avp_common.h | 20 +++++------ >> drivers/net/bnx2x/bnx2x.c | 40 +++++++++++----------- >> drivers/net/bnx2x/bnx2x.h | 22 ++++++------ >> drivers/net/bnx2x/bnx2x_rxtx.c | 4 +-- >> drivers/net/bnx2x/bnx2x_stats.c | 2 +- >> drivers/net/bnx2x/bnx2x_vfpf.c | 2 +- >> drivers/net/bnx2x/ecore_sp.h | 2 +- >> drivers/net/bnxt/bnxt.h | 10 +++--- >> drivers/net/bnxt/bnxt_cpr.h | 4 +-- >> drivers/net/bnxt/bnxt_ethdev.c | 2 +- >> drivers/net/bnxt/bnxt_ring.c | 2 +- >> drivers/net/bnxt/bnxt_ring.h | 2 +- >> drivers/net/bnxt/bnxt_rxr.h | 4 +-- >> drivers/net/bnxt/bnxt_txr.h | 2 +- >> drivers/net/bnxt/bnxt_vnic.c | 2 +- >> drivers/net/bnxt/bnxt_vnic.h | 6 ++-- >> drivers/net/liquidio/lio_rxtx.c | 2 +- >> drivers/net/liquidio/lio_rxtx.h | 4 +-- >> drivers/net/qede/base/bcm_osal.h | 2 +- >> drivers/net/sfc/efsys.h | 2 +- >> drivers/net/sfc/sfc_ef10_rx.c | 2 +- >> drivers/net/sfc/sfc_ef10_tx.c | 4 +-- >> drivers/net/thunderx/base/nicvf_hw.c | 2 +- >> drivers/net/thunderx/base/nicvf_hw.h | 2 +- >> drivers/net/thunderx/base/nicvf_hw_defs.h | 6 ++-- >> drivers/net/thunderx/nicvf_ethdev.c | 4 +-- >> drivers/net/thunderx/nicvf_ethdev.h | 4 +-- >> drivers/net/thunderx/nicvf_struct.h | 6 ++-- >> drivers/net/virtio/virtio_rxtx.h | 4 +-- >> drivers/net/virtio/virtqueue.h | 2 +- >> drivers/net/xenvirt/rte_eth_xenvirt.c | 2 +- >> drivers/net/xenvirt/rte_mempool_gntalloc.c | 6 ++-- >> drivers/net/xenvirt/rte_xen_lib.c | 6 ++-- >> drivers/net/xenvirt/rte_xen_lib.h | 8 ++--- >> examples/l2fwd-crypto/main.c | 2 +- >> lib/librte_cryptodev/rte_crypto.h | 2 +- >> lib/librte_cryptodev/rte_crypto_sym.h | 6 ++-- >> lib/librte_cryptodev/rte_cryptodev.h | 2 +- >> lib/librte_eal/bsdapp/eal/eal_memory.c | 4 +-- >> lib/librte_eal/common/include/rte_malloc.h | 2 +- >> lib/librte_eal/common/include/rte_memory.h | 18 +++++----- >> lib/librte_eal/common/include/rte_memzone.h | 2 +- >> lib/librte_eal/common/rte_malloc.c | 2 +- >> lib/librte_eal/linuxapp/eal/eal_memory.c | 8 ++--- >> lib/librte_eal/linuxapp/eal/eal_xen_memory.c | 4 +-- >> .../linuxapp/eal/include/exec-env/rte_kni_common.h | 19 +++++----- >> lib/librte_mbuf/rte_mbuf.h | 8 ++--- >> lib/librte_mempool/rte_mempool.c | 18 +++++----- >> lib/librte_mempool/rte_mempool.h | 14 ++++---- >> lib/librte_vhost/vhost.h | 2 +- >> test/test/test_cryptodev.h | 2 +- >> test/test/test_memzone.c | 8 ++--- >> 68 files changed, 195 insertions(+), 194 deletions(-) >> >> diff --git a/app/test-crypto-perf/cperf_test_vectors.h b/app/test-crypto-perf/cperf_test_vectors.h >> index 85955703c..a203272cf 100644 >> --- a/app/test-crypto-perf/cperf_test_vectors.h >> +++ b/app/test-crypto-perf/cperf_test_vectors.h >> @@ -78,13 +78,13 @@ struct cperf_test_vector { >> struct { >> uint8_t *data; >> - phys_addr_t phys_addr; >> + iova_addr_t phys_addr; >> uint16_t length; >> } aad; >> struct { >> uint8_t *data; >> - phys_addr_t phys_addr; >> + iova_addr_t phys_addr; >> uint16_t length; >> } digest; >> diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst >> index cddbd7bb8..719007b9f 100644 >> --- a/doc/guides/contributing/documentation.rst >> +++ b/doc/guides/contributing/documentation.rst >> @@ -712,7 +712,7 @@ The following are some guidelines for use of Doxygen in the DPDK API documentati >> /**< Virtual address of the first mempool object. */ >> uintptr_t elt_va_end; >> /**< Virtual address of the mempool object. */ >> - phys_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT]; >> + iova_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT]; >> /**< Array of physical page addresses for the mempool buffer. */ > > Here and perhaps in other places - worth it to fix comments as well? > ok, >> This doesn't have an effect on the rendered documentation but it is confusing for the developer reading the code. >> @@ -731,7 +731,7 @@ The following are some guidelines for use of Doxygen in the DPDK API documentati >> /** Virtual address of the mempool object. */ >> uintptr_t elt_va_end; >> /** Array of physical page addresses for the mempool buffer. */ >> - phys_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT]; >> + iova_addr_t elt_pa[MEMPOOL_PG_NUM_DEFAULT]; >> * Check for Doxygen warnings in new code by checking the API documentation build:: >> > > ... > >> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h >> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h >> @@ -58,7 +58,6 @@ >> #ifndef _RTE_KNI_COMMON_H_ >> #define _RTE_KNI_COMMON_H_ >> - >> #ifdef __KERNEL__ >> #include >> #define RTE_STD_C11 >> @@ -66,6 +65,8 @@ >> #include >> #endif >> +typedef uint64_t iova_addr_t; >> + > > Why was this added? (This also causes a compile issue according to build automation) > sent v2 [1] which fixes build issue for clang. [1] http://dpdk.org/ml/archives/dev/2017-September/074524.html > Thanks, > Anatoly > >> /** >> * KNI name is part of memzone name. >> */ >> @@ -138,20 +139,20 @@ struct rte_kni_mbuf { >> struct rte_kni_device_info { >> char name[RTE_KNI_NAMESIZE]; /**< Network device name for KNI */ >> - phys_addr_t tx_phys; >> - phys_addr_t rx_phys; >> - phys_addr_t alloc_phys; >> - phys_addr_t free_phys; >> + iova_addr_t tx_phys; >> + iova_addr_t rx_phys; >> + iova_addr_t alloc_phys; >> + iova_addr_t free_phys;