From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8E0E5532E for ; Tue, 11 Apr 2017 15:39:49 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2017 06:39:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,185,1488873600"; d="scan'208";a="1133963423" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga001.fm.intel.com with ESMTP; 11 Apr 2017 06:39:46 -0700 To: "Wiles, Keith" , Pascal Mazon Cc: "dev@dpdk.org" References: <20170410181850.44845-1-keith.wiles@intel.com> <20170411091851.62ab28ad@paques.dev.6wind.com> From: Ferruh Yigit Message-ID: Date: Tue, 11 Apr 2017 14:39:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/tap: add support for fixed mac addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 13:39:50 -0000 On 4/11/2017 2:23 PM, Wiles, Keith wrote: > >> On Apr 11, 2017, at 2:18 AM, Pascal Mazon wrote: >> >> Hi Keith, >> >> I have a few comments on your patch, see inline. >> >> On Mon, 10 Apr 2017 13:18:50 -0500 >> Keith Wiles wrote: >> >>> Support for a fixed MAC address for testing with the last octet >>> incrementing by one for each interface defined with the new 'mac=fixed' >>> string on the --vdev option. The default option is still to randomize >>> the MAC address for each tap interface. >>> >>> Signed-off-by: Keith Wiles <...> >>> + >>> +#ifdef IFF_MULTI_QUEUE >>> +#define RTE_PMD_TAP_MAX_QUEUES 16 >>> +#else >>> +#define RTE_PMD_TAP_MAX_QUEUES 1 >>> +#endif >> >> Remove this IFF_MULTI_QUEUE definition as it is done in rte_eth_tap.h now (needed for pmd_internals). > > This should have been removed in your patch That is already done, and patch is in main repo: Fixes: 947d949de7de ("net/tap: fix max queues redefinition") > and now that Ferruh wants you to submit a patch for the string at the bottom of the PMD, can you remove it? Pascal already send the patch and it is in next-net now: Fixes: f0e5085f4677 ("net/tap: update driver param string") > > I can do both in my patch, but Ferruh and you need to agree before I can submit my patch. There is no more updated expected, using latest next-net should be OK to submit your patch. Thanks, ferruh