From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0897C45A2E; Wed, 25 Sep 2024 23:36:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5E314025D; Wed, 25 Sep 2024 23:36:03 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2085.outbound.protection.outlook.com [40.107.102.85]) by mails.dpdk.org (Postfix) with ESMTP id 38802400EF for ; Wed, 25 Sep 2024 23:36:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qV4nPg+fRPVBuG4LoCZx/5NkUYEd4xzEb7KllPVofi7pP9pZXcv4M/UoIoQM9B+C6ltt9ajxQBdB676EdwtBWeNN/JCUIH9FH2eokoRJccsScgNLk1HmPOpu+B7JSvQJQkxSAP1wIMhRCh9oeqF7KORfHSlbZDbPwmIrCxEBMxp7Nz0oLb+2UFPfaNJ0rvM4JC2qdNS7JWbvW6cetObLiBXcNM4X1H+JLpJunXMXaDqgoI13n8YoOdq11D4OOT9bdX1eRu37+KRlcnVPS130GAzGnil7XOZACdSDxovxvwYx5ZkE9KoKxjB5Jg9+3ieg8Jvs9vckRCcg++NkIXeSFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pwGR07Is3j3taqbZvnkK8wKNe4vuORcbqFH45Y82FeI=; b=B06zHOKCXSAE0IVvq0w7PDkigQ6ICqMdK26iRK+9KV8JCgGh61s7gq36evUI2/5v+0HbfL4FTBRBuH7OX8Sxr+Mj7RxlYMDY+c63PgIDcu4zK4aeahWN9aZLdr7pyXkgrFSJege6i4QYzGCxJMnRcO/Rqmnu28q+Ng66hNX0appi3pRIwCvfpB6DX8tVwMFNzGp0KYDqwLXI4ia6WwIOrgCo7tG7PduqSQiyt5Zelm09Q+T0DGQyikZE05fS96OnoDTl772A27XqZZ4QNIpRg8vCaPYqR+WY/cSVOKllEcyGCNjEiDUcsRB4eOqMb7QUV+FuEpSjmZwVhiEnU9JidQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pwGR07Is3j3taqbZvnkK8wKNe4vuORcbqFH45Y82FeI=; b=JcMyf03YMxPAZK3FIsI5UrKYEhEdFwn6xv7to1/Ei7xum2P9IOcAfEYhOjhzrTIOnT4eyr2pfpHlrjAT79v3sc0mTBSEOzkW8Y+1eJfEmRDfcInkOm1n//BD78RQ3p1N1lCfbxtcNjVHXH/n2xcAXqHRtFkitwguCRnKI1vE2kc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by CYYPR12MB8854.namprd12.prod.outlook.com (2603:10b6:930:b8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.27; Wed, 25 Sep 2024 21:36:00 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.7982.022; Wed, 25 Sep 2024 21:36:00 +0000 Message-ID: Date: Wed, 25 Sep 2024 22:35:53 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] ethdev: Add link_speed lanes support To: Damodharam Ammepalli Cc: dev@dpdk.org, ajit.khaparde@broadcom.com, huangdengdui@huawei.com, kalesh-anakkur.purayil@broadcom.com References: <20240904175151.47780-1-damodharam.ammepalli@broadcom.com> <20240904175151.47780-2-damodharam.ammepalli@broadcom.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0313.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::12) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|CYYPR12MB8854:EE_ X-MS-Office365-Filtering-Correlation-Id: c768cf28-81de-4a13-4b3a-08dcddaa0c49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bnBiMnkrL0VBWHhVL05vWHRyemp4VnpKZElGbEpoNVBVVS80QTJBWm41Vitn?= =?utf-8?B?WmF5bWVxOGc3aU5mY2FPaFh2VmNRTFU4azU5K2JmTDlPMlN2SGxJTEhaazRp?= =?utf-8?B?V01rVjNtbDMzdTJ3YStDUHdCL1YzRXh5YlVFeUcyY1F3UUpiSXN2bjNkZjZ0?= =?utf-8?B?QTBadkI4ZkRXWVl5STRLN0kvSnJqUFh0bmFsZDBOd3htNTNDVUlldXg5dHBv?= =?utf-8?B?VjFaKzVOUGZIcjZ1Q1JHS0NGZGcrbEtNVVBJL2FaaStJblhOK1pacEp1K1Fo?= =?utf-8?B?TkhiTFVMWnpBZkYxUnhYSkhucWVhYjBnb0tpd1o2YkxkdVdrMUVwUHgxYzN5?= =?utf-8?B?OVhKUVRuYVJXMk5vNEZkQ1ZaRzVjdlZYK2pMN25MclRvOVVYWHZlUE9GdlAz?= =?utf-8?B?NXMvK2dzTDFFM2hRb3BYWk01eWxqc0ZMQnhHM1ltQytuYnJzbW1MQUtxNUIw?= =?utf-8?B?ZlloV0tlSlBkQUZtV0phcWFCb0NGL0NzcWE4amJ0SjdkNXMvVXRqZmhLNzZy?= =?utf-8?B?VWVOZkZTZHhJNmdPdENVYytyZjBzRlBCSUp0N3Nzakt0ZnRtSlptM1M2dTls?= =?utf-8?B?bnZMTUt4K2dQazlUazNRS1doMldTS3d3NTNzMDNha3RDcHN1K2JrWll2QWs2?= =?utf-8?B?VWxkWk4xTjcreXlJMFdiU09seXQ4bldUeFkySm1UNGhYSmR2SDZnbnQvZUdW?= =?utf-8?B?bklyL1ZmTDhveVhqTTV6blIrSWtmbnZJUXIvVjVYenBIbGc2TVZzYzArTmhB?= =?utf-8?B?Z2wwWEhjYmxHK0ViYTdaUEhnYTd4VmlIMStoSkNsRnBDZVF4cTI1UWg1V2Nj?= =?utf-8?B?ZHBqSWNFV0JmRmFYU2RZUGdlMU1TNFo1VkpRc2hzMkxlRnpINTNzcFNxYzE3?= =?utf-8?B?SG02WEJzWndqWnhDOVA1NDZFY0hwUUZNVVI3ZW5sTVYwamtaZGl2TmoxbVJh?= =?utf-8?B?VWVrWE4vS3Fsb1hlKzNHRStQS2pLYlAzcGxaa3ZUb1ZHRlFGeUc2WG5jY1Fh?= =?utf-8?B?MGtPeWIxa1QybWNwRUJmTXMrZzNXWVR5QmNzalR5VU9pK2hxdVdhZGJTQ3c5?= =?utf-8?B?TWJaYm5kT1JyYitnd1ZuWnFTWHoxMEh5V2FXZEhhZlRFbGJJZlV6ZlJWMGNI?= =?utf-8?B?ZTNsRmJtNjdlY1gzYU14OXhKN3NITGQyVUVkS25tRXJFcS9mOFMzQ3J4SUNT?= =?utf-8?B?M1lzQmdyUHFUTnFjL2JEQ2ZqYUV3d3RBRnZmZko0NCtPRUFBOGNYanQyOFhU?= =?utf-8?B?dk1zREpXVk9xc0Rpb21JN1p6bVNzcnlQdWc4L0xFMkxra2w3TWU4cnhxbnJK?= =?utf-8?B?ZlE0djZKcUV0dS9kWUVFS09GTUczay9WWDJLTllqLy9KdTdBNDh0SDFPb1Q3?= =?utf-8?B?SkZVWTY0Rys3dE9Qb1dYdU1GZkFSRmFKVk5RR2g1TSt2Yy9pYWhYNCtOaC81?= =?utf-8?B?MWtvK2pGT2dWbytBNVNvNC8zL2hxVndUWGZVdGZWOEIxR081VkRFSENOdFFE?= =?utf-8?B?Q1ZUd09ZTnI2d1d2dW1nbHZYdERYNi9uaUhzelVBMGQxdHIzcXBIK24yZGdQ?= =?utf-8?B?VjNkV3Z6QTE5UTNUdUlyUGN2ZWpXWnduUkY4dzk4dDZTS1E0YjRFQ2xXVjJp?= =?utf-8?B?QkNtZ0cxZWU4TWxqZnZLbXNRRVBBMTMxMzhmc3pQUzV3Vy9nNTd6RzJMS3Iw?= =?utf-8?B?am1zOVJQVldKVlhpUFYxL29GTkVuM3dVWW90MXlUdWJ1UEtGd2x0MzJSeWNE?= =?utf-8?B?cEphRDQrVm5JMWw3eS94T3JQMUIxcVFYM1dGKzM2VUQzS3R6UmtZNlhSQjNF?= =?utf-8?B?bFFFZE9IK1FYekJVRTQ3UT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDMvMFhndFhBYkxVVXBEUnp1aUJ3dUdsak0wM3BYS1VBZHQyUk5GcDZFOXhK?= =?utf-8?B?Q011M1ZJWjBka2pZajFTOEN0cU85NUQ3WjI4YUdzeUo3em9WdEFuek9VeTAw?= =?utf-8?B?YjhuZmFqNUo1ZmwrN0RvK3p2c0MydE4yVXVMZHFaSWE5TVRaM3dPaDgzaURa?= =?utf-8?B?d0QxMjQ4cVhtYVk2SHdiai8yTmtyUE55TWdoS3lqY1l3b0Q0NVV6alUrWUFK?= =?utf-8?B?aGNXMHFjbnhVbWVkdFJ4QXRrR1FkKzZ6MDd3R0hEblZITXg2MnNjSU90Y0pt?= =?utf-8?B?bjkzQ01KR29HRCtMb2YyY1RQcUZlb0tpTFRQQlMwZzRSeGZFWk01Tk1BMXVy?= =?utf-8?B?MHovQmlCVjc3OWtabHg5SmZ5dUt0WG9ySFRoTlM2OXZKaUxhSzcxdUJSN05h?= =?utf-8?B?NzdLMnNIamN1dWpBaDhpU2xNczZlR1N1dXU3M3JVY2JZSmlGT2MvM00rcTVY?= =?utf-8?B?REp5KzJCVXZqUXB2eEp6K2VSbzZmaTV5VzlIUTR5cGN0K1lrZlh5NDhGRWlw?= =?utf-8?B?bXlJMm90SlIyQitCSDlicXZRSkdEam8vR1ViblNlV1dIM2QwSXorMW5CQjJx?= =?utf-8?B?bEpxQkc4bjk5TjFidUZwa2tuODhhOFhENzVReW9BUmJxTnFRM3Qrb21PYzQ2?= =?utf-8?B?d3dHUFVBQ0lBcXorSlhmY0p5OTF3cWExN3NUTG13cnpjRG1iSzBVMmNBV3Vu?= =?utf-8?B?NkY1cXBYaTRUSzluRHVVM3hDQmZyVTVwVUowbklWNEprVFliSllQNlFQMklE?= =?utf-8?B?OE5RV1FVZlJRWEFLUFQyMG9EemtnNFJyNDJ2YW5ybnFlMUJTbk91MmV1YVo1?= =?utf-8?B?MFVjRDNPTEdHdVgwblNkN3B6eVFPUll5QUIwUktRNG9VbzQrNnNmQzAwYzla?= =?utf-8?B?WHRnbjlieE5BdVVzTStBQjc0M013d2hhRng1andnbS9CNUp6cGxNQ2g3d2VF?= =?utf-8?B?UWdDQnB5eEtsRXhYK1BWaVhDTE5PZEd5U3M1QXZQdXVaTldxZE04MXFJYW5l?= =?utf-8?B?Mzl2emFJdHpEcEJDakJ4a0VaUElTcldmN3NnQ3Fhd1FpcGJHUjVES1U4enU1?= =?utf-8?B?ZjA0TmZxdXd2dGhxVnErZFNabGZIbmpESjJOSThLRCtjNk5Wa0ZERWdzUlhN?= =?utf-8?B?WHZKdjhiemVXZWd2b2U3RUUyeGtJdXBvSStsakwwekFIUHlGeFpCMk1BN0dy?= =?utf-8?B?QkxzMWREdmMraTErU0JaTTl5M1lVa3pPZ2YwTUp0OWFkeWZaRXVaWkFhQm83?= =?utf-8?B?T1FhRXZyc2xQUmNqRmp0bE9XMXhLMzc0R3NiM1dCNVZEOEhvcHlqL1lqTjFi?= =?utf-8?B?a1podjlGWkhNV3Vkd0t6c3N0UCtGbkZwM0IxT3RXU1Y3U2dtVFdvQW15Y3R3?= =?utf-8?B?dThvQ29ONFlZRXBRTkJGNlMxbTVZUHhIMjNtNlpaWmhMU2tKU2hYSlBDZ1pj?= =?utf-8?B?Tld6SUwyWC9Sb1FxeEhUMVorSEk2bWRQYUhLSEFReHluRVdPckRoZUZUNldV?= =?utf-8?B?R1lzYUhQYnRya1lacTNtYzVUTndGQ2I3cXMrOFh1YmpHajFjbWtLVzV2UlpQ?= =?utf-8?B?OFJqQ05TWG5IVFRqajRVMmZJSGN6Z2F3NGxaaFlKOHBCM3VaTmxrU1Y2MDhy?= =?utf-8?B?QzZlZjVVQUZxdTZzOWNQWjhnM0tZVDRFSnBDaFkzUTNYaVBQQUNHMlVaSlc1?= =?utf-8?B?dTFLUk5MVmJkVXBvQnZYZDhpNlRCNEdVYW5yVDc3K1dZYk42QXZUWDJIdWow?= =?utf-8?B?VFJubWVSUDAwWi8wZEZ3Z0dHNGxjcXExMEJWa2pzZ0tsNlFQZXhlcHhubkZ3?= =?utf-8?B?b2tOYVZ4Zk1HbWQ5NWVBT0NINVFNMGxZdU9ZLzh2bmdCSU1Yb2txY1dDRUtP?= =?utf-8?B?NHczSENzaHV1VDlMd2ZyVVB6R2NTMXlBWVpkRFRJVjBMUDhRYnJkRm8xSTJG?= =?utf-8?B?a2tpNFQ1MG1nZ0lEU3FYbjAwbCtrZFJCblRRK1ZhTzlSWnYyNmR0cDBQMTc5?= =?utf-8?B?V2EvWFFVdlFYVnNhYm5QMHpYN0oyVkdGZkkvYUdpc2doMzc3Ky9hNUtERU1R?= =?utf-8?B?OXVDTmRwaXFyb2R2OWhjditaQlh6bnBzd0FnMDNzSkpKcWxNbEQzbVJFRTBF?= =?utf-8?Q?5ZcPM7/lPDPmS28qrmbxCr2HO?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c768cf28-81de-4a13-4b3a-08dcddaa0c49 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2024 21:36:00.2278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CCc2gT9pBEFAsJD5IL8p+sASa/jhu7B6ElTt47vNKamNOfP8EiindI+x/8Kzpndk X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8854 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/24/2024 11:59 PM, Damodharam Ammepalli wrote: > On Sun, Sep 22, 2024 at 10:02 AM Ferruh Yigit wrote: >> >> On 9/4/2024 6:50 PM, Damodharam Ammepalli wrote: >>> Update the eth_dev_ops structure with new function vectors >>> to get, get capabilities and set ethernet link speed lanes. >>> Update the testpmd to provide required config and information >>> display infrastructure. >>> >>> The supporting ethernet controller driver will register callbacks >>> to avail link speed lanes config and get services. This lanes >>> configuration is applicable only when the nic is forced to fixed >>> speeds. In Autonegiation mode, the hardware automatically >>> negotiates the number of lanes. >>> >>> These are the new commands. >>> >>> testpmd> show port 0 speed_lanes capabilities >>> >>> Supported speeds Valid lanes >>> ----------------------------------- >>> 10 Gbps 1 >>> 25 Gbps 1 >>> 40 Gbps 4 >>> 50 Gbps 1 2 >>> 100 Gbps 1 2 4 >>> 200 Gbps 2 4 >>> 400 Gbps 4 8 >>> testpmd> >>> >>> testpmd> >>> testpmd> port stop 0 >>> testpmd> port config 0 speed_lanes 4 >>> testpmd> port config 0 speed 200000 duplex full >>> testpmd> port start 0 >>> testpmd> >>> testpmd> show port info 0 >>> >>> ********************* Infos for port 0 ********************* >>> MAC address: 14:23:F2:C3:BA:D2 >>> Device name: 0000:b1:00.0 >>> Driver name: net_bnxt >>> Firmware-version: 228.9.115.0 >>> Connect to socket: 2 >>> memory allocation on the socket: 2 >>> Link status: up >>> Link speed: 200 Gbps >>> Active Lanes: 4 >>> Link duplex: full-duplex >>> Autoneg status: Off >>> >>> Signed-off-by: Damodharam Ammepalli >>> --- >>> app/test-pmd/cmdline.c | 248 ++++++++++++++++++++++++++++++++++++- >>> app/test-pmd/config.c | 4 + >>> lib/ethdev/ethdev_driver.h | 91 ++++++++++++++ >>> lib/ethdev/rte_ethdev.c | 52 ++++++++ >>> lib/ethdev/rte_ethdev.h | 95 ++++++++++++++ >>> lib/ethdev/version.map | 5 + >>> 6 files changed, 494 insertions(+), 1 deletion(-) >>> >>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >>> index b7759e38a8..643102032e 100644 >>> --- a/app/test-pmd/cmdline.c >>> +++ b/app/test-pmd/cmdline.c >>> @@ -284,6 +284,9 @@ static void cmd_help_long_parsed(void *parsed_result, >>> >>> "dump_log_types\n" >>> " Dumps the log level for all the dpdk modules\n\n" >>> + >>> + "show port (port_id) speed_lanes capabilities" >>> + " Show speed lanes capabilities of a port.\n\n" >>> ); >>> } >>> >>> @@ -823,6 +826,9 @@ static void cmd_help_long_parsed(void *parsed_result, >>> "port config (port_id) txq (queue_id) affinity (value)\n" >>> " Map a Tx queue with an aggregated port " >>> "of the DPDK port\n\n" >>> + >>> + "port config (port_id|all) speed_lanes (0|1|4|8)\n" >>> >> >> This help string, and the implementation, implies there has to be fixed >> lane values, like 1, 4, 8. Why not leave this part to the capability >> reporting, and not limit (and worry) those values in the command, so >> from command's perspective it can be only . >> > > ok, will update the help string to > >>> + " Set number of lanes for all ports or port_id for a forced speed\n\n" >>> ); >>> } >>> >>> @@ -1560,6 +1566,244 @@ static cmdline_parse_inst_t cmd_config_speed_specific = { >>> }, >>> }; >>> >>> +static int >>> +parse_speed_lanes_cfg(portid_t pid, uint32_t lanes) >>> +{ >>> + int ret; >>> + >>> + ret = rte_eth_speed_lanes_set(pid, lanes); >>> >> >> As a sample application usage, I think it is better if it gets the >> capability and verify that 'lanes' is withing the capability and later >> set it, what do you think? >> >> <...> > > Makes sense, will try out and get back to you soon. > > >>> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h> index >> 548fada1c7..9444e0a836 100644 >>> --- a/lib/ethdev/rte_ethdev.h >>> +++ b/lib/ethdev/rte_ethdev.h >>> @@ -357,6 +357,27 @@ struct rte_eth_link { >>> #define RTE_ETH_LINK_MAX_STR_LEN 40 /**< Max length of default link string. */ >>> /**@}*/ >>> >>> +/** >>> + * Constants used to indicate the possible link speed lanes of an ethdev port. >>> + */ >>> +#define RTE_ETH_SPEED_LANE_UNKNOWN 0 /**< speed lanes unsupported mode or default */ >>> +#define RTE_ETH_SPEED_LANE_1 1 /**< Link speed lane 1 */ >>> +#define RTE_ETH_SPEED_LANE_2 2 /**< Link speed lanes 2 */ >>> +#define RTE_ETH_SPEED_LANE_4 4 /**< Link speed lanes 4 */ >>> +#define RTE_ETH_SPEED_LANE_8 8 /**< Link speed lanes 8 */ >>> + >>> +/* Translate from link speed lanes to speed lanes capa */ >>> +#define RTE_ETH_SPEED_LANES_TO_CAPA(x) RTE_BIT32(x) >>> + >>> +/* This macro indicates link speed lanes capa mask */ >>> +#define RTE_ETH_SPEED_LANES_CAPA_MASK(x) RTE_BIT32(RTE_ETH_SPEED_ ## x) >>> + >>> >> >> I am not clear why we need these macros, why not use lane number as >> unsigned integer, instead of macro (RTE_ETH_SPEED_LANE_2), it will be >> more flexible. >> > > ok, I can replace the macros with unsigned integers > >> Probably all we need is 'RTE_ETH_SPEED_LANES_TO_CAPA' one to use as >> helper in drivers. >> Again not sure about the ..CAPA_MASK one, does it actually produce a >> mask value? >> >> > once replacing the LANE_xx to unsigned integers, then I don't need x_CAPA_MASK. > In the driver, I can call RTE_32(lane number) while populating the table. > EG: > > { RTE_ETH_SPEED_NUM_100G, RTE_ETH_SPEED_LANES_CAPA_MASK(LANE_1) | > RTE_ETH_SPEED_LANES_CAPA_MASK(LANE_2) | > RTE_ETH_SPEED_LANES_CAPA_MASK(LANE_4) }, > will become > > { RTE_ETH_SPEED_NUM_100G, RTE_BIT32(1) | > RTE_BIT32(2) | > RTE_BIT32(4) }, > ack