DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Li Feng <fengli@smartx.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: lifeng1519@gmail.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_eal: add APIs to speedup virt2iova/phys
Date: Mon, 20 Apr 2020 13:16:53 +0100
Message-ID: <bc7ce6c4-e545-2f2b-a1cb-34a56d66b4b7@intel.com> (raw)
In-Reply-To: <20200420110953.959884-1-fengli@smartx.com>

On 20-Apr-20 12:09 PM, Li Feng wrote:
> Using pread to replace lseek + read.
> And add new APIs to reduce open/close/lseek system call frequency when the
> user needs to convert a large range of virtual address space.
>      - rte_mem_virt2iova_with_fd
>      - rte_mem_virt2phy_with_fd
> Currently it will be used by spdk in spdk_mem_register.
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---

These API's are IMO already on the verge of what's acceptable because of 
the differences between PA, DPDK IOVA and external memory IOVA. I'm not 
sure building on top of them is a good idea. It's also quite platform 
specific - rte_mem_virt2phy could potentially work with Windows (and in 
fact there was an RFC for it), but would this API work with Windows, 
given that Windows doesn't have fd's? Should we perhaps replace fd's 
with an opaque structure pointer, so that each platform-specific 
implementation could dereference it the way it needs to, without 
exposing internal details of the platform?


  reply	other threads:[~2020-04-20 12:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 11:09 Li Feng
2020-04-20 12:16 ` Burakov, Anatoly [this message]
2020-04-20 13:07   ` Dmitry Kozlyuk
2020-04-20 14:13     ` Li Feng
2021-03-25 13:32       ` David Marchand
2021-03-29  6:26         ` Li Feng
2021-04-01 10:38         ` Burakov, Anatoly
2021-04-06 10:40           ` Feng Li
2021-04-06 11:23             ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc7ce6c4-e545-2f2b-a1cb-34a56d66b4b7@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengli@smartx.com \
    --cc=lifeng1519@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git