From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jianfeng.tan@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1A21A25B3 for <dev@dpdk.org>; Thu, 12 Oct 2017 04:14:29 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2017 19:14:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,363,1503385200"; d="scan'208";a="322283550" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.67.64.59]) ([10.67.64.59]) by fmsmga004.fm.intel.com with ESMTP; 11 Oct 2017 19:14:26 -0700 To: Shreyansh Jain <shreyansh.jain@nxp.com> References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1507548444-33959-1-git-send-email-jianfeng.tan@intel.com> <1507548444-33959-4-git-send-email-jianfeng.tan@intel.com> <7732f195-64fd-308c-8faf-c1b0e37d3453@nxp.com> <4883d822-9aa0-4b88-048c-35d7e9da9c1c@intel.com> <89d68ff6-9eca-185f-c7c0-8aaaf9e514b0@nxp.com> Cc: dev@dpdk.org, jblunck@infradead.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com From: "Tan, Jianfeng" <jianfeng.tan@intel.com> Message-ID: <bc9e772a-c057-a35b-48de-85e89364e8c4@intel.com> Date: Thu, 12 Oct 2017 10:14:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <89d68ff6-9eca-185f-c7c0-8aaaf9e514b0@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 12 Oct 2017 02:14:30 -0000 On 10/11/2017 7:20 PM, Shreyansh Jain wrote: > On Wednesday 11 October 2017 04:12 PM, Tan, Jianfeng wrote: >> >> >> On 10/11/2017 2:54 PM, Shreyansh Jain wrote: >>> Hello Jianfeng, >>> >>> On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote: >>>> >> [...] >>>> -#define PMD_DRV_LOG(level, fmt, args...) \ >>>> - PMD_DRV_LOG_RAW(level, fmt "\n", ## args) >>>> +#define FSLMC_VFIO_LOG(level, fmt, args...) \ >>>> + RTE_LOG(level, EAL, "%s(): " fmt "\n", __func__, ##args) >>> >>> This change breaks the FSLMC bus driver. There are macros like >>> PMD_DRV_LOG which are still in use in the code. >>> Before removing the above, those would have to be restructured. >> >> Just try to change all PMD_DRV_LOG in fslmc to FSLMC_VFIO_LOG. As you >> are working on that, I will drop it. > >>> >>> I am already working on converting this logging into dynamic logging. >>> Can you skip this work until then? Does it block your work? >> >> Do you mean you are working on introducing a new log type for bus >> drivers? > > A dynamic log type using rte_log_register. So, "bus.fslmc", > "net.dpaa2" and so on. I am not introducing LOGTYPE_BUS. > > In past [1], I sent a patch for LOGTYPE_BUS but at that time I > understood that dynamic logging is the preferred way. > > [1] http://dpdk.org/dev/patchwork/patch/24478/ OK, that makes sense. I'll hold this change then. Thanks for your insight on this. Thanks, Jianfeng