Re: [dpdk-dev] [PATCH v3 00/56] net: txgbe PMD

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/14/2020 6:54 AM, Jiawen Wu wrote:
> v3: Merge some recent changes in the main repo,
>      fix the checkpatch warnings.
> v2: Re-order patches and fix some known problems.
> v1: Introduce txgbe PMD.
> 
> Jiawen Wu (56):
>    net/txgbe: add build and doc infrastructure
>    net/txgbe: add ethdev probe and remove
>    net/txgbe: add device init and uninit
>    net/txgbe: add error types and registers
>    net/txgbe: add MAC type and bus lan id
>    net/txgbe: add HW infrastructure and dummy function
>    net/txgbe: add EEPROM functions
>    net/txgbe: add HW init and reset operation
>    net/txgbe: add PHY init
>    net/txgbe: add module identify
>    net/txgbe: add PHY reset
>    net/txgbe: add info get operation
>    net/txgbe: add interrupt operation
>    net/txgbe: add device configure operation
>    net/txgbe: add link status change
>    net/txgbe: add multi-speed link setup
>    net/txgbe: add autoc read and write
>    net/txgbe: add MAC address operations
>    net/txgbe: add unicast hash bitmap
>    net/txgbe: add Rx and Tx init
>    net/txgbe: add Rx and Tx queues setup and release
>    net/txgbe: add Rx and Tx start and stop
>    net/txgbe: add packet type
>    net/txgbe: fill simple transmit function
>    net/txgbe: fill transmit function with hardware offload
>    net/txgbe: fill Tx prepare function
>    net/txgbe: fill receive functions
>    net/txgbe: add device start operation
>    net/txgbe: add Rx and Tx data path start and stop
>    net/txgbe: add device stop and close operations
>    net/txgbe: support Rx interrupt
>    net/txgbe: add Rx and Tx queue info get
>    net/txgbe: add device stats get
>    net/txgbe: add device xstats get
>    net/txgbe: add queue stats mapping
>    net/txgbe: add VLAN handle support
>    net/txgbe: add SWFW semaphore and lock
>    net/txgbe: add PF module init and uninit for SRIOV
>    net/txgbe: add process mailbox operation
>    net/txgbe: add PF module configure for SRIOV
>    net/txgbe: add VMDq configure
>    net/txgbe: add RSS support
>    net/txgbe: add DCB support
>    net/txgbe: add flow control support
>    net/txgbe: add FC auto negotiation support
>    net/txgbe: add priority flow control support
>    net/txgbe: add device promiscuous and allmulticast mode
>    net/txgbe: add MTU set operation
>    net/txgbe: add FW version get operation
>    net/txgbe: add EEPROM info get operation
>    net/txgbe: add register dump support
>    net/txgbe: support device LED on and off
>    net/txgbe: add mirror rule operations
>    net/txgbe: add PTP support
>    net/txgbe: add DCB info get operation
>    net/txgbe: add Rx and Tx descriptor status
> 

Hi Jiawen,

Thanks for the effort, driver looks mostly good, only I put a few minor comments.

Also can you please update the release notes 
(doc/guides/rel_notes/release_20_11.rst) to announce the new PMD?
I think it can be part of first patch.

Also after patch merged, can you please send a web patch [1] to add your device 
to the https://core.dpdk.org/supported/#nics?

[1] https://git.dpdk.org/tools/dpdk-web/