From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C922A04DB; Thu, 15 Oct 2020 02:57:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B89951DB76; Thu, 15 Oct 2020 02:56:19 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 074DB1DB76 for ; Thu, 15 Oct 2020 02:56:17 +0200 (CEST) IronPort-SDR: dMg4ZQpEVD6TeKcLJ5fbZ7/wZR4Y4Lp0c7D4Xy4tA4MglBbgBCJubBOlkAtf/EEOgtXPt+AqZ7 6mdfbSA2XYtw== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="165443744" X-IronPort-AV: E=Sophos;i="5.77,376,1596524400"; d="scan'208";a="165443744" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 17:56:15 -0700 IronPort-SDR: v1NRRJGsQVHnW7clVf/7AJdCxs6V8dYTJZGGBoNM31f1K6qbOyciL6h8fV4TMfMO7W+OLI/n0d yyRxZXugmfiQ== X-IronPort-AV: E=Sophos;i="5.77,376,1596524400"; d="scan'208";a="464088278" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.212.224]) ([10.213.212.224]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 17:56:15 -0700 To: Jiawen Wu , dev@dpdk.org References: <20201014055517.1214386-1-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: Date: Thu, 15 Oct 2020 01:56:13 +0100 MIME-Version: 1.0 In-Reply-To: <20201014055517.1214386-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 00/56] net: txgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2020 6:54 AM, Jiawen Wu wrote: > v3: Merge some recent changes in the main repo, > fix the checkpatch warnings. > v2: Re-order patches and fix some known problems. > v1: Introduce txgbe PMD. > > Jiawen Wu (56): > net/txgbe: add build and doc infrastructure > net/txgbe: add ethdev probe and remove > net/txgbe: add device init and uninit > net/txgbe: add error types and registers > net/txgbe: add MAC type and bus lan id > net/txgbe: add HW infrastructure and dummy function > net/txgbe: add EEPROM functions > net/txgbe: add HW init and reset operation > net/txgbe: add PHY init > net/txgbe: add module identify > net/txgbe: add PHY reset > net/txgbe: add info get operation > net/txgbe: add interrupt operation > net/txgbe: add device configure operation > net/txgbe: add link status change > net/txgbe: add multi-speed link setup > net/txgbe: add autoc read and write > net/txgbe: add MAC address operations > net/txgbe: add unicast hash bitmap > net/txgbe: add Rx and Tx init > net/txgbe: add Rx and Tx queues setup and release > net/txgbe: add Rx and Tx start and stop > net/txgbe: add packet type > net/txgbe: fill simple transmit function > net/txgbe: fill transmit function with hardware offload > net/txgbe: fill Tx prepare function > net/txgbe: fill receive functions > net/txgbe: add device start operation > net/txgbe: add Rx and Tx data path start and stop > net/txgbe: add device stop and close operations > net/txgbe: support Rx interrupt > net/txgbe: add Rx and Tx queue info get > net/txgbe: add device stats get > net/txgbe: add device xstats get > net/txgbe: add queue stats mapping > net/txgbe: add VLAN handle support > net/txgbe: add SWFW semaphore and lock > net/txgbe: add PF module init and uninit for SRIOV > net/txgbe: add process mailbox operation > net/txgbe: add PF module configure for SRIOV > net/txgbe: add VMDq configure > net/txgbe: add RSS support > net/txgbe: add DCB support > net/txgbe: add flow control support > net/txgbe: add FC auto negotiation support > net/txgbe: add priority flow control support > net/txgbe: add device promiscuous and allmulticast mode > net/txgbe: add MTU set operation > net/txgbe: add FW version get operation > net/txgbe: add EEPROM info get operation > net/txgbe: add register dump support > net/txgbe: support device LED on and off > net/txgbe: add mirror rule operations > net/txgbe: add PTP support > net/txgbe: add DCB info get operation > net/txgbe: add Rx and Tx descriptor status > Hi Jiawen, Thanks for the effort, driver looks mostly good, only I put a few minor comments. Also can you please update the release notes (doc/guides/rel_notes/release_20_11.rst) to announce the new PMD? I think it can be part of first patch. Also after patch merged, can you please send a web patch [1] to add your device to the https://core.dpdk.org/supported/#nics? [1] https://git.dpdk.org/tools/dpdk-web/