From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02457A034C; Wed, 23 Feb 2022 13:49:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 852A641226; Wed, 23 Feb 2022 13:49:32 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 0D26E411B2; Wed, 23 Feb 2022 13:49:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645620571; x=1677156571; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=096fniI6HWJNI6fQldwKhEZai0rtAe3KF8xN5RYbqd4=; b=Ujy1dfECX/QC7O115uB5zNxM8Rm6NzA1/asALaBrLt4PrcaAE23yDKFD CtzPJ9pXtPIptJ/kYofr0RZ+CM/+MH3j5lsxxIaL6qvF0Iw8XAdXm1nl8 vC0qq3O/d6N3iOdoqRLQ8NGevebVI98AoBdplTfWTS5wJyCD7e7gTJw3o VBOoJ++OCPemxut4QEkhPr6d7fS9L1nHDkJEn/UhQGsb/0sfVJF85y8FS KwJDmPPhbpbHvuKXNbQ7BO7N2ywZ3gVBoSrFjA96dyoE6OodtQnChhbY9 hrzINZ0LR7Pt8lDxkvaYrk4YFKnTOTxetv3YV0/5VVdhYgMxifI0DV7+H g==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="231927824" X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="231927824" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 04:49:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="707018895" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 23 Feb 2022 04:49:29 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 04:49:29 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 23 Feb 2022 04:49:28 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 23 Feb 2022 04:49:28 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 04:49:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GDoFj2tgkd9INxjqMJI8ekNfNASz+6PReiDxr2WfkeyonrMyxB+w/HMCBpBpDKbZsEBl3ODEku6DkREWMdRVPxsv6NlM4vPoqkFTHHXEy3v7Td/Ce5YXa4jA/omAKLYRTvGJs8DeNtJqMeFk43rWRcFdrb40l9QIgozcYxkT5YqLYErvIWpl+M0u7xM5D7mh4sS2lYVGxTyfGvKZzlWCVUgDQJfd8Y6oZSPcv64ZGzvkYQWnhg4BQgTneKBHnSgKmyJhJS0+3ttFUEaHBpyXGiJlqfskIkA8NIsDS9Dkjcvk7KsvwKmT6/1TWu35lTxebzlTwsUkh3uDZ0xxjd1csA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8odYwFC5vF4WIHyugvdpTGGmQPirLYwSmpcpYIi6hdA=; b=Wpc5Dq2J1ejYwRnQZ2D4wHj/LqCEOmbaYruQC7ffu7/HMT0G2hy8Uk7ny+nkRZ2OclNBeGElU+xMgRfYmAJdqNaSVMzNzOO3UVwLHbGCRdeHYDZxoTBQFTqb3Dm8J3BVIb1GVwY3ylRPCoidaLZitra8Z2rCnFymH+e/m1Qdv9LQR7Ex7Qs84dxMzxUkYo5mX3615Bp3PV6a7Y5tX29Fkjo/pH989NI/Y5h1TW5y6nXfauYzPkB7lnEr70NzjWhUPyiGN9YWMY/B1JVUzdEl64p124cUNRwDCx2Nz72fD3ZUDHCjGxSdrXG2jtB6VHq4KAsu0wrCt/1/FDsH6r+sbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BYAPR11MB3336.namprd11.prod.outlook.com (2603:10b6:a03:1a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Wed, 23 Feb 2022 12:49:27 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Wed, 23 Feb 2022 12:49:27 +0000 Message-ID: Date: Wed, 23 Feb 2022 12:49:21 +0000 Content-Language: en-US To: Jiawen Wu , CC: References: <20220223102857.24816-1-jiawenwu@trustnetic.com> <20220223102857.24816-3-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH v2 2/2] net/txgbe: fix debug log X-User: ferruhy In-Reply-To: <20220223102857.24816-3-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0002.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6686108-9b20-468f-faaf-08d9f6caed12 X-MS-TrafficTypeDiagnostic: BYAPR11MB3336:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M875lXy3Nsp+dY8RNQ0M1KopjkMyoJp9kMbER0zydi86XdClyxGXETbpTguX9LYnDuO3WJN6BMxbWH+ytzOvOY9Lb6M9QZzfCFiD3eYlazMHNECRtctGFJCFushFkeLIkHsSppi+w0iH2V+pUIjYx7eSBP7OTepOtoIC2kEiRuJ00ByO0v4j/9gj+3Gqy9PwM+/bXERA50iitFF+hxmHUNDQsr47iaxav1iVUInxH8A6obN0UagqDJRiiheqvMSR95fLgGFz2Ls55Ir0ZfoJS7RI1SKdLlLWb/3YQrVMR5EC0unOCivG97ap2d/DLM/jO7rmXqjqvbHpXmIjUK6vO9yA1TFE/q5TPi4VhM6PZRKl5Xve5l9cG6uzoXkkwIR0KShv8HrUGlQOufpeRMw3iiJJ4q/tWexkPTBEnJuGSAIyogYKcwcHDFK1RlI3SZgJd9XUieY+d1y6YXUwupvT4d5I6lSaWgpA+AZ46j1U2cU1Y9ajbo4oqlW0jhJnUupFmy9l3K0zMAweG4Zyp09wE0eFRHefzmjFbJTZz5wsyKkv3mmjv1vR9XEN17EOjTJraEXQS1az0QLxxBAFmavq9koGki6xlDwre+h5KiCcKqkQvVbuohbqcZ/qxJy0IjUuxzk/Mzyuhiru8obfgmBVFtYvXY0rtja0BJN3q+d1QjGNkiGGo+LOS7MPKCoSyihjYd97lqCHq2yAhsqqkYqedg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(8936002)(8676002)(66556008)(44832011)(6666004)(5660300002)(86362001)(31696002)(4326008)(6512007)(316002)(53546011)(66476007)(508600001)(66946007)(2616005)(6486002)(186003)(83380400001)(31686004)(26005)(2906002)(36756003)(82960400001)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmwwL0prV0VMYkRrMnNmYXBpRGRueEphN1NUeXBmSmQ5eWZOVWZGRXorc3B6?= =?utf-8?B?aDVjN25DTXduS1c1V1FuTUUrTkNmR25wQTQ3TjFWUHBacTFjanZoSXl0VTNq?= =?utf-8?B?Snl0N1phb3hpMncvT1FGUSsxY1VFeWRUQmgxSStDcWtiZG4vMGs4YmV0YkNZ?= =?utf-8?B?VDlFVUorMGl3dTdSNlZXbjE3Qi9zQkVRRWRMWm1FcW9hbldXV3N3NW94b2kv?= =?utf-8?B?TXlVQzBDY2M1ZytMcVJGaXNvbDExUE53Q2lZSitoZjRqUmRUZGF3MVR1WDB1?= =?utf-8?B?YkFpUVFOdWJjNXhRbDEyK1NHVTc0QS8xZ3pmbk9vK3RUcG9jVk9JMGd5ZDVo?= =?utf-8?B?eTIzRUxodllUWnNrKzgrU0tCTGxvTiswNEwwUTdHanhCUzRNYnRESWdYOFhC?= =?utf-8?B?RnZ1YmNLYldOWjhaUUdYeEk3L0lFMm80eUl1UUk1RXRKTHBIek9kZUFCd015?= =?utf-8?B?cGNRMDFNUE91WFBvREZ6bmlneDJ4eUpUZ0VPZ2Y3M09yV0xWVGtIMjMrNll4?= =?utf-8?B?MzZMbXdKcjErLzhlSThSUUdhdE5WWTlVVmRzbFIzMFlrMEc3SmVSeGxmWHRw?= =?utf-8?B?TXY0WDhpcnBsK0RXVWo3WEFhYzdoc2ZJb0Q3SldST0Z5UmVKbTQ1Qi9qWkoz?= =?utf-8?B?cEpPdGp2Zloya2NHczlQWldzdnRZaGdFMXROc25jZm1yVURZRDhtdEZiVU1K?= =?utf-8?B?MktXZmRsTjNXdm93anBBTWduZ09xKy85N2pFZnEyWlFWVFlGQ2VLUkxoVkNo?= =?utf-8?B?d3U2ck5IdHRsK25jUVpZcWJQcVkzWjF4aE9OK0hEaW54ekIvU2VqczFUWm9n?= =?utf-8?B?ZTk4ZVBzWFEySzlhbFExbXJhOWFIMGlMbkRYYjlxa3A5S2JaQWdqcE54czc4?= =?utf-8?B?OVE0RUYyUy85NzFPSURQRUR6QjNOczk3UE9wTGw4UXFpTGduRnFOUFBWYXdH?= =?utf-8?B?OEtwRGN5SzcyYXI5dHNha3h6RDRvdXRVb0tMWVZHV1Nxa2p2Qi9nK2ZlUnN6?= =?utf-8?B?a2FMWXlKYWM1OE5SdG5NN0hrZXlvWVV4dGZkc0ZMaXVVTVNiNUFvb2Q5V0xE?= =?utf-8?B?KzVMU0cyNStCWExYZ0kxc1MzZE1LTHdGTU9mQ0xpV1Nobk1BMjhnZ1FXYjNv?= =?utf-8?B?bUtuZjJVQ09SRFNoR1Z4NWtYRmRvMU9VamV4WnJyWmt0Yk9nT0RwMFNaYStq?= =?utf-8?B?YWpUYXNqdEU0djdXRWlLNUlwR2hoSmlmanVZa2syaTk1T2JET2kyREVRcFI0?= =?utf-8?B?Q0xiUklRNjRKbHNsT3hmRlRUNEc1azNqN3IxWG0vb2tZWDRrRk5DWmJNa3Bt?= =?utf-8?B?OWFyanhUR3gwTGhqQktlTndYMGJoVVRCSlpJMG9xOWorREFRWjZxRXU0TGgx?= =?utf-8?B?MDY0bGY0eFVXdm03blUrMlNpM3NPRFBtMFBTdW4xeUgvMFVEMUxDU2R4Y3Zu?= =?utf-8?B?L1BmeVBJT2RMajIxb05Tdm1xVFJNU2xTUE1jZWxMb0hMWHkxc214RWtoczlW?= =?utf-8?B?ZjNLcWs5TlBRUHorRW9HTGJzZnd2Zm9BNForMU9GNEhjQlU3WStpWnZvK2Zj?= =?utf-8?B?QkhkelBvSWhxVVJJcklIc1ovMElBeXNYK2ZrQTU2QmdBd0NpaWZqOU5YRk9K?= =?utf-8?B?NGFLMmIzVUVSVmdWYndjSFF0c0M3UDRud29nd29pelcxWTZzYlRBVWkvcVh5?= =?utf-8?B?RSs1Y2JnVWdQNlU1eS9UcUdEOXdYS2JTZ2VSMThGMTQrVThoU29JcmJXOURt?= =?utf-8?B?Y05MejY0a1I2Nk9ZR3NId3ZQbVo5OWViazRJUjdlSlFFZFE2T3RDcCtIYUgr?= =?utf-8?B?OXVTT0I5Rmh2T0NhaGlSMTZHcVVhclh6RWJvclVTWUZWZkkrbWRYWVBtYTk0?= =?utf-8?B?dlpjZHlYM05qNG03TWpSVXI1N2NBSk0xT1pmd3N4RmtEMlVNWlpFTVZIWFY0?= =?utf-8?B?MDdXZUpkUkZXZlpNRHVkYWV4NFJKWjIxNTR1K3NGemFsSlY4VmZobVNXL3ln?= =?utf-8?B?SGVIY2o0em1sNUx2Z3pqQXBoRFlwMWhxUEZIZi9LSWVVY0h4cTgvNjRITjEw?= =?utf-8?B?dFNhVUVZcFVjM1M4NWFnSGNpb2VXTlllTFhiV3J6cXZvdHVlZmNzYURuZkcz?= =?utf-8?B?cVZUTk8wSFFNL1E2bzRJYnNwRmw4Qnd5MWE3YmVWeXM5amd2N0IxSmhkQnBz?= =?utf-8?Q?RUHZsVuUafwhxYCUmwrZeuE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c6686108-9b20-468f-faaf-08d9f6caed12 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 12:49:27.2937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BM2NBeaXYFcMNt9rAcTwApCAY1X4XTvcZRW+0qLwGgqIX+0MyBYqY4jLWcvaVZ7N7XEsYHC5xe/FjPsbeTGDIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3336 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2022 10:28 AM, Jiawen Wu wrote: > Remove 'DEBUGFUNC' due to too many invalid debug log prints, unify the > DEBUG level macros. > > Fixes: 7dc117068a7c ("net/txgbe: support probe and remove") > Cc:stable@dpdk.org > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/base/meson.build | 2 +- > drivers/net/txgbe/base/txgbe_eeprom.c | 41 ++---- > drivers/net/txgbe/base/txgbe_hw.c | 202 ++++++-------------------- > drivers/net/txgbe/base/txgbe_mbx.c | 38 ----- > drivers/net/txgbe/base/txgbe_mng.c | 21 +-- > drivers/net/txgbe/base/txgbe_osdep.h | 1 + > drivers/net/txgbe/base/txgbe_phy.c | 84 ++--------- > drivers/net/txgbe/base/txgbe_vf.c | 12 +- > drivers/net/txgbe/txgbe_logs.h | 7 +- > 9 files changed, 79 insertions(+), 329 deletions(-) > > diff --git a/drivers/net/txgbe/base/meson.build b/drivers/net/txgbe/base/meson.build > index 7a30191472..09da79af40 100644 > --- a/drivers/net/txgbe/base/meson.build > +++ b/drivers/net/txgbe/base/meson.build > @@ -22,6 +22,6 @@ foreach flag: error_cflags > endforeach > > base_lib = static_library('txgbe_base', sources, > - dependencies: static_rte_eal, > + dependencies: [static_rte_eal, static_rte_ethdev], Is this because of 'RTE_ETHER_ADDR_PRT_FMT' macro? If so dependency should be 'static_rte_net', not ethdev.