From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 779CAA04E7; Thu, 5 Nov 2020 19:12:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86A762BD5; Thu, 5 Nov 2020 19:11:57 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id BAF79F64; Thu, 5 Nov 2020 19:11:53 +0100 (CET) IronPort-SDR: bflKMdskksHb7n2i4czZonBV+3ZAxiO82vY4a/ZutYH6pbEoAcOvchdVW+vEjbfo4WKgm3AR8p NCWhiz8757cg== X-IronPort-AV: E=McAfee;i="6000,8403,9796"; a="157214403" X-IronPort-AV: E=Sophos;i="5.77,454,1596524400"; d="scan'208";a="157214403" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 10:11:51 -0800 IronPort-SDR: u2gbMyUQHdpW6SP3/2cQG0epMNXT0w6OGP2BAMPchmeBe2zfqQ8Utx3yfruLJl+fIVxc4A5nM1 gk4/wkp0dSXg== X-IronPort-AV: E=Sophos;i="5.77,454,1596524400"; d="scan'208";a="539510566" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.252.54]) ([10.213.252.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 10:11:48 -0800 To: Thomas Monjalon , dev@dpdk.org Cc: david.marchand@redhat.com, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, lance.richardson@broadcom.com, maxime.coquelin@redhat.com, stable@dpdk.org, Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Steve Yang References: <4da07e46-cf17-57ac-c38d-aa82aacc895e@intel.com> <20201105174424.4131345-1-thomas@monjalon.net> From: Ferruh Yigit Message-ID: Date: Thu, 5 Nov 2020 18:11:44 +0000 MIME-Version: 1.0 In-Reply-To: <20201105174424.4131345-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length adjustment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/5/2020 5:44 PM, Thomas Monjalon wrote: > The fix of max_rx_pkt_len for allowing VLAN packets in all cases > was breaking configuration of some drivers. Example with virtio: > > Ethdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728 > Fail to configure port 0 > > Trying to fix the logic was revealing other issues in some drivers. > That's why it is decided to revert. > > The workaround for the original issue would be > to set the MTU explicitly from the application > with rte_eth_dev_set_mtu(). > Sent this option as RFC: https://patches.dpdk.org/patch/83756/ > Fixes: f6870a7ed6b3 ("app/testpmd: fix max Rx packet length for VLAN packet") > Cc: stable@dpdk.org > > Reported-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit