DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v5] net/tap: Allow jumbo frames
@ 2022-08-08 12:29 Francesco Mancino
  2022-08-08 14:43 ` Stephen Hemminger
  0 siblings, 1 reply; 2+ messages in thread
From: Francesco Mancino @ 2022-08-08 12:29 UTC (permalink / raw)
  To: dev

eth_dev_validate_mtu, introduced in 990912e676e, validates configured
MTU plus overhead against max_rx_pktlen.
Since TAP is a virtual device, it should support as big MTU as possible.
---
 drivers/net/tap/rte_eth_tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 9e1032fe72..54ca4ca5e9 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1066,7 +1066,7 @@ tap_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 
 	dev_info->if_index = internals->if_index;
 	dev_info->max_mac_addrs = 1;
-	dev_info->max_rx_pktlen = (uint32_t)RTE_ETHER_MAX_VLAN_FRAME_LEN;
+	dev_info->max_rx_pktlen = (uint32_t)RTE_ETHER_MAX_JUMBO_FRAME_LEN;
 	dev_info->max_rx_queues = RTE_PMD_TAP_MAX_QUEUES;
 	dev_info->max_tx_queues = RTE_PMD_TAP_MAX_QUEUES;
 	dev_info->min_rx_bufsize = 0;
-- 
2.34.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v5] net/tap: Allow jumbo frames
  2022-08-08 12:29 [PATCH v5] net/tap: Allow jumbo frames Francesco Mancino
@ 2022-08-08 14:43 ` Stephen Hemminger
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2022-08-08 14:43 UTC (permalink / raw)
  To: Francesco Mancino; +Cc: dev

On Mon, 8 Aug 2022 14:29:25 +0200
Francesco Mancino <francesco.mancino@tutus.se> wrote:

> eth_dev_validate_mtu, introduced in 990912e676e, validates configured
> MTU plus overhead against max_rx_pktlen.
> Since TAP is a virtual device, it should support as big MTU as possible.

In all your tries at the patch, you must not have run checkpatch because
it would have informed you that Signed-off-by (a.k.a Developers Certificate of Origin)
is required for any DPDK patch to be accepted.

Please add Signed-off-by and fix the cast.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-08 14:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-08 12:29 [PATCH v5] net/tap: Allow jumbo frames Francesco Mancino
2022-08-08 14:43 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).