From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B0ABA0A0C; Fri, 2 Jul 2021 15:59:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E87B7413DB; Fri, 2 Jul 2021 15:59:58 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id DB48B41353 for ; Fri, 2 Jul 2021 15:59:57 +0200 (CEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GGc801gxZzZnZm; Fri, 2 Jul 2021 21:56:48 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 2 Jul 2021 21:59:56 +0800 Received: from [127.0.0.1] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 2 Jul 2021 21:59:56 +0800 To: Liang Ma CC: Bruce Richardson , Jerin Jacob , Jerin Jacob , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Nipun Gupta , Thomas Monjalon , Ferruh Yigit , dpdk-dev , Hemant Agrawal , Maxime Coquelin , Honnappa Nagarahalli , David Marchand , Satananda Burla , "Prasun Kapoor" References: <25d29598-c26d-8497-2867-9b650c79df49@huawei.com> <3db2eda0-4490-2b8f-c65d-636bcf794494@huawei.com> From: fengchengwen Message-ID: Date: Fri, 2 Jul 2021 21:59:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] dmadev discussion summary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/7/2 15:07, Liang Ma wrote: >> 8) One example: >> vq_id = rte_dmadev_queue_setup(dev, config.{HW-queue-index=x, opaque}); >> if (vq_id < 0) { >> // create virt-queue failed >> return; >> } >> // submit memcpy task >> cookit = rte_dmadev_memcpy(dev, vq_id, src, dst, len, flags); >> if (cookie < 0) { >> // submit failed >> return; >> } > IMO > rte_dmadev_memcpy should return ops number successfully submitted > that's easier to do re-submit if previous session is not fully > submitted. emm, I didn't get your point. Welcome review the new patch, tks >> // get complete task >> ret = rte_dmadev_completed(dev, vq_id, &cookie, 1, has_error); >> if (!has_error && ret == 1) { >> // the memcpy successful complete >> } >> 9) As octeontx2_dma support sg-list which has many valid buffers in >> dpi_dma_buf_ptr_s, it could call the rte_dmadev_memcpy_sg API. >> 10) As ioat, it could delcare support one HW-queue at dev_configure stage, and >> only support create one virt-queue. >> 11) As dpaa2_qdma, I think it could migrate to new framework, but still wait >> for dpaa2_qdma guys feedback. >> 12) About the prototype src/dst parameters of rte_dmadev_memcpy API, we have >> two candidates which are iova and void *, how about introduce dma_addr_t >> type which could be va or iova ? >> > > . >