From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 172F6A034F; Tue, 23 Feb 2021 23:06:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AE8A4068C; Tue, 23 Feb 2021 23:06:07 +0100 (CET) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id BE0624068B for ; Tue, 23 Feb 2021 23:06:06 +0100 (CET) Received: by mail-wr1-f51.google.com with SMTP id h98so19290238wrh.11 for ; Tue, 23 Feb 2021 14:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=CQwfjrgp7OYOPEEyGMRFLdhPl6UzYb5N6W/A7w1liMk=; b=qv2iE8yh/MAQHBN387siZluwyjo6/OC+bT4t4iaLt91krfMiDjKswl5Ydz49UtMA1X Bm7oyJ5pVFKnYnbImP4jClQiCsZVpqBYHG8GFeVUOxUP25Dr1jOotYhesDXKQTIkZjuG 0wvU4VtOXDfZuz41v7U97rUPAlVf5HNGScOTaXDlrNuyxZjGKpl5qZpcf0PNcd3T2rV/ MXWjQM2uMgTTy1KvooyAkH8B4fgpCfuqE2S0N7kV6GyYoxfUG5d4HSGE8xss9mLNqFRe XIKhoCWagdU7OSHdgVcO7/LUvn61D92heM5Otpsyp4mrEHVEZg30sxEpOXRFetuFnyPM 2l5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CQwfjrgp7OYOPEEyGMRFLdhPl6UzYb5N6W/A7w1liMk=; b=W+D63ARBNSJcoBDI42ZHNb6FncNun8tjYoE6bto1ATmL3DUskxCzuO3QHHx/ZMkWLa QQCE8k0LhJuUuur1oXevVQzFIBVIEhwgvOemsRsvvd0EyMxs2z/8ztxGuiADCI944xBT UgUtg8QmTml3QkUB67agdOu6yGq5BMkrMZPwUo83XXHIwBx5tWhpFI1nc0yLDkPBP6qX hiVUr0+ZBr077sev6ItyrNc/32iRSLnDuR6SAVGDwr/2BJfma0+tSAbxvDZNzB4oKWNG 7Tbxa2EbU+BjEOTm7/l8PUEQd/1mlss3h9RAOuso4tdWNeOgWNwSnP4DVdMPvcs4OGdw T9WA== X-Gm-Message-State: AOAM532TS0TAkt24euGIU/8lz/L3uyKxpAFwETx3LdYj9C6Jl8wQb18T KUptXJRQ0n3O2g4k83NNPdB8+A== X-Google-Smtp-Source: ABdhPJztTgCXIAgz0N9dRsJhAw/ShITWpjQsF/Xt6f+KhkkbW3eAf4dPI3JrUMdO1Be8iXABz0oRjQ== X-Received: by 2002:adf:e68d:: with SMTP id r13mr27804628wrm.303.1614117966410; Tue, 23 Feb 2021 14:06:06 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id a14sm75172wrg.84.2021.02.23.14.06.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Feb 2021 14:06:06 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Dmitry Kozlyuk , dev@dpdk.org Cc: Tal Shnaiderman , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman References: <20210221012831.14643-1-dmitry.kozliuk@gmail.com> <20210221142819.6769-1-dmitry.kozliuk@gmail.com> <20210221142819.6769-4-dmitry.kozliuk@gmail.com> Message-ID: Date: Tue, 23 Feb 2021 22:06:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210221142819.6769-4-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v3 3/7] eal: add sleep API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, > +void > +rte_thread_sleep(unsigned int sec) > +{ > + return Sleep(MS_PER_S * sec); > +} There's probably no benefit in returning the 'void' value - I'd suggest just call Sleep(). Regards, Nick