From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ED8CA0540; Thu, 16 Jul 2020 10:28:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDCAA1BEE4; Thu, 16 Jul 2020 10:28:46 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id B31751BED9 for ; Thu, 16 Jul 2020 10:28:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594888125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b/59sbp8ah9H5Yw3kh7JBW5FT+AGje/i4LFx+TNr54s=; b=B2KUAGb1OcFsAjiYt4B54QeEePEE0Y0gFYratLYLKZI+4jNeNoubu38Obf1/nGeCPo/Psj 3blmlJOIAcUugUQxXuAXtYxFfRVzzMVjh9SlUdHKdPlZEBS4XgZuAmZkcSnMgUIv+fNQzj /eXi/uR+wjwRsJ9uXFuKV7W+om9/dFU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-L-fOZKPvP92LNzeWuJUtbw-1; Thu, 16 Jul 2020 04:28:43 -0400 X-MC-Unique: L-fOZKPvP92LNzeWuJUtbw-1 Received: by mail-wm1-f70.google.com with SMTP id v11so4840398wmb.1 for ; Thu, 16 Jul 2020 01:28:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=b/59sbp8ah9H5Yw3kh7JBW5FT+AGje/i4LFx+TNr54s=; b=pB4MaWKo/5GHkBFtijcCZsULqtWo1F/uUlvkG/duOY/aB6LmNXlvAtAR4hEcz/Dyvl M1+vFhzAUI9bTI6FMCd8TBmoC3OW9hJnqdTwLT+LAO+7RxLXvTB0xzJ94cnk2Sp5grcW z3MwgyLXKUKrGVTJQ4UMSjifksNKiBVKnJTC2xoYENTr5iPSrjmXrAq1Jij3HVFjSt7A rJDlKtm+Sffes85wPkCT6tTO7eomRY99jZyqX68G11uhV4eE9tr7NxjW68ttZL8aYaUh SK8XVlxYt+39Cswb9HDLflzfbFTWxA1kpNUW+x4k6C2mhdDHxW9MJBb0n/D/A0p1I1zz Y1Hw== X-Gm-Message-State: AOAM531anwIzJ2q7hOwQN7Rq+l2X5nx4YXlmou7lOCgn8hkoaqpMxAUf tYLcwF8EBi8SFslZgp6T6x6+nXR6F8NumCffbB4EyFLkxPMnzmGupUTF/fKxCDnoH47EQIcCwAK Bb0Q= X-Received: by 2002:a1c:4987:: with SMTP id w129mr3258225wma.9.1594888122467; Thu, 16 Jul 2020 01:28:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzifAKG4UNaxHfzBUe4D/P1Pf4/TsqNavmZUE5YjDZ0S7BjsQc0dOdeF+E2D4DHsX3ERZHPuQ== X-Received: by 2002:a1c:4987:: with SMTP id w129mr3258216wma.9.1594888122264; Thu, 16 Jul 2020 01:28:42 -0700 (PDT) Received: from amorenoz.users.ipa.redhat.com ([92.176.159.3]) by smtp.gmail.com with ESMTPSA id a15sm8371772wrh.54.2020.07.16.01.28.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 01:28:41 -0700 (PDT) To: David Marchand , "Xia, Chenbo" Cc: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "Wang, Zhihong" , Thomas Monjalon References: <20200715171828.95887-1-amorenoz@redhat.com> <20200715171828.95887-5-amorenoz@redhat.com> <506d7594-efd0-ed82-2f3a-6306540c7cc1@redhat.com> From: Adrian Moreno Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: Date: Thu, 16 Jul 2020 10:28:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/16/20 10:18 AM, David Marchand wrote: > On Thu, Jul 16, 2020 at 9:53 AM Adrian Moreno wrote: >>>> + if (ret > UINT8_MAX) { >>>> + PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS >>>> response 0x%" PRIx64 "\n", ret); >>> >>> There's a coding style issue here: >>> CHECK:CAMELCASE: Avoid CamelCase: >>> Could you fix this? >> >> I did see this one as well. It also seems new because PRIx64 is widely used in DPDK. >> >> find -iname *.c | xargs grep -i "PRIx64" | wc -l >> 520 >> >> So, ether we have to modify the script to ignore this one or change all 520 >> cases, right? > > This is a false positive. > We won't drop use of this standard macro because checkpatch is not > happy with it. > > I don't see how to silence this warning but I can see that the kernel > uses this macro: so I guess people are simply ignoring this one. > > Thanks David! -- Adrián Moreno