From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F394CA0548; Tue, 20 Apr 2021 16:34:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6B0041800; Tue, 20 Apr 2021 16:34:01 +0200 (CEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id D996A41800; Tue, 20 Apr 2021 16:33:59 +0200 (CEST) Received: by mail-wm1-f43.google.com with SMTP id y204so18904150wmg.2; Tue, 20 Apr 2021 07:33:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=8yolpBxl5j8FZ8wVUGFng2a/HQjuMzm0N+9aPmm5f8k=; b=TtNCfniILsPrcyeJdxzg2ibfvGQhVJjv5CgoYFDHHoAbdF/zs2lATARCfSdBmwjklv s1IdOzeEqDCiLflt2sXzM44h5C0Y9EQ2vTEqORAzXt7QV/dvIaI+PC5WIGPhx5vVtwmw J/+BbShPC0qzg5fbJzsmn0w8O9cGy3rNlpIrsxzMJCePD/WwfdN0HJl0JvveTq5aoDy3 7USy2NRVbMwVncHnisQGU8tWGzVrVZ6GHPDPDGWBQE+dutr8kkMrHR/UNbTJxCv+K/pw w6gSPPC2+xibeM7asdfD2PRpfqmXzHdDYamu5Zq4b4BnkDP6oG9ecaOQ3zzDQOCveC+F dQzQ== X-Gm-Message-State: AOAM5326bxyoxLOUtidSsKEEjhQiRa0TBmPTtSs9J/vLPRQthTnQMvRs reRRnsmgtpOeAV+5tsVJpyo= X-Google-Smtp-Source: ABdhPJy6Si/XDMnIlFw3QqHtj4t800MQJIzGIoXkJHR05xpetw7iMPMXPsDLY5KJPpVsvaZxkPIPYQ== X-Received: by 2002:a05:600c:3796:: with SMTP id o22mr4776201wmr.139.1618929239674; Tue, 20 Apr 2021 07:33:59 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id f23sm3494143wmf.37.2021.04.20.07.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 07:33:59 -0700 (PDT) Message-ID: From: Luca Boccassi To: "Zhang, Qi Z" , "Yigit, Ferruh" , Xiaozhen Ban , "Guo, Jia" , "Wang, Haiyue" Cc: "dev@dpdk.org" , "stable@dpdk.org" Date: Tue, 20 Apr 2021 15:33:58 +0100 In-Reply-To: <1ab204a8870645a986b49abb55814bcb@intel.com> References: <20210319040817.64143-1-benhaz1024@gmail.com> <289fcebe24c8414bb28c949ef87dd349@intel.com> <09dce07d-04a4-cfb8-ab1f-5887a5a5d0d2@intel.com> <1ab204a8870645a986b49abb55814bcb@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2021-04-20 at 09:54 +0000, Zhang, Qi Z wrote: > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Tuesday, April 20, 2021 4:09 PM > > To: Zhang, Qi Z ; Xiaozhen Ban > > ; Guo, Jia ; Wang, Haiyue > > > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix filter con= trol > > return value > >=20 > > On 3/25/2021 8:46 AM, Zhang, Qi Z wrote: > > >=20 > > > > -----Original Message----- > > > > From: dev On Behalf Of Xiaozhen Ban > > > > Sent: Friday, March 19, 2021 12:08 PM > > > > To: Guo, Jia ; Wang, Haiyue > > > > > > > > Cc: dev@dpdk.org; stable@dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control retur= n > > > > value > > > >=20 > > > > > > -----Original Message----- > > > > > > From: Xiaozhen Ban > > > > > > Sent: Thursday, March 18, 2021 19:44 > > > > > > To: Guo, Jia ; Wang, Haiyue > > > > > intel.com> > > > > > > Cc: dev at dpdk.org; stable at dpdk.org > > > > > > Subject: RE: RE: [PATCH] net/e1000: fix filter control return v= alue > > > > > >=20 > > > > > > OK, but I think this bug affects all stable release about 6 yea= rs before > > today. > > > > > I don't think so, since it is PMD internal ops, the real API > > 'rte_flow_ops_get' > > > > > always use RTE_ETH_FILTER_GENERIC. ;-) > > > >=20 > > > > eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if > > > > application developer know how to use the parameter filter_type cor= rectly, > > it's OK. > > > > otherwise he will get rte_eth_dev_filter_ctrl() return value is > > > > success but actually is failed. > > >=20 > > > After check with Haiyue, we think the patch is still needed for LTS <= =3D > > > 19.11, so > > >=20 > > > Acked-by: Qi Zhang > > >=20 > > > Applied to dpdk-next-net-intel. > > >=20 > >=20 > > What is the status of this patch? > > It seems it did not applied, and the status in the patchwork is "Supers= eded". >=20 > The patch is dropped during rebase, as the function eth_igb_filter_ctrl i= s removed at below code refectory=20 > http://patchwork.dpdk.org/project/dpdk/patch/20210321090002.595744-2-thom= as@monjalon.net/ >=20 > this is a mistake as we still need this to be captured in LTS > unfortunately, its too late to capture it as the refectory code is alread= y applied to main tree. >=20 > @Luca Boccassi > Could you capture this patch as an LTS only one? >=20 > Thanks > Qi Please rebase it on 20.11 and test it, and if it works send it to=20 stable@dpdk.org with --subject-prefix=3D'PATCH 20.11' --=20 Kind regards, Luca Boccassi