From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id C005A1B9BD
 for <dev@dpdk.org>; Sun, 16 Dec 2018 10:21:05 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 1584EC02835C;
 Sun, 16 Dec 2018 09:21:05 +0000 (UTC)
Received: from [10.36.112.14] (unknown [10.36.112.14])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B09A18667;
 Sun, 16 Dec 2018 09:21:02 +0000 (UTC)
To: Xiao Wang <xiao.w.wang@intel.com>, tiwei.bie@intel.com
Cc: alejandro.lucero@netronome.com, dev@dpdk.org, zhihong.wang@intel.com,
 xiaolong.ye@intel.com
References: <20181213100910.13087-2-xiao.w.wang@intel.com>
 <20181214211612.167681-1-xiao.w.wang@intel.com>
 <20181214211612.167681-8-xiao.w.wang@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <bd68f5c6-342e-841f-1351-4c79e6ef50d4@redhat.com>
Date: Sun, 16 Dec 2018 10:21:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181214211612.167681-8-xiao.w.wang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.31]); Sun, 16 Dec 2018 09:21:05 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v4 07/10] net/ifc: add devarg for LM mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Dec 2018 09:21:06 -0000



On 12/14/18 10:16 PM, Xiao Wang wrote:
> This patch series enables a new method for live migration, i.e. software
> assisted live migration. This patch provides a device argument for user
> to choose the methold.
> 
> When "swlm=1", driver/device will do live migration with a relay thread
> dealing with dirty page logging. Without this parameter, device will do
> dirty page logging and there's no relay thread consuming CPU resource.
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>   drivers/net/ifc/ifcvf_vdpa.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
> index c0e50354a..395c5112f 100644
> --- a/drivers/net/ifc/ifcvf_vdpa.c
> +++ b/drivers/net/ifc/ifcvf_vdpa.c
> @@ -8,6 +8,7 @@
>   #include <sys/ioctl.h>
>   #include <sys/epoll.h>
>   #include <linux/virtio_net.h>
> +#include <stdbool.h>
>   
>   #include <rte_malloc.h>
>   #include <rte_memory.h>
> @@ -31,9 +32,11 @@
>   #endif
>   
>   #define IFCVF_VDPA_MODE		"vdpa"
> +#define IFCVF_SW_FALLBACK_LM	"swlm"


The patch looks good, except that I don't like the "swlm" name.
Maybe we could have something less obscure, even if a little bt longer?

What about "sw-live-migration"?