From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680072.outbound.protection.outlook.com [40.107.68.72]) by dpdk.org (Postfix) with ESMTP id 875B01B056 for ; Mon, 17 Sep 2018 16:16:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lag0ZDWVtxqKnLwI/qA/CXfmt570/C1MVXvFp0mr9Jk=; b=okS1BMy5kWLn6T57N1snNotxjGfTMTOeO5XXJjI8WQcGS1+QvRjdhGISiM4xYsWrQW56aYPYZG4i50OsNvZvgPWJBVJAgJAhJyyKVbvUhaFedWYxUdwJRlGJByy37Qc3b9In+TxJkxwnclQX4/+XgLoIj81/3299mAYxAUTW/0U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [192.168.1.9] (223.230.22.245) by SN6PR07MB4910.namprd07.prod.outlook.com (2603:10b6:805:39::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Mon, 17 Sep 2018 14:16:21 +0000 To: Akhil Goyal , Anoob Joseph , Pablo de Lara , Thomas Monjalon Cc: Murthy NSSR , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Ankur Dwivedi , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1536033560-21541-11-git-send-email-ajoseph@caviumnetworks.com> <2c63fcce-8969-45b7-832b-85a00c6caf74@nxp.com> From: "Joseph, Anoob" Message-ID: Date: Mon, 17 Sep 2018 19:47:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2c63fcce-8969-45b7-832b-85a00c6caf74@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [223.230.22.245] X-ClientProxiedBy: MA1PR01CA0105.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:1::21) To SN6PR07MB4910.namprd07.prod.outlook.com (2603:10b6:805:39::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1bf82ed-bc2e-4d4e-903c-08d61ca82738 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4910; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4910; 3:8Ily4fLqmozVexu7+b/628/NhHRv6qKYQ6c908XwZ4lIJjCB+snaxP4smusSW7Qo6cynk2pzF0fsNNO6ZNMnu0Sh5uPWo6bfIzp4+8BEL7UoZFxV7PSSC6KsR78jeNpfCsKhIdjvt8y8/4RM1Rfz/ejjwf/yqsH3nVWS9CU+hYl/ZGSaFSFnohu1C7UxzcmPy40D+cvD1QhkkUQ5aj/VZhYLzWzYpXHwFwyRQ9RnXG2ogS4iTjVGZZl70Gx2tdaJ; 25:D5MpN/MHsoSmlmChml5rtkNOwHqQYgaflsKbZGxF32Nzxo5eE3/JZvTipbkm705jhWF2TnikiWFeg5wTQ8UOoUdMXQS7QCBGyNySuCQUlv2LZh/Pzu37JyZwnqoNLFeolgEqqkc1sm67oUGgKxafdj8FzqctZGwslHt7rue0F2CFZ+uwTKOr71680cT/1CQ2LgLHujBtsRVORpA2oESXEi4566/WOzBr0VHHYgn3lJOzjdlS2Y2dB8ANyYo8Gtzp27BtHiRHKeUNmSE25LHC8slh40RHWzKHefFIl/k71/z6Jmq5AOApAcxOhETo1aQYnXMDfHpIWc3UXhwWspPiRA==; 31:7ZJL8hzbfE9kEyacc38Ux96bVA6h1jhhKkKJwoEk5mrKcsenKoNrN91D+29UBZbJqrRcMqcBg4Kx5GXiBGvMioenDlK6bmTSCYrSoNg6i5iAn95oCkDrfXrT5224NBBX82WR0dwHlXv78xREqdXW1bJ3ZYtlvLAyA+pS25atoGVQuDtWHBqvYaQzX0PgPdQp1f2pD4k/W2bybBLQpdCefiGkB1i7ENC65wseUPZ0pvg= X-MS-TrafficTypeDiagnostic: SN6PR07MB4910: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4910; 20:cCrBm6QgBNNcPddD6I0VZ9Wkgl2gfRfOT8zyoe0XbGdp9Gw8UAs9LgWzIX0bAHcDf1UcaCTLNz/qiDe91e2Vz2DPIT6hx+ObNoSNMVHt8n73o9Pw49TjVeJ7X0dRhnd7sZ3SCtYZNkZu1zoYRA5JfItuFfhKCTM7o0Q1uboGoH9lIazuz+mM0vFVoZGON4oSyv/y4lDE2yVRfkhCkh4gTbAp0qYnyfoN0krGQbNwn3s885e3R85jr6AX9Yv2WeRqFj0MKx5D5eTPb1ujgfnd8ZgTJn78jUf4nvEtRk3y4dldtIQzXh6H/Wqljs7oc7cwIPh/EahxPOOIRbPuXUjqtR9dm58YvZAuUA51jszIRxEDfZMSVUuh8YJWfPryP2E0jCli+Y3l5LgXFEo59twyiLSrJfsgnGrlNfzA6m2Ms538f+Ghznq3rs4/uq20jDmJuvTc1Ip1fqE3AA4vpeOXP2kNJtVmT8LYDKrjhiVH4FgTjiql5b1Bark9nDlc+IdRFhrK+yNcIDr4o0XVqoLWSfr7OD5GUDAMtSdlVtzdvV/7Az7lv8XnulSNMOeSMkmhclDxVcdAPd4G7yRVrT03uMkfjBVsuACx0jx+WequuG4=; 4:uRR5YmmHgFoVgGRbBzVOoenwqUeklNQqn0jzbPAoXppbKGGTikStvOBytt2+UuJlnDrsL6mmrkClT2AQFRDxTzThxVdH4zHq/oS8JHbxljmSttFL3vqfaP54HrZMWfKqJQBiz+XPrz+hA5b4CaQLR7rbiKoZwtfT714X5a0GUbPhRvOh62iJ0NoJ7T7HBTPGmjCBvrE1DltDH637VUC6H4RgafbmO5m8AiMQnU0KVnJXaCPJCpmbuoi/j8i9UUxewiiEKU2se3oKp552MK2aGw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231355)(944501410)(52105095)(93006095)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:SN6PR07MB4910; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4910; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(376002)(366004)(346002)(39860400002)(396003)(136003)(189003)(199004)(81156014)(446003)(2616005)(8676002)(105586002)(42882007)(36756003)(316002)(81166006)(6116002)(956004)(58126008)(3846002)(476003)(68736007)(65826007)(486006)(8936002)(54906003)(6666003)(16576012)(11346002)(97736004)(93886005)(5660300001)(110136005)(106356001)(31686004)(107886003)(67846002)(6246003)(14444005)(25786009)(53936002)(16526019)(65806001)(66066001)(65956001)(72206003)(478600001)(53546011)(6486002)(2870700001)(305945005)(386003)(64126003)(229853002)(7736002)(50466002)(2486003)(23676004)(76176011)(52116002)(4326008)(31696002)(47776003)(77096007)(2906002)(117156002)(3260700006)(26005)(52146003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4910; H:[192.168.1.9]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjA3TUI0OTEwOzIzOithWVpyZ3pjZmV6ZExtb0xnUFNRTEFiTjAv?= =?utf-8?B?dG5pdW1LcXpST2ZJOERkWmlRdlZVYXVZcmpCUW5rSzVBWGViYlpJR3YvQUZl?= =?utf-8?B?U0JlWWhVRFIxQ2M0Zkd1c1VDQ0h3cEtrVmdya2dMbytsZmZON1dpcllmenJu?= =?utf-8?B?cXdTQ0tWQ2dOaXpNYURHKzB4T2x0Wk9BUy96Z1ZZek9FWHJUUUl5RXdLSXFQ?= =?utf-8?B?Y2lLZDE5SE9QUFU2VlBETTR0UTBIWnA0aTVNd1llS1FFMko0eGYzVVR2Z2tS?= =?utf-8?B?QnlJN3lLeURuWXVQaXpiak8wVVUyQi9SQ0x0RXEyYThtRzc3clQ4T3B2U0hh?= =?utf-8?B?SzJOcFBYUU8yejJMTGRFRFc2SkUreDR3QlNvaVR0aGplUlBybHFwc0g4Z0RP?= =?utf-8?B?SXNWeWxLRUhBdm82alIzWFAxK2J3TVlrb0s3cXQ0dU53ZzJpVExSQ3hnY3I0?= =?utf-8?B?bUZwZzBGendQRFRXVVZQQ1lhcllLaUdiYjdDNlF4aHdhdmMydGI0c0pTOE1h?= =?utf-8?B?WW1mRi9mSktwVVVsMjdhTXdRUE00MGUrRGRRMC92KzNvem1idXFyQnFCYWVW?= =?utf-8?B?Rjd2ZDY0ckZPbmtTK0NsRkp5Y2hoaGVtcU5EaS9UTkZBTGdPSG1TcHhLS0Jt?= =?utf-8?B?b2xGRFY2dk5QTkFlUVZuMDNBQ013N3BtTHpGU0V4NERpWXNhRkMxR0kwanRr?= =?utf-8?B?ZHJTK2FYVXY4UXRoc0VKaHRVTUYzeERodWdoa1BIT0k3TE50d0UwMnJkTlRH?= =?utf-8?B?dzBuT1MvaitTYkZrR2d2am5HV3VKNU1WQk1EYXp3S2R4VkdXdHN3MERNWDQ3?= =?utf-8?B?N21yQVJ4Q0hDejFYME85a3JuVVJxa2R4bDM2cktxZ1Z3N3RUaDI0bTNta05L?= =?utf-8?B?U1VqNVZUMHE2RjhmN3UrMzEya3JhN0FWUWRydGs0VlNsNnZiZWo0SWFJTnZM?= =?utf-8?B?SXRMdnNQbGN1TG1ONnpWNzhLWFY3bFlRNE5NL25GYWhndFJ6ajV2NTlBT3Js?= =?utf-8?B?VlJGUW51SnpDeWJxZkxmY1lrRkN0Y2x4cnFKMFJMUmxRTm1ZSW9rMlJrNHJk?= =?utf-8?B?Zzd1NEl4US85NUNYSTJ2bjhVbGlVa0xoMnZwcUd1SFpocUwyOWNuYW9kRlB6?= =?utf-8?B?WXR4cyttUW5Mc3RxNkpDcm4zTGdpTnN0S0NjTVEzc2kxdXB2WXk3QXRycVVK?= =?utf-8?B?UWdNaXBLRDFKZUowRG9KSzlIcVJaN1BscnNZK2huMU93QmhPelQ4OTBCNTFz?= =?utf-8?B?cUtpU0cvU2lZaWhmMWxaemhzQTRJRHNKNDdZZG4vanduWlE2VmFWeVRQemNq?= =?utf-8?B?N1krZEhlYjFkeTZHNlFrZW9ueDlrRU1yZmZ5cm5GMEMxMFFJQmNoa1RnVmQ0?= =?utf-8?B?bUplNzNmRTg3Q2I5YXBYVUJ3Kys2bExYVlhCK0FiQk5rMXNucjVaUWRlS0hq?= =?utf-8?B?eUtHTEkvUHRHbm1yV2dYclJqK3VDdjhjdVFINFM1UFdaR1FMMFdVSDZoeHEr?= =?utf-8?B?aG1TNXk4Y2lGb0pwRVNIeEpmc0ZtVzQrVG5PQndCMEQ0WklwZEJVQjZSVVA3?= =?utf-8?B?NWljMHRveDFQWjN4WEt0dkd0SWc2M0ZxN082YkxCTUZiNkxSQmJycS96Tjh5?= =?utf-8?B?Tm9ua3VRK3Jnb1RmRFdRWnI0bnhuVnk1OGtlbzh0amdtL1IvaDZoeTdzaytE?= =?utf-8?B?MHNnZ283b2dCSm93eFoyNUduQ1NVa0ZHRVJZbW5mK2N1dDVseGdrOVU1SjJy?= =?utf-8?B?ZmJTVEVJU1RkQ1FqaVRaYkNvQUNTZERzNEtVcjFtZitVdFBIMGErRkc5NVpT?= =?utf-8?B?MXgzWHczaC9PUkp2Ulk0S0RaRmJCZ0U0dUprVTdJZnJLVnJxQUxvZndvY3M1?= =?utf-8?B?V1dldTdTSGp1MW5zeS93cDQwLzlzdjA1eG54cHNmNW5BcE1pWDR3RUhwMkt2?= =?utf-8?B?NmJ0YjhtS1NCMHllQ0lMY040VGRpZi9IaHBuS3hzWVNiS1BGUFJ5WEd3cENB?= =?utf-8?B?MWtuVSttaVEzRURBUGFvVTJ4Z0wvdVVmb0I2VkQ5QlA3dnpCQTZMTzgrVEha?= =?utf-8?B?MVVNL3lmQTBxSFJ2SVZEZkZVYmpWOXIvREh5MzJEVytuTEk0SUlPUFA2SDF2?= =?utf-8?Q?xdWXtVTusGSa2bZ4RG5tUoc=3D?= X-Microsoft-Antispam-Message-Info: HYmUAruMFMWdd7V7vq3WolooAfsBrzBn9tiYb4bB9Rq9CanHQoYWwCApmGfvE1yMdn6q8E7Y3wUbMfj+PfEoGZjiaAC+NRxY1kpgqilxFHXDWzdQ93g9rRBs+aI3pjIuq+jKn+rUvfQ8EKvqdfhdyOrG7t4s8xWIPWEkr6yEbkr5roVOJU+etbj9+FLDxF1iqHIdkRPPWFMeyJHE8VG46+4v7qeo3IyLkI75lxhgARwXBz23wHAHN3/KLPFFx/GySBU/ZtzMORNWI7k0/397vAXFow6aQHoRfKBTkxL0NtPWHApvBFsQGV2QZQESG7qKQBDThgNu9x8bEOcSKNILcrNEKshRfAjsxJLa3RtWxEs= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4910; 6:mp05fHQ3gXulPn4UQSk212jbku/vezU7tnHo2PGmc/hTyvFX51jp3QgQUu/ol890BY1kz/5e36j0Fn6IDuVSV712kC/Ya9zY2wHjTTcaLSz13XEQH7LwP5WhoqwoWqZjGSWf+iBMrSvX+CaSABEM15bkzrmEmK0XE8mZ7N5Sd5ZQRvU5LvSOsJDdUYRbD7cafZ9mbuUA3D03inE/tBjVpILNP/1AtWLjNCgMbOYvVq925j31VqCyoUvPyVv8iOL2vs1YgMDdQsx0Ilkf5p6+dL8rEO2jC5qDUhigGgI+4cHrl//6NKiFWVbxe1If2BMYvy3QDL685xFjBwLigwirIgzN+quNPd4AHFyBiD2JkMUsHten6uVcfjHv79MxvnvZPjoBMMi9GkXplhaEcHkn92VSTBKkIkqvXi+30/UUJggiXfBUlAt6TDnMcnG8BQ2b7A0xBi4cMSdhLGCOTYSQ4w==; 5:bquZhlWChTUglh9vuaxdaCTbxJyiwJUMfacqlvHEJLgOxMh3/yFDAtZRFdOLe8He62ng+DBIIFpZ+MSAYVMmx7J8M3UF1Cz61aYX9uIufRbUMCEOiIK6H72aCISfHGvJAxKsLEOizTEzK7wjdWwBHbY/xQoHDNhvAqCvdnBOaUg=; 7:TqSpfsXZIaB3RlmCraQi8Wi10+Da0ho1G5djXefhEJ+Pzcaq3XT7DymlPcxrwgnqndIsYcfF1J0KBvNi/S+V4L6W//7zVJv7uhjLlTgf0PzZD9q33Mm2vI4OXjJ6PPxp3lsshV4+FFNEE7SpEgRLno5TAh/j6L9Q0arTt8I7EcOOu/5HEqGXSQewju1aQuCsh5sNwmXB5s8Kng9Qrlia5n8S5m8NMaIBfbRrZzaSPk6qOKsxh2fiHDWyKAXf91Jw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 14:16:21.7918 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1bf82ed-bc2e-4d4e-903c-08d61ca82738 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4910 Subject: Re: [dpdk-dev] [PATCH v2 10/33] common/cpt: add PMD ops helper functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 14:16:28 -0000 HI Akhil, On 17-09-2018 18:17, Akhil Goyal wrote: > External Email > > On 9/4/2018 9:28 AM, Anoob Joseph wrote: >> From: Murthy NSSR >> >> Adding pmd ops helper functions. Control path accessed APIs would be >> added as helper functions. Adding microcode defined macros etc as >> dependencies to the helper functions. >> >> Signed-off-by: Ankur Dwivedi >> Signed-off-by: Anoob Joseph >> Signed-off-by: Murthy NSSR >> Signed-off-by: Nithin Dabilpuram >> Signed-off-by: Ragothaman Jayaraman >> Signed-off-by: Srisivasubramanian S >> Signed-off-by: Tejasree Kondoj >> --- >>   drivers/common/Makefile                       |  4 +++ >>   drivers/common/cpt/Makefile                   | 25 ++++++++++++++++ >>   drivers/common/cpt/cpt_common.h               | 41 >> +++++++++++++++++++++++++++ >>   drivers/common/cpt/cpt_mcode_defines.h        | 38 >> +++++++++++++++++++++++++ >>   drivers/common/cpt/cpt_pmd_ops_helper.c       | 41 >> +++++++++++++++++++++++++++ >>   drivers/common/cpt/cpt_pmd_ops_helper.h       | 34 >> ++++++++++++++++++++++ >>   drivers/common/cpt/meson.build                |  8 ++++++ >>   drivers/common/cpt/rte_common_cpt_version.map |  6 ++++ >>   drivers/common/meson.build                    |  2 +- >>   mk/rte.app.mk                                 |  4 +++ >>   10 files changed, 202 insertions(+), 1 deletion(-) >>   create mode 100644 drivers/common/cpt/Makefile >>   create mode 100644 drivers/common/cpt/cpt_mcode_defines.h >>   create mode 100644 drivers/common/cpt/cpt_pmd_ops_helper.c >>   create mode 100644 drivers/common/cpt/cpt_pmd_ops_helper.h >>   create mode 100644 drivers/common/cpt/meson.build >>   create mode 100644 drivers/common/cpt/rte_common_cpt_version.map >> >> diff --git a/drivers/common/Makefile b/drivers/common/Makefile >> index 0fd2237..ca4e854 100644 >> --- a/drivers/common/Makefile >> +++ b/drivers/common/Makefile >> @@ -8,4 +8,8 @@ ifeq >> ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOO >>   DIRS-y += octeontx >>   endif >> >> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO),y) >> +DIRS-y += cpt >> +endif >> + >>   include $(RTE_SDK)/mk/rte.subdir.mk >> diff --git a/drivers/common/cpt/Makefile b/drivers/common/cpt/Makefile >> new file mode 100644 >> index 0000000..2340aa9 >> --- /dev/null >> +++ b/drivers/common/cpt/Makefile >> @@ -0,0 +1,25 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright(c) 2018 Cavium, Inc >> +# >> + >> +include $(RTE_SDK)/mk/rte.vars.mk >> + >> +# >> +# library name >> +# >> +LIB = librte_common_cpt.a >> + >> +CFLAGS += $(WERROR_FLAGS) >> +CFLAGS += -I$(RTE_SDK)/drivers/bus/pci >> +EXPORT_MAP := rte_common_cpt_version.map >> + >> +LIBABIVER := 1 >> + >> +# >> +# all source are stored in SRCS-y >> +# >> +SRCS-y += cpt_pmd_ops_helper.c >> + >> +LDLIBS += -lrte_eal >> + >> +include $(RTE_SDK)/mk/rte.lib.mk >> diff --git a/drivers/common/cpt/cpt_common.h >> b/drivers/common/cpt/cpt_common.h >> index feca5fe..1f78d42 100644 >> --- a/drivers/common/cpt/cpt_common.h >> +++ b/drivers/common/cpt/cpt_common.h >> @@ -18,6 +18,24 @@ >>   #define AE_TYPE 1 >>   #define SE_TYPE 2 >> >> +#ifndef ROUNDUP4 >> +#define ROUNDUP4(val)        (((val) + 3) & 0xfffffffc) >> +#endif >> + >> +#ifndef ROUNDUP8 >> +#define ROUNDUP8(val)        (((val) + 7) & 0xfffffff8) >> +#endif >> + >> +#ifndef ROUNDUP16 >> +#define ROUNDUP16(val)       (((val) + 15) & 0xfffffff0) >> +#endif >> + >> +#ifndef __hot >> +#define __hot __attribute__((hot)) >> +#endif >> + >> +#define MOD_INC(i, l)   ((i) == (l - 1) ? (i) = 0 : (i)++) >> + >>   /* cpt instance */ >>   struct cpt_instance { >>       uint32_t queue_id; >> @@ -51,4 +69,27 @@ struct pending_queue { >>               /**< Pending requests count */ >>   }; >> >> +struct cpt_request_info { >> +     /* fast path fields */ >> +     uint64_t dma_mode       : 2; >> +             /**< DMA mode */ >> +     uint64_t se_req         : 1; >> +             /**< To SE core */ >> +     uint64_t comp_baddr     : 61; >> +     volatile uint64_t *completion_addr; >> +     volatile uint64_t *alternate_caddr; >> +     void *op; >> +             /**< Reference to operation */ > better to have comments in the same line wherever possible and if not, > please check indentation. > Please check other patches as well. > Will fix this in v3. I'll try to make all comments on the line before the thing. Anoob