From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 50FAB2BDE
 for <dev@dpdk.org>; Thu,  4 Aug 2016 14:50:38 +0200 (CEST)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 89FEDC00F0A5;
 Thu,  4 Aug 2016 12:50:37 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-4-59.ams2.redhat.com
 [10.36.4.59])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u74CoZUN018639; Thu, 4 Aug 2016 08:50:36 -0400
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
References: <1469795316-31740-1-git-send-email-david.marchand@6wind.com>
Cc: thomas.monjalon@6wind.com, anatoly.burakov@intel.com
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <bd9390b2-954c-99e2-ec31-ee4909c47fb0@redhat.com>
Date: Thu, 4 Aug 2016 15:50:35 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <1469795316-31740-1-git-send-email-david.marchand@6wind.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.31]); Thu, 04 Aug 2016 12:50:37 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] ivshmem: remove integration in dpdk
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Aug 2016 12:50:38 -0000

On 07/29/2016 03:28 PM, David Marchand wrote:
> Following discussions on the mailing list [1] and since nobody stood up to
> implement the necessary cleanups, here is the ivshmem integration removal.
>
> There is not much to say about this patch, a lot of code is being removed.
> The default configuration file for packet_ordering example is replaced with
> the "native" x86 file.
> The only tricky part is in eal_memory with the memseg index stuff.
>
> More cleanups can be done after this but will come in subsequent patchsets.
>
> [1]: http://dpdk.org/ml/archives/dev/2016-June/040844.html
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  MAINTAINERS                                  |   8 -
>  app/test/Makefile                            |   1 -
>  app/test/autotest_data.py                    |   6 -
>  app/test/test.c                              |   3 -
>  app/test/test.h                              |   1 -
>  app/test/test_ivshmem.c                      | 433 ------------
>  config/defconfig_arm64-armv8a-linuxapp-gcc   |   1 -
>  config/defconfig_x86_64-ivshmem-linuxapp-gcc |  49 --
>  config/defconfig_x86_64-ivshmem-linuxapp-icc |  49 --
>  doc/api/doxy-api-index.md                    |   1 -
>  doc/api/doxy-api.conf                        |   1 -
>  doc/api/examples.dox                         |   2 -
>  doc/guides/linux_gsg/build_dpdk.rst          |   2 +-
>  doc/guides/linux_gsg/quick_start.rst         |  14 +-
>  doc/guides/prog_guide/img/ivshmem.png        | Bin 44920 -> 0 bytes
>  doc/guides/prog_guide/index.rst              |   1 -
>  doc/guides/prog_guide/ivshmem_lib.rst        | 160 -----
>  doc/guides/prog_guide/source_org.rst         |   1 -
>  doc/guides/rel_notes/deprecation.rst         |   3 -
>  doc/guides/rel_notes/release_16_11.rst       |   3 +
>  examples/Makefile                            |   1 -
>  examples/l2fwd-ivshmem/Makefile              |  43 --
>  examples/l2fwd-ivshmem/guest/Makefile        |  50 --
>  examples/l2fwd-ivshmem/guest/guest.c         | 452 -------------
>  examples/l2fwd-ivshmem/host/Makefile         |  50 --
>  examples/l2fwd-ivshmem/host/host.c           | 895 -------------------------
>  examples/l2fwd-ivshmem/include/common.h      | 111 ----
>  examples/packet_ordering/Makefile            |   2 +-
>  lib/Makefile                                 |   1 -
>  lib/librte_eal/common/eal_common_memzone.c   |  12 -
>  lib/librte_eal/common/eal_private.h          |  22 -
>  lib/librte_eal/common/include/rte_memory.h   |   3 -
>  lib/librte_eal/common/include/rte_memzone.h  |   7 +-
>  lib/librte_eal/common/malloc_heap.c          |   8 -
>  lib/librte_eal/linuxapp/eal/Makefile         |   9 -
>  lib/librte_eal/linuxapp/eal/eal.c            |  10 -
>  lib/librte_eal/linuxapp/eal/eal_ivshmem.c    | 954 ---------------------------
>  lib/librte_eal/linuxapp/eal/eal_memory.c     |  30 +-
>  lib/librte_ivshmem/Makefile                  |  54 --
>  lib/librte_ivshmem/rte_ivshmem.c             | 919 --------------------------
>  lib/librte_ivshmem/rte_ivshmem.h             | 165 -----
>  lib/librte_ivshmem/rte_ivshmem_version.map   |  12 -
>  mk/rte.app.mk                                |   1 -
>  43 files changed, 13 insertions(+), 4537 deletions(-)
>  delete mode 100644 app/test/test_ivshmem.c
>  delete mode 100644 config/defconfig_x86_64-ivshmem-linuxapp-gcc
>  delete mode 100644 config/defconfig_x86_64-ivshmem-linuxapp-icc
>  delete mode 100644 doc/guides/prog_guide/img/ivshmem.png
>  delete mode 100644 doc/guides/prog_guide/ivshmem_lib.rst
>  delete mode 100644 examples/l2fwd-ivshmem/Makefile
>  delete mode 100644 examples/l2fwd-ivshmem/guest/Makefile
>  delete mode 100644 examples/l2fwd-ivshmem/guest/guest.c
>  delete mode 100644 examples/l2fwd-ivshmem/host/Makefile
>  delete mode 100644 examples/l2fwd-ivshmem/host/host.c
>  delete mode 100644 examples/l2fwd-ivshmem/include/common.h
>  delete mode 100644 lib/librte_eal/linuxapp/eal/eal_ivshmem.c
>  delete mode 100644 lib/librte_ivshmem/Makefile
>  delete mode 100644 lib/librte_ivshmem/rte_ivshmem.c
>  delete mode 100644 lib/librte_ivshmem/rte_ivshmem.h
>  delete mode 100644 lib/librte_ivshmem/rte_ivshmem_version.map
>
[...]

Ooh, what a nice "welcome back from vacation" message in my inbox :)
FWIW,

Acked-by: Panu Matilainen <pmatilai@redhat.com>

	- Panu -