From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2F73A034F; Wed, 6 May 2020 12:50:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68F001D91D; Wed, 6 May 2020 12:50:25 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id A96321D91A for ; Wed, 6 May 2020 12:50:23 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200506105022euoutp02bda80800bfbf4b3c2f0f3e5db61d599a~MatLyv5wb1306913069euoutp02W for ; Wed, 6 May 2020 10:50:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200506105022euoutp02bda80800bfbf4b3c2f0f3e5db61d599a~MatLyv5wb1306913069euoutp02W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1588762222; bh=xBiHyUZXcItF9abDal/qtuUSyk51pUX9cmAmJnnVP0I=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=hw519tZOl89nss1s493r4QbYQEYXw8yyiAJziP/CZ6a5egCl7YXGOGxWiQRniFeJg LFp4KDrdnZakvmMxlRaxFlUtCbOAUDNJMqt7+bxZRKqM+/z+VVHx1gsSoclwvE/gP5 LQVizVJvBHPJPL9Nov/HvHoH3taIJ3qXpaWnU4r0= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200506105022eucas1p19d8ef0ff5254c34a21764626f1e73930~MatLoarXZ2231722317eucas1p1K; Wed, 6 May 2020 10:50:22 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 19.C8.61286.E6692BE5; Wed, 6 May 2020 11:50:22 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200506105021eucas1p11fea176a1db1e52eee17c9ea64f698e2~MatLBJ5-82181921819eucas1p1P; Wed, 6 May 2020 10:50:21 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200506105021eusmtrp2d1261c4cf3dc701ea9feb04d757e652c~MatLAmZkW1834318343eusmtrp2W; Wed, 6 May 2020 10:50:21 +0000 (GMT) X-AuditID: cbfec7f2-f0bff7000001ef66-db-5eb2966e4571 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F0.36.08375.D6692BE5; Wed, 6 May 2020 11:50:21 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200506105021eusmtip1fdee9aba3a0cf74bb25fb722517761fe~MatKJw4-c2869628696eusmtip1P; Wed, 6 May 2020 10:50:20 +0000 (GMT) To: Praveen Shetty , dev@dpdk.org, declan.doherty@intel.com, akhil.goyal@nxp.com, anoobj@marvell.com Cc: bernard.iremonger@intel.com, konstantin.ananyev@intel.com From: Lukasz Wojciechowski Message-ID: Date: Wed, 6 May 2020 12:50:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200506103752.20478-1-praveen.shetty@intel.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsWy7djPc7p50zbFGdyarGix/sw8RotlW7Yy WWxuFLZ486CJxeLdp+1MFu//LGKxaNpxm82B3ePXgqWsHov3vGTymLzwIrPHxnc7mAJYorhs UlJzMstSi/TtErgylj9cyV5wmbfiztNZjA2ME7m7GDk5JARMJKYfes4EYgsJrGCUmP6At4uR C8j+wigxcVUTO4TzmVFi/pNTzDAdk3bNgEosZ5Q4vXYTlPOWUWLT0XuMIFXCAhESDV+mgCVE BBoYJVp/vmQDSTAL2EqcnTefBcRmA7KPzPzKCmLzCrhJdN37CdbMIqAisam3Acjm4BAViJWY fi0EokRQ4uTMJ2CtnAJ2Eqt/dTJDjJSXaN46G8oWl7j1ZD4TyF4JgXXsEhN+n2aBONtF4nL3 QzYIW1ji1fEt7BC2jMT/nTAN2xglrv4GOQLE2c8ocb13BVSVtcThf7/ZQC5iFtCUWL9LHyLs KPHm1GywsIQAn8SNt4IQR/BJTNo2nRkizCvR0SYEUa0n8bRnKiPM2j9rn7BMYFSaheS1WUje mYXknVkIexcwsqxiFE8tLc5NTy02zEst1ytOzC0uzUvXS87P3cQITD2n/x3/tIPx66WkQ4wC HIxKPLwG7hvjhFgTy4orcw8xSnAwK4nw8vwACvGmJFZWpRblxxeV5qQWH2KU5mBREuc1XvQy VkggPbEkNTs1tSC1CCbLxMEp1cAYEc6pJqxZZLmhNv6V5MeVnnfPXghzYqqfJSk6+ejLCZ6H tyyetyJH6NlNSbbGqoehCy2f3Q373710/qFnkif0Ay5fu/zwxr7cSRtdWeccaNybzr329S6j A8of37oeu2epMEUn36JVfIWl8Vb7q/tqmd/P5JPLF8iI9FyeZ/W19tPHAI0J0mmZSizFGYmG WsxFxYkAwc0drzkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t/xu7q50zbFGaxpNbNYf2Yeo8WyLVuZ LDY3Clu8edDEYvHu03Ymi/d/FrFYNO24zebA7vFrwVJWj8V7XjJ5TF54kdlj47sdTAEsUXo2 RfmlJakKGfnFJbZK0YYWRnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZyx+uZC+4 zFtx5+ksxgbGidxdjJwcEgImEpN2zWDvYuTiEBJYyihx5fF75i5GDqCEjMSHSwIQNcISf651 sYHYQgKvGSVaF+WA2MICERInVswG6xURaGCUeHl8AlgRs4CtxNl581kghh5llHg0cyoTSIIN KHFk5ldWEJtXwE2i695PRhCbRUBFYlNvAyPIYlGBWImWi5oQJYISJ2c+YQGxOQXsJFb/6mSG mG8mMW/zQyhbXqJ562woW1zi1pP5TBMYhWYhaZ+FpGUWkpZZSFoWMLKsYhRJLS3OTc8tNtQr TswtLs1L10vOz93ECIy0bcd+bt7BeGlj8CFGAQ5GJR5eQ/eNcUKsiWXFlbmHGCU4mJVEeHl+ AIV4UxIrq1KL8uOLSnNSiw8xmgL9NpFZSjQ5H5gE8kriDU0NzS0sDc2NzY3NLJTEeTsEDsYI CaQnlqRmp6YWpBbB9DFxcEo1MDowLHy1SnCZ2scft1kE0j9cnSZVou5+V5SDS+BN25Tukyum rT0z+9mWg6cvqGz0+l62NTA0jYO1M2TrlShGzfU5Z056fb+wpEwmyrJyo8jpXQVT/7s0r/3+ i5lVb/1rrwU7SwQXSlSJqRw7wXn+RMthiX8XnLPOZ9rWhV88adDF8509Zb9I2WQlluKMREMt 5qLiRABfbi3hygIAAA== X-CMS-MailID: 20200506105021eucas1p11fea176a1db1e52eee17c9ea64f698e2 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200506103808eucas1p2656f3090d0d6086c9de8586c33668f80 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200506103808eucas1p2656f3090d0d6086c9de8586c33668f80 References: <20200506090240.19214-1-praveen.shetty@intel.com> <20200506103752.20478-1-praveen.shetty@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix negative argument passing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 06.05.2020 o 12:37, Praveen Shetty pisze: > Function create_ipsec_esp_flow returns a negative number in case of any > failure and we are passing this to strerror to dsiplay the error message. typo dsiplay -> display > But strerror()'s argument cannot be negative. > In case of failure, displaying exact error message to console is handled > in create_ipsec_esp_flow function.So it is not required to print the > error message again using strerror. > This patch will remove the unnecessary calling of strerror function > to fix the negative argument passing to strerror issue. > > Coverity issue: 357691 > Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director") > Cc: praveen.shetty@intel.com > > Signed-off-by: Praveen Shetty > Acked-by: Lukasz Wojciechowski > --- > v2 changes: > changed commit headline and rephrased commit message. > > examples/ipsec-secgw/sa.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > index e3a1a5aff..632482176 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[], > rc = create_ipsec_esp_flow(sa); > if (rc != 0) > RTE_LOG(ERR, IPSEC_ESP, > - "create_ipsec_esp_flow() failed %s\n", > - strerror(rc)); > + "create_ipsec_esp_flow() failed\n"); > } > print_one_sa_rule(sa, inbound); > } -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com