From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70918A053D; Fri, 17 Jul 2020 13:43:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23E7D1C0BE; Fri, 17 Jul 2020 13:43:23 +0200 (CEST) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id EE94A1C07D for ; Fri, 17 Jul 2020 13:43:18 +0200 (CEST) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3AAD43EE40A27BACBA67 for ; Fri, 17 Jul 2020 19:43:17 +0800 (CST) Received: from [10.69.31.206] (10.69.31.206) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Jul 2020 19:43:08 +0800 To: References: <20200617190248.25858-1-log0div0@gmail.com> <1768cd54-65a0-5fca-ef3f-418429a1ea3d@gmail.com> <193e5a74-2f99-e2ca-b7b2-e1e7a32d8597@huawei.com> CC: Chas Williams <3chas3@gmail.com>, , Ferruh Yigit , "Wei Hu (Xavier)" From: "Wei Hu (Xavier)" Message-ID: Date: Fri, 17 Jul 2020 19:43:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.69.31.206] X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] pmd_bond: fix mac address update for ACTIVE_BACKUP, TLB and ALB modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Sergey Lvov Thanks for you reporting issues, The identical modification had been applied to dpdk-next-net. http://patches.dpdk.org/patch/68742/ repo: http://dpdk.org/git/next/dpdk-next-net f109ce2c5c6b114f533ffcb69460385ac04db215 net/bonding: fix MAC address when switching active port Could you like to 'Signed-off-by' on the patch if there are no object? Thanks, Xavier On 2020/7/11 18:01, Wei Hu (Xavier) wrote: > > Hi, Sergey Lvov > > > There was a two-patch series about bonding those are still in > reviewing state， > > and the one of them includes the identical modification. > > http://patches.dpdk.org/patch/68742/ > > Would you like to review it and give 'Signed-off-by' on the patch if > there are no object? > > Thanks, Xavier > > > On 2020/6/19 9:19, Wei Hu (Xavier) wrote: >> Hi， Chas Williams & Sergey Lvov >> >> There was a two-patch series about bonding those are still in >> reviewing state， >> >> and the one of them includes the identical modification. Thanks. >> >> http://patches.dpdk.org/patch/68742/ >> >> >> The series include two patches: >> http://patches.dpdk.org/patch/68742/ >> http://patches.dpdk.org/patch/68743/ >> >> Best Regards >> Xavier >> >> >> On 2020/6/19 4:32, Chas Williams wrote: >>> Yes, this does look like a typo on someone's part. >>> >>> Please change use net/bonding: instead of pmd_bond: >>> Please add a Fixes: line >>> Please add a Cc: stable@dpdk.org >>> >>> On 6/17/20 3:02 PM, Sergey Lvov wrote: >>> > It seems to be a typo >>> > >>> > Signed-off-by: Sergey Lvov >>> > --- >>> > drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- >>> > 1 file changed, 1 insertion(+), 1 deletion(-) >>> > >>> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c >>> b/drivers/net/bonding/rte_eth_bond_pmd.c >>> > index 612a64599..3ef0df84a 100644 >>> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c >>> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >>> > @@ -1533,7 +1533,7 @@ mac_address_slaves_update(struct rte_eth_dev >>> *bonded_eth_dev) >>> > if (internals->slaves[i].port_id == >>> > internals->current_primary_port) { >>> > if (rte_eth_dev_default_mac_addr_set( >>> > - internals->primary_port, >>> > + internals->current_primary_port, >>> > bonded_eth_dev->data->mac_addrs)) { >>> > RTE_BOND_LOG(ERR, "Failed to update port Id >>> %d MAC address", >>> > internals->current_primary_port); >>> > >>> >> >