From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4177243B67;
Wed, 6 Mar 2024 21:52:40 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2E35842E7A;
Wed, 6 Mar 2024 21:52:40 +0100 (CET)
Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11])
by mails.dpdk.org (Postfix) with ESMTP id A9A0642E6F
for <dev@dpdk.org>; Wed, 6 Mar 2024 21:52:38 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1709758359; x=1741294359;
h=message-id:date:subject:to:cc:references:from:
in-reply-to:content-transfer-encoding:mime-version;
bh=UWfTSpusoZrIYVJswFZhi6XsodWdVd+Oh4Ss7I1AkGw=;
b=juxja89STcIPpnIDiuAFQseBUc3jC5JSgQP5tjdq+vOSgI04Kf0L653s
GtTlVNrgp+xhI8waBkQhuRpZEoz8EXPuXj1Rsq9LsKWo7L8GhdajDlIi2
wVgVPiSx5qMLQkO3h07A45wRsHcZRvmL657CcjKEzxeXfLCyzl3RW23JC
yWkrkMHeGSF5l8Nb5EiFTkk6tEHksfpXUp9IoWmOmXDSJn6vmn2WK+9wb
KBqIqsTNQsD7FFoAAf9S6HNAii7J3PjzdR2b9ThoYziAL/N/NOzrgOCkG
Lqt3rOI/CUrpDU3agZPGvjVdbGt9nJvZsJdSHQWe1TebDLk02SwrAMBpA g==;
X-IronPort-AV: E=McAfee;i="6600,9927,11005"; a="14972656"
X-IronPort-AV: E=Sophos;i="6.06,209,1705392000"; d="scan'208";a="14972656"
Received: from fmviesa009.fm.intel.com ([10.60.135.149])
by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
06 Mar 2024 12:52:38 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.06,209,1705392000";
d="scan'208";a="9758286"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
06 Mar 2024 12:52:38 -0800
Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.35; Wed, 6 Mar 2024 12:52:37 -0800
Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by
fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.35; Wed, 6 Mar 2024 12:52:36 -0800
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.35 via Frontend Transport; Wed, 6 Mar 2024 12:52:36 -0800
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by
edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.35; Wed, 6 Mar 2024 12:52:35 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Y827i59krsB7nz1HcSmvk40upBNS6pp2ZSr3B9NnIE5q61jIMv785JREsO0yNUU4dURkGbHemAoO/NLUaURnNOSHNZscdh4x5DWOXmnKzzcbhTACftG4+3bXpqdtWN0mkkeY7ztwB89RO/gnjIk/IZgIh5f5bsqPeZIpN/RO4ET/aMMLOG44g6RO+jAVFSmKNIc0NlBZN3cGM4UzAt81/0H2veH/pMDC5N59vPN47dbZaSE65gQQZ2dEvxYE4zeEM9+prEuXj7J8DiW6uV71MoRvjpe2O1nsMQUPmF1B2ink1UJqelD7UQ+h0elrO5oOh7OpTbyVEOlazB+b8sFGwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=VuYTNLzKQWx/55Y+bUlc13ZUoJRlp8yUgKInQucsFDs=;
b=Ll+usMCxnoJvIZuqJRzEA/5ovo4CmW1s3p/l6oh7QWDMypsjPmcOfoyW5yZC9YuLMAN57CmzCkf5oT5pGfy/1TbgEbOyXUXW/r0T57ZiNjzAV81Ey/WzEyVqTmcOAXLeH349ODOs1sEwmXbYbb12xrj98pCtIkWnWdSepBzkUGg1SDtZgwI7CAcfD/pnQoc7xftFiHhrAuQQmQ5XgnbAQol3/zmCefGIyx1nbYrSZOWRPTHC0lxVoCjDtG4LmXLIbYEjP0ynQCbev6n6yBRVykFGdTR5gql3zm6LLFGessbwgXRk62ahc5jUnDqA4amhaFMxCQtnn/AbVDZbJv+gxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8)
by MN0PR11MB6207.namprd11.prod.outlook.com (2603:10b6:208:3c5::21)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.6; Wed, 6 Mar
2024 20:52:28 +0000
Received: from SJ0PR11MB5772.namprd11.prod.outlook.com
([fe80::efb3:f2f6:caf5:9edc]) by SJ0PR11MB5772.namprd11.prod.outlook.com
([fe80::efb3:f2f6:caf5:9edc%4]) with mapi id 15.20.7362.019; Wed, 6 Mar 2024
20:52:28 +0000
Message-ID: <bdade5f7-777d-4c4f-8dbb-4a665cca39b8@intel.com>
Date: Wed, 6 Mar 2024 20:52:26 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/6] hash: replace zero length array with flex array
Content-Language: en-US
To: Tyler Retzlaff <roretzla@linux.microsoft.com>, <dev@dpdk.org>
CC: Bruce Richardson <bruce.richardson@intel.com>, Cristian Dumitrescu
<cristian.dumitrescu@intel.com>, Honnappa Nagarahalli
<honnappa.nagarahalli@arm.com>, Sameh Gobriel <sameh.gobriel@intel.com>,
Yipeng Wang <yipeng1.wang@intel.com>, <mb@smartsharesystems.com>,
<fengchengwen@huawei.com>
References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com>
<1709756036-24068-1-git-send-email-roretzla@linux.microsoft.com>
<1709756036-24068-2-git-send-email-roretzla@linux.microsoft.com>
From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
In-Reply-To: <1709756036-24068-2-git-send-email-roretzla@linux.microsoft.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: DU2PR04CA0053.eurprd04.prod.outlook.com
(2603:10a6:10:234::28) To SJ0PR11MB5772.namprd11.prod.outlook.com
(2603:10b6:a03:422::8)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|MN0PR11MB6207:EE_
X-MS-Office365-Filtering-Correlation-Id: a91451d0-423b-4866-b5d9-08dc3e1f5589
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: osFq33mMiR2udwaGogaj7+4cop1NW6Yq4PDCyFJHwJHL02xfbQ7k++yFnnx6iZa5hQOeCVk3+SW+yqv90bGJlVGfvlmuZsczbTOOHatYH4w8pex/8X4Lh7KztUyE4nW+XCJxXl6cl4WecEcDVG5ew1GdPi1WN5vu7h+ZUln5GZVfhioE8IauIfEJvKyLszvUa/i62NPE/eMRLXfOnRIrzAAPJGuWM9ZWTPvAuLH+kjAsg65vG3CHjqg248m+zDss+PzivFlM2t4B3UJ30/CZYGrwnZDUozsppHD+QXUhlX0rZgY6daxr9je/B+4HlU+LHN30Ts9fHKS4rjOca4J18CKd7EzxvTet9UAom4kFuZWKhayX00kkkqL6FXqpGzRvb3ZR+ncmx4YSX4ao6UTM3J8dPK5aO6Zh1uR1ZBs+uZ6kwuCOn97jcAr8lYsEasH8/ciZD/3Oot9arl6wLz2U/ZX7FdLJGtRAAQ7hX2PPwII2/b06MWQfPcC3vaZQrhM9RhRAX0I+JrIwStetoykckQgfpOG+APu1kXPvbiIAYYHQ1RZipEPL8OK8bYWFhk7MVvlRsladpS7tSpJCEYwy4AhFtNoc4NlYk/9WJQQfiRcTNUmmumhLzoR/vzgPkQJ4BAOAJ8aDGp/DFIfJYCx5jtJ188iz1MzmPaPt3eiA+Kk=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230031)(376005); DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0hqaUh3RkdBQXN5a3VnWkhUNGk3ZEh1VThxRGxReXpWakI5Y0c4K2pwZkkw?=
=?utf-8?B?Z3hoSlpyVDlqYm11OENkVFA2aHlRd2o1Z2gyWW1BaWNLWXQyOUYwNGlNUnBw?=
=?utf-8?B?MkcrVS9vYVNnSk44K2hWaEhVcmEwUG9VZ2hkWHBmWE1KdGllM0FFRzlIcFZq?=
=?utf-8?B?TGp6R1BxWnNIczhaeGZEWlBESjBmYytLaS8rT2RuMEx0WklGSEVWUi94WjdT?=
=?utf-8?B?a012aVNwNHp3RTIyTStNR2ZRUmc2ZytwUHJBckVTT0UwQ1p1MGl1UTBlY3JO?=
=?utf-8?B?aTZXMmVGeUpmdjJxaW0yUTBnWFI3YXhpbDYxQUEyS29yZkpPT3luSUFVNUdi?=
=?utf-8?B?bHhBT1hJREZYcXhIV0pheXExOHV4ZDZHa0lzOTBSRlNTUTU4Vms1OVBkbm9m?=
=?utf-8?B?ektwYi9yQm81ODhzVWtFMTFTNWhYYTk4QVB5WHRONUREY0l0eWRjWjcwNzdK?=
=?utf-8?B?K3h5bGpMWmNDOFIzQ2JIMXJCTCtHQWIzdWZxenNWeXRxRGdmMzU5TURUTXds?=
=?utf-8?B?ZUpGdFV6ZGQ2RDMvWnJWei8wbVNmQktXLzBvYmkxbk1odTZHdGV2MStPL3NW?=
=?utf-8?B?ZUU3U1B2clRIS0J6MEcyQitmKytqdDN6UjBXUm1UUVEwZVhsdU9jSEtQRmR0?=
=?utf-8?B?eWIxLzk4alg3cnpJUzJoRk9ocEJwbzloako0Q2hnS2dWYk5ZcTl6REs5eTQx?=
=?utf-8?B?U1hpcS9WMTRLT1VaNU1LWGRaYzgvbGtOTUNtNGR2eTMwdkJnS2pER2NvazFl?=
=?utf-8?B?TUdZL3hmRzZaNHBQbUhFQW9kZHNuZUJDTTlIYWppaEk2TjlQaVZtbmw1U29F?=
=?utf-8?B?aDVDVUlPYk1US3EwUTluZCt5UTJ5d1R0SU1kc3JEZmdEeHJldmRHS2RrRm9X?=
=?utf-8?B?c01CeGZkUEpVcWIzazh3QnRuNW45TzdkeFYyaUUwZ2lGWEM2SHNGUXBDTlpS?=
=?utf-8?B?LzZKV3hmNDNnWUtYUjdyUmYwYTFnMjBoZ0w4UWJNcVMxbWNIMWFwSHY1dHNa?=
=?utf-8?B?Z2VVZUFGMmx3M1B5M01DdlNKWk5NUDZLYXhNcCtoMUM4MEswRnhkTGFDL3V3?=
=?utf-8?B?WklaZTdqSlNlWWxPaUNtekFYWEszR3IzNVFicDNMWndoQ0ptY3pwSlpTenE1?=
=?utf-8?B?YUdRN29Vd3lhN1dHYWlRdmUwZzV2dGVmRjJNTUd4Y00yRjE5NjUyc3NpcE43?=
=?utf-8?B?cUMyQnlaYkx4N2RhOVRMUmtkeDZqVnJUL2xBMzFIT2FHQUQ1K2twTldLMHJO?=
=?utf-8?B?amdoT3BCdzUyRWJOWUlpTGgrQ0FKS2lWL1FnRmFhSDdLWUNvYU9qZkRHaTRX?=
=?utf-8?B?TkNvbUdudU8vWFRtcWtNNVFVMmEzM3F0Y1RLaU51SFRIT1JWeE5HZGxYQzJ4?=
=?utf-8?B?a2w3WDVkc1A4cjlmS0gvRFBGTFNYekYrRllHNWxsamZiYTJUYlpvUlI4V0d1?=
=?utf-8?B?OVhvK3ozQlB3R1Z2U0lua2FNRC9Ec2hHcFNUYkgrRXh4eXZ3S1VvMmtFWC9p?=
=?utf-8?B?MEc0cUIwLzRHL1pKVGRDdXVqQkx1ZUZ1RWZDUkd0L041UTNoZW8ycDMycXdp?=
=?utf-8?B?TWN2RE9iWEltVGxBcFpVVGF2NjZHU2JoMFZvdnRsNlRyUS8yd2F3dWowZDFu?=
=?utf-8?B?UEZLWVY4ekVVVUpyd1Q0NXBwaWNxeFdzREZGU29qSzFISVFsVzEwZEx3NHFB?=
=?utf-8?B?bVZQNU1hZHJqc0MzMXFNZTBHL1I0Um14NHZCb3dKSWpKY2h0ekkyOWJGU2hx?=
=?utf-8?B?d3FuckNIOVNGRnZoaDdnTWtDSitidkNMbWJ2NTJSaHg4dzhIcDFPWXBTS0Zr?=
=?utf-8?B?UDV2MW53K05YK3k5QkxlbUoyZ3gyMUdEZ25aQVZ1OTIreDRHeEpTOFRQTWJL?=
=?utf-8?B?OHRjMDF3Sk52bzIzWW5Udlk1R3VDWWtEWHBtcHd6Rmt1Y3oyd2ZFVDBxdDRK?=
=?utf-8?B?cWZBVXlxSXlzL1lYZHFSWGhPeHdwSlVKNEc2emxRTXN6TGYxTHVDRU1IR042?=
=?utf-8?B?MzJ3aVpKcUIrWEpBMzZzZTBGYWxSemZubU1WeEJia1Z4NzdKdXdIZnpIVGtN?=
=?utf-8?B?QzBrS3FxQjdVWWczU2Z4NkxTSDg3MWs5SFVqMHdzVUxHRGdTQzhpMTZNY05u?=
=?utf-8?B?dHF6ZUxxd2hXOGQ0QmJZeHd6amhxUnZrMmsrYXJmeUw3dkQ5dnhHRU1zRE81?=
=?utf-8?B?Y0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a91451d0-423b-4866-b5d9-08dc3e1f5589
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 20:52:28.2057 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mq6ie8d4jKGr5MzfhIxm3Xo5Nmsdi85Gpqx80UyAbO0EkJebkWCMBYwqG+MLvEGPV6pfDPABV6vhKNgh0OYfLL26Fr6beCHYJGjfSM5KbNQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6207
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
On 06/03/2024 20:13, Tyler Retzlaff wrote:
> Zero length arrays are GNU extension. Replace with
> standard flex array.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/hash/rte_thash.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
> index 68f653f..10721ef 100644
> --- a/lib/hash/rte_thash.c
> +++ b/lib/hash/rte_thash.c
> @@ -81,7 +81,7 @@ struct rte_thash_subtuple_helper {
> uint32_t tuple_offset; /** < Offset in bits of the subtuple */
> uint32_t tuple_len; /** < Length in bits of the subtuple */
> uint32_t lsb_msk; /** < (1 << reta_sz_log) - 1 */
> - __extension__ alignas(RTE_CACHE_LINE_SIZE) uint32_t compl_table[0];
> + alignas(RTE_CACHE_LINE_SIZE) uint32_t compl_table[];
> /** < Complementary table */
> };
>
> @@ -94,7 +94,7 @@ struct rte_thash_ctx {
> uint32_t flags;
> uint64_t *matrices;
> /**< matrices used with rte_thash_gfni implementation */
> - uint8_t hash_key[0];
> + uint8_t hash_key[];
> };
>
> int
--
Regards,
Vladimir