From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3771A04BF; Thu, 3 Sep 2020 20:40:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A5111C0B6; Thu, 3 Sep 2020 20:40:30 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E5D361C0AE for ; Thu, 3 Sep 2020 20:40:27 +0200 (CEST) IronPort-SDR: rPwUquFougJcNPdEQbRpqfMiWfg+ELa61snrJZlMCWxEvDMeczzoLcWGsAgiOwGgDDGnmYqkmN j45Jz3ec37Eg== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="137692015" X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="137692015" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 11:40:24 -0700 IronPort-SDR: iz4jgu8qQ+m3lRL0Y+jGGdYGTQ+1Fh6cVI+5yJC4eder/Kn8Wo2tMQvFhygpyMK6sOWzj3KKtl BCCcTTFF6oEA== X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="478155913" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.213.44]) ([10.213.213.44]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 11:40:23 -0700 To: David Liu Cc: dpdk-dev , Lincoln Lavoie , Thomas Monjalon References: <20200901190727.76476-1-dliu@iol.unh.edu> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Thu, 3 Sep 2020 19:40:15 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V1] testpmd: add eeprom/module eeprom display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/3/2020 5:40 PM, David Liu wrote: > On Wed, Sep 2, 2020 at 6:00 AM Ferruh Yigit > wrote: > > On 9/1/2020 8:07 PM, David Liu wrote: > > Change display message. > > Add EEPROM dump command > >   "show port eeprom" > > Add module EEPROM dump command > >      "show port module_eeprom" > > Commands will dump the content of the > > EEPROM/module EEPROM for the selected port. > > > > Signed-off-by: David Liu > > > --- > >  app/test-pmd/cmdline.c                      |  87 ++++++++++++++ > >  app/test-pmd/config.c                       | 126 ++++++++++++++++++++ > >  app/test-pmd/testpmd.h                      |   2 + > >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  14 +++ > >  4 files changed, 229 insertions(+) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > > index a037a55c6..71c98dd96 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -166,6 +166,12 @@ static void cmd_help_long_parsed(void *parsed_result, > >                       "show port > (info|stats|summary|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n" > >                       "    Display information for port_id, or all.\n\n" > >  > > +                     "show port (port_id) eeprom \n" > > +                     "    Display the EEPROM infomation for given > port_id.\n\n" > > + > > +                     "show port (port_id) module_eeprom \n" > > +                     "    Display the port moudle EEPROM infomation for > given port_id.\n\n" > > + > >                       "show port X rss reta (size) (mask0,mask1,...)\n" > >                       "    Display the rss redirection table entry indicated" > >                       " by masks on port X. size is used to indicate the" > > @@ -7594,6 +7600,85 @@ cmdline_parse_inst_t cmd_showdevice = { > >               NULL, > >       }, > >  }; > > + > > +/* ** SHOW EEPROM INFO *** */ > > +struct cmd_showeeprom_result { > > +       cmdline_fixed_string_t show; > > +       cmdline_fixed_string_t port; > > +       cmdline_fixed_string_t type; > > +        uint16_t portnum; > > +}; > > + > > +static void cmd_showeeprom_parsed(void *parsed_result, > > +               __rte_unused struct cmdline *cl, > > +               __rte_unused void *data) > > +{ > > +       struct cmd_showeeprom_result *res = parsed_result; > > + > > +       port_eeprom_display(res->portnum); > > +} > > + > > +cmdline_parse_token_string_t cmd_showeeprom_show = > > +       TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, show, "show"); > > +cmdline_parse_token_string_t cmd_showeeprom_port = > > +       TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, port, "port"); > > +cmdline_parse_token_num_t cmd_showeeprom_portnum = > > +       TOKEN_NUM_INITIALIZER(struct cmd_showeeprom_result, portnum, UINT16); > > +cmdline_parse_token_string_t cmd_showeeprom_type = > > +       TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, type, > "eeprom"); > > + > > +cmdline_parse_inst_t cmd_showeeprom = { > > +       .f = cmd_showeeprom_parsed, > > +       .data = NULL, > > +       .help_str = "show port eeprom", > > +       .tokens = { > > +               (void *)&cmd_showeeprom_show, > > +               (void *)&cmd_showeeprom_port, > > +               (void *)&cmd_showeeprom_portnum, > > +               (void *)&cmd_showeeprom_type, > > +               NULL, > > +       }, > > +}; > > + > > +/* ** SHOW MODULE EEPROM INFO *** */ > > +struct cmd_showmoduleeeprom_result { > > +       cmdline_fixed_string_t show; > > +       cmdline_fixed_string_t port; > > +       cmdline_fixed_string_t type; > > +        uint16_t portnum; > > +}; > > + > > +static void cmd_showmoduleeeprom_parsed(void *parsed_result, > > +               __rte_unused struct cmdline *cl, > > +               __rte_unused void *data) > > +{ > > +       struct cmd_showmoduleeeprom_result *res = parsed_result; > > + > > +       port_module_eeprom_display(res->portnum); > > +} > > + > > +cmdline_parse_token_string_t cmd_showmoduleeeprom_show = > > +       TOKEN_STRING_INITIALIZER(struct cmd_showmoduleeeprom_result, show, > "show"); > > +cmdline_parse_token_string_t cmd_showmoduleeeprom_port = > > +       TOKEN_STRING_INITIALIZER(struct cmd_showmoduleeeprom_result, port, > "port"); > > +cmdline_parse_token_num_t cmd_showmoduleeeprom_portnum = > > +     TOKEN_NUM_INITIALIZER(struct cmd_showmoduleeeprom_result, portnum, > UINT16); > > +cmdline_parse_token_string_t cmd_showmoduleeeprom_type = > > +     TOKEN_STRING_INITIALIZER(struct cmd_showmoduleeeprom_result, type, > "module_eeprom"); > > + > > +cmdline_parse_inst_t cmd_showmoduleeeprom = { > > +     .f = cmd_showmoduleeeprom_parsed, > > +     .data = NULL, > > +     .help_str = "show port module_eeprom", > > +     .tokens = { > > +             (void *)&cmd_showmoduleeeprom_show, > > +             (void *)&cmd_showmoduleeeprom_port, > > +             (void *)&cmd_showmoduleeeprom_portnum, > > +             (void *)&cmd_showmoduleeeprom_type, > > +             NULL, > > +     }, > > +};> + > > Since both commands are simple and related, what do you think merging their > implementation? This reduces the clutter. > Please check '#' usage in the 'TOKEN_STRING_INITIALIZER', and "port > start|stop|close all" implementation can be sample. > > Yes, that sounds good. What do you think of having the command to be "show port > (port_id|all) (module_eeprom|eeprom)"? > (Please don't top post, bad for archiving, copy/pasted from top of the email) +1 to "(module_eeprom|eeprom)" part. Not sure about "(port_id|all)", since this will hexdump the eeprom, I assume the output will be long and not sure if there will be need to dump all ports at once. So I suggest start with only "port_id" and "all" support later if there is a need, unless you already need it.