From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F238A09EA; Wed, 9 Dec 2020 11:49:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57B8FC8F8; Wed, 9 Dec 2020 11:49:49 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D9C6BBE73 for ; Wed, 9 Dec 2020 11:49:46 +0100 (CET) IronPort-SDR: V3CK1pMzUl9w+v9sOpESmyk+4n3ccTLTss31m5Q3wBS+a/GXJvrZNNqpn/tc1zM3PF9eYjLNH6 X3ih8+nkpSOQ== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="153294199" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="153294199" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 02:49:44 -0800 IronPort-SDR: BwMzFkiaj/eFD4wKZLTCfzZqvbR4FKQm0jhSOqhmnWcZ38gLRWErkfpZP2QYtuwt9TJztyUYs5 XWE3wk0M54hg== X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="437737417" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.215.89]) ([10.213.215.89]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 02:49:43 -0800 To: lironh@marvell.com, bruce.richardson@intel.com Cc: dev@dpdk.org, Akhil Goyal References: <20201202130529.7332-1-lironh@marvell.com> <20201202130529.7332-2-lironh@marvell.com> From: Ferruh Yigit Message-ID: Date: Wed, 9 Dec 2020 10:49:42 +0000 MIME-Version: 1.0 In-Reply-To: <20201202130529.7332-2-lironh@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/2/2020 1:05 PM, lironh@marvell.com wrote: > From: Liron Himi > > With pkg-config support available within musdk library, > meson option 'lib_musdk_dir' can be removed. > PKG_CONFIG_PATH environment variable should be set appropriately > to use the musdk library. > > Signed-off-by: Liron Himi > Reviewed-by: Liron Himi > --- > drivers/common/mvep/meson.build | 14 +++++--------- > drivers/crypto/mvsam/meson.build | 15 +++++---------- > drivers/net/mvneta/meson.build | 19 +++++-------------- > drivers/net/mvneta/mvneta_ethdev.h | 1 + > drivers/net/mvpp2/meson.build | 15 +++++---------- > meson_options.txt | 2 -- > 6 files changed, 21 insertions(+), 45 deletions(-) > Hi Liron, +1 to this change, but can you please make a new version to include build related document changes into this same patch? Second patch updates document, both for this build related issues and other issues like new musdk version and supported features etc.. Instead you can move build related changes to this patch, and separate second patch for crypto and net, so that it can have proper commit logs for each and can be reviewed easier. -- Thanks, ferruh