From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 9339B1B30F for ; Tue, 10 Oct 2017 19:32:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1087; q=dns/txt; s=iport; t=1507656728; x=1508866328; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=qqnBTHJVrSgrHY6VQoF2lrNtDYpOpl4g/w1r64ifQxU=; b=CCNXOs07mcUOT3O4vxNbUWnQZhbGfd9kEtrNCx0Zm1Vl6rHaYuAOXYrf DAc3PlcM/VRrZgWf7fRbjCaTa/fIyz2vz7ln3GpdoVcX0SvaM9P/VipXD amdYVG6a8hQf/7z5xC7OnYJJt8ovjTglACViWWzeYDFkhZa3NO5V3eD3O s=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CdAAD7At1Z/49dJa1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1uBUicHjhKPdIF2li+CEgqFOwKETj8YAQIBAQEBAQEBayiFHQE?= =?us-ascii?q?BAQEDOksEAgEIDgMEAQEfCQcyFAkIAgQBEgiKHKpVizEBAQEBAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEdgy2CAoFRgWqDKYRNhisFoTwClF6TGJU0AhEZAYE4AR84gQ54FYV?= =?us-ascii?q?jHIFndod/gTOBEAEBAQ?= X-IronPort-AV: E=Sophos;i="5.43,359,1503360000"; d="scan'208";a="15143195" Received: from rcdn-core-7.cisco.com ([173.37.93.143]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2017 17:32:07 +0000 Received: from XCH-RCD-010.cisco.com (xch-rcd-010.cisco.com [173.37.102.20]) by rcdn-core-7.cisco.com (8.14.5/8.14.5) with ESMTP id v9AHW7fk002839 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 10 Oct 2017 17:32:07 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-RCD-010.cisco.com (173.37.102.20) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 10 Oct 2017 12:32:06 -0500 Received: from xch-rcd-007.cisco.com ([173.37.102.17]) by XCH-RCD-007.cisco.com ([173.37.102.17]) with mapi id 15.00.1320.000; Tue, 10 Oct 2017 12:32:06 -0500 From: "John Daley (johndale)" To: Aaron Conole , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment Thread-Index: AQHTNvjjnmmqL55TTEWWs31HuV2q6qLcmC+Q Date: Tue, 10 Oct 2017 17:32:06 +0000 Message-ID: References: <20170926185329.2776-1-aconole@redhat.com> <20170926185329.2776-5-aconole@redhat.com> In-Reply-To: <20170926185329.2776-5-aconole@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.19.145.149] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 17:32:08 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Aaron Conole > Sent: Tuesday, September 26, 2017 11:53 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment >=20 > The assignment at initialization is overwritten immediately. Drop the > assignment. >=20 > Signed-off-by: Aaron Conole > --- > drivers/net/enic/base/vnic_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/enic/base/vnic_dev.c > b/drivers/net/enic/base/vnic_dev.c > index a4b7f4b..932667f 100644 > --- a/drivers/net/enic/base/vnic_dev.c > +++ b/drivers/net/enic/base/vnic_dev.c > @@ -272,7 +272,7 @@ int vnic_dev_alloc_desc_ring(struct vnic_dev *vdev, > __attribute__((unused)) unsigned int socket_id, > char *z_name) > { > - void *alloc_addr =3D NULL; > + void *alloc_addr; > dma_addr_t alloc_pa =3D 0; >=20 > vnic_dev_desc_ring_size(ring, desc_count, desc_size); > -- > 2.9.5 Reviewed-by: John Daley Thanks, Johnd