From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34F0DA2EEB for ; Mon, 7 Oct 2019 09:17:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EE391C237; Mon, 7 Oct 2019 09:17:45 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B6B4B5B3C; Mon, 7 Oct 2019 09:17:43 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 853EFB40066; Mon, 7 Oct 2019 07:17:42 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 7 Oct 2019 08:17:36 +0100 To: Maxime Coquelin , Marvin Liu , , , CC: , References: <20190923140511.107939-1-yong.liu@intel.com> <371258a9-a93e-42ac-f162-2af6a84c93fa@redhat.com> From: Andrew Rybchenko Message-ID: Date: Mon, 7 Oct 2019 10:17:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <371258a9-a93e-42ac-f162-2af6a84c93fa@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24960.003 X-TM-AS-Result: No-0.050500-8.000000-10 X-TMASE-MatchedRID: zGP2F0O7j/vmLzc6AOD8DfHkpkyUphL94vtXlRtrMekgi9sgQ964gaHD MThyZnbzdXZDh48M0EhqBGDb0GlKlSQYHMLagAMBAZ0lncqeHqEacZilk37ECDL/GHoao0dVgG8 l8Vuw4XaL73aFvRPMW9XL6+l7Kapn04HDiZrzSF1l1tleYYUuJ0qAhuLHn5fEva4hxzuVF7iVos Zw8RezUC25Nk9Tq7Y7PDCUCyMAAe6XBXaJoB9JZzl/1fD/GopdcmfM3DjaQLHEQdG7H66TyJ8TM nmE+d0Za47IiK9j2wUmG8svZtEn54qYQrWWYcjJ/cAzO6olVT67Bf/zS4Z6HU3w52U8RSB7O9m0 IwvZzbjVfPMYg0zj/6UxmDVIpcmk1DXsKeBNv04EqZlWBkJWd7MZNZFdSWvHG2wlTHLNY1JWXGv UUmKP2w== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.050500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24960.003 X-MDID: 1570432663-mA-0ufee_Tdt Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/27/19 12:50 PM, Maxime Coquelin wrote: > On 9/23/19 4:05 PM, Marvin Liu wrote: >> If reserve virtio header room by function rte_pktmbuf_prepend, both >> segment data length and packet length of mbuf will be increased. >> Data length will be equal to descriptor length, while packet length >> should be decreased as virtio-net header won't be taken into packet. >> Thus will cause mismatch in mbuf structure. Fix this issue by access >> mbuf data directly and increase descriptor length if it is needed. >> >> Fixes: 58169a9c8153 ("net/virtio: support Tx checksum offload") >> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") >> Fixes: 4905ed3a523f ("net/virtio: optimize Tx enqueue for packed ring") >> Fixes: e5f456a98d3c ("net/virtio: support in-order Rx and Tx") >> Cc: stable@dpdk.org >> >> Reported-by: Stephen Hemminger >> Signed-off-by: Marvin Liu >> > Applied to dpdk-next-virtio/master. We observe regressions in virtio with the patch applied. We've not found root cause yet. Andrew.