From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BDD012BAE for ; Tue, 11 Apr 2017 12:12:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491905524; x=1523441524; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=JVOx8N3bHL3BoFN1kAE0aNEJpQnfJaFXvzvE2Du6IL0=; b=UBEjXaz2WGdOoB3s6Dgc2N96QNpYHHIJ9iTKBO1tjVfZrPf9fROnZYq4 V1LIOug9CUbg5v0NcHmGRxYRaXFyKw==; Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2017 03:11:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,185,1488873600"; d="scan'208";a="1118123173" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69]) ([10.237.221.69]) by orsmga001.jf.intel.com with ESMTP; 11 Apr 2017 03:11:55 -0700 To: Jingjing Wu , dev@dpdk.org References: <1491896149-29328-1-git-send-email-jingjing.wu@intel.com> From: "Hunt, David" Message-ID: Date: Tue, 11 Apr 2017 11:11:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491896149-29328-1-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix default PFC setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 10:12:05 -0000 On 11/4/2017 8:35 AM, Jingjing Wu wrote: > To keep consistent with previous release, PFC need to be disabled > by default. This patch fixes it. > > Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs") > Signed-off-by: Jingjing Wu > --- > drivers/net/i40e/i40e_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 6927fde..3e640b3 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb) > hw->local_dcbx_config.pfc.willing = 0; > hw->local_dcbx_config.pfc.pfccap = > I40E_MAX_TRAFFIC_CLASS; > - hw->local_dcbx_config.pfc.pfcenable = > - I40E_DEFAULT_TCMAP; > /* FW needs one App to configure HW */ > hw->local_dcbx_config.numapps = 1; > hw->local_dcbx_config.app[0].selector = This also fixes an issue I was having occasionally where traffic was not forwarded by testpmd on my platform. In those cases I was seeing ~4770 pps on one of the ports rather than the full rate (>20mpps). A git bisect confirmed that this commit (6f0a707e5b55) was the source of the issue. Tested-by: David Hunt