DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Lijun Ou <oulijun@huawei.com>
Cc: dev@dpdk.org, linuxarm@huawei.com
Subject: Re: [dpdk-dev] [PATCH] doc: update features for hns3
Date: Mon, 23 Nov 2020 16:41:26 +0000
Message-ID: <be4f3a02-8cba-673f-6c2f-a2b0e450db1c@intel.com> (raw)
In-Reply-To: <1606141948-42313-1-git-send-email-oulijun@huawei.com>

On 11/23/2020 2:32 PM, Lijun Ou wrote:
> Since the hns3 NIC hardware features are not counted
> and it is supported in fact. Besides, the flow director
> is not supported and need to delete it.
> 

Hi Lijun,

Normally these should be updated when the feature is added but it seems we have 
missed them.

Can you please add the commits that introduces the features as "Fixes: " line, 
to have them as reference?

> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
>   doc/guides/nics/features/hns3.ini | 8 ++++++++
>   doc/guides/nics/hns3.rst          | 3 ++-
>   2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
> index fc61dde..f897a14 100644
> --- a/doc/guides/nics/features/hns3.ini
> +++ b/doc/guides/nics/features/hns3.ini
> @@ -7,8 +7,12 @@
>   Link status          = Y
>   Rx interrupt         = Y
>   Queue start/stop     = Y
> +Runtime Rx queue setup = Y
> +Runtime Tx queue setup = Y
> +Burst mode info      = Y
>   MTU update           = Y
>   Jumbo frame          = Y
> +Fast mbuf free       = Y
>   Scattered Rx         = Y
>   TSO                  = Y
>   LRO                  = Y
> @@ -20,19 +24,23 @@ RSS hash             = Y
>   RSS key update       = Y
>   RSS reta update      = Y
>   DCB                  = Y
> +SR-IOV               = Y
>   VLAN filter          = Y
>   Flow control         = Y
>   Flow API             = Y
>   CRC offload          = Y
>   VLAN offload         = Y
> +QinQ offload         = P

Is "QinQ offload" supported? I don't see the driver setting neither 
'PKT_RX_QINQ_STRIPPED' nor 'PKT_RX_QINQ' to mbuf.ol_flags.
Can you please describe in the commit log why it is supported partially (P)?

  reply	other threads:[~2020-11-23 16:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 14:32 Lijun Ou
2020-11-23 16:41 ` Ferruh Yigit [this message]
2020-11-24  1:47   ` oulijun
2020-11-24 13:56 ` [dpdk-dev] [PATCH v2] " Lijun Ou
2020-11-24 16:31   ` Ferruh Yigit
2020-11-26 16:58     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be4f3a02-8cba-673f-6c2f-a2b0e450db1c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=linuxarm@huawei.com \
    --cc=oulijun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git