From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27038A04B1; Mon, 23 Nov 2020 17:41:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D030C8FA; Mon, 23 Nov 2020 17:41:34 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5E5A3C8E4 for <dev@dpdk.org>; Mon, 23 Nov 2020 17:41:32 +0100 (CET) IronPort-SDR: NZB5BC3duVZmn0bH05ytYERG1satC/unSDtSi530VD1XGEZbm27N1lp0Qsxcpj31S8xuULUbMj TEJmANuK9F7Q== X-IronPort-AV: E=McAfee;i="6000,8403,9813"; a="158840055" X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="158840055" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 08:41:30 -0800 IronPort-SDR: l//al6tiJRYxH0AX9XrclK+h7jJjJZqXT8KCmHT6/fM26sH3d8gZq0YY3uNfLJfJ+J0kFeJuE6 YSMMzr4B96dw== X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="327253951" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.20.15]) ([10.252.20.15]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 08:41:29 -0800 To: Lijun Ou <oulijun@huawei.com> Cc: dev@dpdk.org, linuxarm@huawei.com References: <1606141948-42313-1-git-send-email-oulijun@huawei.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <be4f3a02-8cba-673f-6c2f-a2b0e450db1c@intel.com> Date: Mon, 23 Nov 2020 16:41:26 +0000 MIME-Version: 1.0 In-Reply-To: <1606141948-42313-1-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: update features for hns3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 11/23/2020 2:32 PM, Lijun Ou wrote: > Since the hns3 NIC hardware features are not counted > and it is supported in fact. Besides, the flow director > is not supported and need to delete it. > Hi Lijun, Normally these should be updated when the feature is added but it seems we have missed them. Can you please add the commits that introduces the features as "Fixes: " line, to have them as reference? > Signed-off-by: Lijun Ou <oulijun@huawei.com> > --- > doc/guides/nics/features/hns3.ini | 8 ++++++++ > doc/guides/nics/hns3.rst | 3 ++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini > index fc61dde..f897a14 100644 > --- a/doc/guides/nics/features/hns3.ini > +++ b/doc/guides/nics/features/hns3.ini > @@ -7,8 +7,12 @@ > Link status = Y > Rx interrupt = Y > Queue start/stop = Y > +Runtime Rx queue setup = Y > +Runtime Tx queue setup = Y > +Burst mode info = Y > MTU update = Y > Jumbo frame = Y > +Fast mbuf free = Y > Scattered Rx = Y > TSO = Y > LRO = Y > @@ -20,19 +24,23 @@ RSS hash = Y > RSS key update = Y > RSS reta update = Y > DCB = Y > +SR-IOV = Y > VLAN filter = Y > Flow control = Y > Flow API = Y > CRC offload = Y > VLAN offload = Y > +QinQ offload = P Is "QinQ offload" supported? I don't see the driver setting neither 'PKT_RX_QINQ_STRIPPED' nor 'PKT_RX_QINQ' to mbuf.ol_flags. Can you please describe in the commit log why it is supported partially (P)?