From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0050.outbound.protection.outlook.com [104.47.34.50]) by dpdk.org (Postfix) with ESMTP id 0876C2A6C for ; Wed, 5 Apr 2017 11:55:51 +0200 (CEST) Received: from CY1PR03CA0018.namprd03.prod.outlook.com (10.174.128.28) by CY4PR03MB3110.namprd03.prod.outlook.com (10.171.245.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Wed, 5 Apr 2017 09:55:49 +0000 Received: from BY2FFO11OLC011.protection.gbl (2a01:111:f400:7c0c::195) by CY1PR03CA0018.outlook.office365.com (2603:10b6:600::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10 via Frontend Transport; Wed, 5 Apr 2017 09:55:50 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11OLC011.mail.protection.outlook.com (10.1.15.22) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1005.5 via Frontend Transport; Wed, 5 Apr 2017 09:55:49 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v359tkUa002109; Wed, 5 Apr 2017 02:55:47 -0700 To: Santosh Shukla References: <1491382264-23489-1-git-send-email-santosh.shukla@caviumnetworks.com> <1491382264-23489-2-git-send-email-santosh.shukla@caviumnetworks.com> CC: , , From: Shreyansh Jain Message-ID: Date: Wed, 5 Apr 2017 15:32:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491382264-23489-2-git-send-email-santosh.shukla@caviumnetworks.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131358597500866354; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39840400002)(39410400002)(39400400002)(39450400003)(39850400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(24454002)(377454003)(9170700003)(31686004)(106466001)(50986999)(64126003)(76176999)(86362001)(105606002)(31696002)(356003)(38730400002)(23746002)(33646002)(53936002)(36756003)(6916009)(2906002)(81166006)(6666003)(6246003)(2950100002)(229853002)(230700001)(8936002)(50466002)(8676002)(85426001)(110136004)(83506001)(54356999)(4326008)(189998001)(4001350100001)(305945005)(8656002)(54906002)(77096006)(104016004)(65806001)(47776003)(65956001)(65826007)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB3110; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC011; 1:+aMuYM1Dd3n3XGHflz8Tp7IMRHfU7YflMWM6TWN5bY8VkwyK2KfSbjHoBUu4x6HRlb9uTmc+iEXedobD2KVY2A/Dnz2JDxcp5xRJ5VByfcMlbNvW8OnGTtGPJSpGa7YB6xhrceKzvUBEuuPXXy3KIF6/lFefqD2NzWcCOUxjlP/LfqzCKmSCE/CHhqCeF13fKuXZBrImaOmVEammvw1IF3iIrCsI8Gzj7TgTP9BER1upxfe4eOsL6cP/dacx6L6BU3lvYHjl4a/C6H1JTvh7/EsL8GZVAGUm8m/ZNgaFQ3izUUc9cM/x+ZKVfz7nWflxRaIDwVYVKnfjDFVA1LHTwJPEmjTI2NWrlL4Wn/nFsNTOHeDVSvuXlYOGzWOxY3maoS3FrMS1nE64CzGqcmPONGwPUQHh7IUEMXKDp8tvXy6/PD4kC3E2LUvTuFwEZ5H/Wc26+VrKiWrHMpqNsc5BheSR+Z0j4tKnWUzcXFdTZZbTjNp+PJ75Bzy50OfhmSRk4Bwfw2THIhg1oplGlzDz4dnzY9aooPn1bt6Zif2rc5rvNSbI9fwG3Sf9PjBwXZextJxMdTVsd+7CX5KB8+Q9Yrr4WVY7Xs7B+HNW+8bkytc= X-MS-Office365-Filtering-Correlation-Id: dd27402e-e744-4acf-8f32-08d47c09f0b2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:CY4PR03MB3110; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3110; 3:0scmXhD/P1IIEchky29UZGEUlzEkI/Hh8pEQEhzIC7jk4hmbXNf5o8CmJB/06u3JFvqm2nxMmqQB8XmVYdjYIjdpbL6mmNWURlz3BXQwR7Oqpg7AzRw9ZMKgXy9uRW1Dv5tn7WMlhcri4dyDmK14fz1eT1goCAFd8LNYUsgFeKdO3w6QU04LjL2v22fKN1XN54YtROPL33Jl7whKg0oqgd2ozi8k1zf3EQKgOab8TbKBoK+bhM5fWSUVjucTglPQVuGMbCYCnqNQVi4BRkpKI/hYrfYsiVLRLpWh+cd7bQ68/8v7YmIEhDFaZepuZS+fP322innd4vP5EJZT5LFzhXfdRw+4Mwl8YUm9w1dW1Lc6tlAhDO5XTF+PXp9eYDLNCJ09y+gNKee9z40UQsFaHVlAwvlwlVa7PeCVuDam75I5+Yh2p9QZejmvyG8fOzjP; 25:y5gyopunv8WSnX+1kQJ8t2d0km0t2uAl2Yhsd4OpZjA/VqmumcKYzb9bkAGdBrroZgEW8S0gLyrAESm0acCGpNi/sMAy/9xQIbpT5oImlFwKNmh5QVwpmK9RNJmwcgcnggpmASgRDh0tsmPq4Y9GE2gyUiAGTzNHUWvKyK5wZ4ZyEUkpqkwu/grZFg4TutMK7iqASgTZ3TOd0kqiarZ7DsIJu9BEtB2/FaNESIcPncWKFs2XzB0mwTkdW7YbdjM1NbRTMTSwIYF/KaWVIbXx2w7bvvCBVh0U9eT9hEIiU7lcJEjIgnK9pHbrI+GDgKz/3oNCGtYvUspRulL0kxcME5QA+2r+5zM2P5+zEkooef89cK10N1qhdQeqqa9NagDnGlitPJ7qQbUm+Cm5cMcLQbgAJmTIW0A4uaic0y6QTyMxwwi5CCFlWxwa8A3o5SQ4CpTzLOwy3qJiE56pSCuIcA== X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3110; 31:o0HF83eBCedzjCmjBxrvhePI44WVEioJOgU2y3OemLzDHOKDpHsRbPtL71DYBMSRDTv0AHi6GLzXNhHodtMNVQ08+SHaCVdIlqHF9ewmhEISq8XMj4nLP07sj4YfwwuP1811hr+WYG2TzrEXbmOKNQhpcqmqh7kL0YDeOPSqdQL2un+X74ORbiBCzCwWBDY1BZJYRoFrgG5nkP9szZ3QTryeH7JOBfj6RUaZhI4tuUHHbiKUTcX1nkF1Oig3WiwP7tRqcscchkwR+5yksY84uGA03ffn21u38KFvB8N3JnU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13015025)(13017025)(5005006)(8121501046)(13024025)(13018025)(13023025)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123563025)(20161123556025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259075)(20161123565025); SRVR:CY4PR03MB3110; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB3110; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3110; 4:b2ZxsF9y/bDryIBWMGxwTsn/GrodZh6vlAWUrQvtjCRRUNFE0dtjQ0ip5Pft/kzyuKrVwrQtZNYgziwBWLU6ykIG9KScPZXuE3wnR1tnGuhYSpAidIEV6mczrx3SsW8eNx7EMApVMmr3rx4ViDr2w6fEhQIMe+iJK/IifPAEDxcGadGQJju+wGK0DYswiUj/6wwAqaIbHyEUleDGoPmxe9EQVjI/Zeq7nXM3mxa2jnq3UxeqM0Rw1jRTlis3wavJtMoUJxI4yK7DpPY2JnURLOYZvbYYDSKOYVCNnFvO+C7PdwXb7/IZ43FL53cZC+DKqX6G1rq6Y5oWxItY6igbRljoX5r6RsYQI8lsq/j99bWr41HiIQ994JOvkN960My/tl8fR3pzJxgYqwvaEn+Cc7HjrD+4JALlc7T1yvk9FHpqvtq8ysqah1xmup32p33EWnP6dfF1i7R36V/31OTANMUO1ZIaydpX6fEvXgt5xjEr82KDrC+kX4BkI14UXqYUsMZvT28JQgS95oY0W3ywAJFvwsWz3m8H1uM8OzpDEiBJx54rY1k9Rx2lspJMhHMDH9/quFkRXy/FvAyAgMhONR9qdUCbVhtjUcoI97tBflWfjIv9i+VWEpdHDuuXrEnIlY5ePuozBhd+XfLDYi4VcdX+IqEAPTi06Rg4TgoMcpfSw9WCA733c7DUm3VFnisGi/NpfBdoAC12OpWaPH1RaLbw0P7CFMABC5JKzPjl3VHos7gjdfn14UGARnnvXKJzdIugDbC8mQ5Vts/wrsR2/K8qKt/Zhf0r86xZ+uRM7/fslO9sQYz3dIHEIqCPMfo5tAFro3+oGRKIa6yLghbL38OOp14DA6PQO+0FG5lRvUoyv4jHjyr+i24PRbzMrwgRv7DzHZdt6H2Mt9VGTOX8x2lCAIeswioIiq8qdRWuf0g= X-Forefront-PRVS: 0268246AE7 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB3110; 23:R950WUpI0fhW4nOnwfm2LIFqh5NoqDEot7IKh?= =?Windows-1252?Q?RxZMor/2fT60MrVK9qdhgzj4Pt2ZjbEdSX8RVweCEUdyStAw8QVe+VYR?= =?Windows-1252?Q?WdT0bu+tsqSFDYwyZahsd+oJk082f14s6AAHj/jQ35Er9SWndNIVGr7b?= =?Windows-1252?Q?HNENaZyzxaRvLgnC1qwbZPWXbrbo9WvL68Gb8os3oYfpJNUyECKvM+D2?= =?Windows-1252?Q?L+wlHObLLeJ78s8hmOSnMTZd1XNSpmmIWG2oo3McjHByHiYWbOwS03Nx?= =?Windows-1252?Q?2MGX6Ts1VwNvIhmsLIv9LJfm6B7ei/9HtNwjVJhhAgQwVnBdkOIgnfmd?= =?Windows-1252?Q?JqWzJa3qdYSOQM0YIq/fXV7B7hzEcZCjYn4DJVBVO2TX+oFCK2A5wH4V?= =?Windows-1252?Q?u9+sLnxsVWeNH8AtxpnAnNqasZ6lHipw771FDTHxX7VySsPut/AafHP7?= =?Windows-1252?Q?jHNyzgxxuYbXD5IGrF/HzN/uZte70SSIypAdhmIxDGBVRLFylfy2eb2L?= =?Windows-1252?Q?ZHlkg73BIamBdkMG+wW4mlkCBWe39ZYGHg+zPJZuD9lkTRuONKNlPbxS?= =?Windows-1252?Q?n2VbCJHObu7x5jOIM1X2DVr4MJnDhYWUH4j+Hw8Yg45wAHemrlSKW5M2?= =?Windows-1252?Q?T+l3cfKoktE/Y4XjhYQwOkiLz32ZPEB/lMSj9jqzyyt0xymTKAflS79y?= =?Windows-1252?Q?G7aPKizpZvHFNPXT6ZRLIdHVikMEOHbmnahMLnl1Q5xxhDvvOFYIMU7t?= =?Windows-1252?Q?IJ/DIiVLQTOUgCvtlB9r3wKvsWBD3fMg95DMrVMfk2Hhvranmi0Xcggn?= =?Windows-1252?Q?KdfoGrmKI7CSwjwpW6ezSU05CEVBoGpTYoDxyjxk+0CfoFo7jSTRW4qX?= =?Windows-1252?Q?Gf0FNYZdxqJb0q392f0itZ6ChXxYsUCWO+qN8E8CDdDE7pc7advQ+9OK?= =?Windows-1252?Q?RERU6zjpsSYwicpnDvn7JgxchYnt1EWHVWqtjsasrtWqX9Krq7NJXvEU?= =?Windows-1252?Q?fj+fr1y/n3ooCCwTpNqE3LOOf3FDciL03+ovuytqDJ8JsmeU7XC+xDjV?= =?Windows-1252?Q?m/orpQD+PLLSZlM02XZmh+LT726KKH9+ey248zkz6ISH3F9zBB8c9zPn?= =?Windows-1252?Q?vJMqqGXI/+HJahKJeAoW3K0A+5lb2/2iFeG5r40F/TKkzzcPHfd8wzvC?= =?Windows-1252?Q?Z/tyy76Dj4V1IE/M3XqO2JcgsYUzxLdOoUek5ysX/HBZpSd4Ul5yfdv0?= =?Windows-1252?Q?a1WLKpF8VT1EpYkxTBiBKICZqpec3y+YxMSE3L40eeP0DWSoLwnnqgjo?= =?Windows-1252?Q?yELkbPQOHhLhfIZgbuvAJr8QjFlyq0/zOnUIsiuwFgGyzP4nf/KEPzhi?= =?Windows-1252?Q?l0njsajmgyCHJQpk33aoBld22Npbl0lvOwDXFYo4dRA2b8dMFoiG2iPD?= =?Windows-1252?Q?tTXMG4HnBwlAd68rsFhv6lyoXpNWXh9MoZbMsmfFJ7Eb/xkzwEVOe/gd?= =?Windows-1252?Q?7mJpkgLqemYkYAYt+tuVMqEKVnjvIxY+7h+vhWsHxTHjJ6sLrc2pEHil?= =?Windows-1252?Q?1AYakKoPmanvVf2od82uirpDZAoovGvfHiE?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3110; 6:M/hG5ipcidZumW4aWcBUjFs+Ai8m38EBVU+gI7OYKxUCWB28xljIxJho1BSbZSpxeZ40nxz04a6G/OjagMVcTHlcxXHM39kyS/KZd4YISjXv4Z5l42ulLH+SLJbcxoyEtyPaUurOhUHPfGc13MmdiXiaWHqiscttlpra+0E9jC8Uv/zAfQisH2bG+/DQiPcuetOWEnZFlBLEW7ZetagjG7T7AkzTXe4esX3Gosf8aEyaIS09693oFv8r2iHRs1i5JXxc6w+o1ETJWi2vmBERTqVXm/s/huxFKrIQFVr+jPHBaby30KEskIouhJb3A1w6K7ZJxd9WhDTf0ZmV5qIwUll/6lXIBZ6pRBBiitC3hed6nNx5sw1PaVspV9NJpCj+1fdAXxm39Ikn1AxDFJp8Tw==; 5:EGuAnsjoy7tjv06hYROVRbuZqySopYcgfvrTov+1il6mrcpqWSKnBmjescB+uxLq5jQ74meUk50msfZOYqF7ckxTssOYd5bpjDWE1cDUo5f+S+JSx3qSXhL+t0d8IhfFG+7qoycTQUseVifozZn0LOaQ45jW24t30+ARko7QQffQyEKYlGvIWQvnBmApp19F; 24:0xBsGcX/Bq8mq6svtWmcTEXflqRfjpWY7qlXgjGX2a/syHQ4wUhfeFLjkmehmJhpUXYaPCukXbvVox2c/pksPs2CH9xAzKC8PIJt6kLzWB4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB3110; 7:AkpIRGpGCX8UbWwmoE6BhoKK8Y1fxXE7Xnxio1iC9WZC1AOUFfSFmWSrdka7l6TSzNo+N8va+J+2xre6j5zZEuDPtECwTpML8cmkNYABuJD7w2g6+FTO/aZitnfATBPmI5kqp7TmW1TTFORNEvO/CvQ67ucfXXjdhPDpB87tEJgTsy25uHTDNV+Mipsk8IEffTOcg2a6N++OLTV93HrUf7oNQgpqUcnWo1ViY8J+hv+QRBGjUzl+QD1KJHhG2v2vpg33+045Mf80ATHF/bxpBkO8xLzOmmQuc98LBE90OMLu7V8W5+kmMT1ynkPpsl1rkJ2yZx75CIQ/QILmUhJ6ew== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2017 09:55:49.9774 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB3110 Subject: Re: [dpdk-dev] [PATCH 2/2] test/mempool_perf: support default mempool autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 09:55:52 -0000 Hi Santosh, On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote: > Mempool_perf autotest currently does perf regression for: > * nochache > * cache > > Introducing default_pool, mainly targeted for ext-mempool regression > test. Ext-mempool don't need 'cache' modes so only adding test-case > support for 'nocache' mode. > > So to run ext-mempool perf regression, user has to set > RTE_MBUF_DEFAULT_MEMPOOL_OPS="<>" > > There is chance of duplication ie.. if user sets > > RTE_MBUF_DEFAULT_MEMPOOL_OPS="ring_mp_mc" then regression > will happen twice for 'ring_mp_mc' > > Signed-off-by: Santosh Shukla > --- > test/test/test_mempool_perf.c | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c > index 3c45971..9c80860 100644 > --- a/test/test/test_mempool_perf.c > +++ b/test/test/test_mempool_perf.c > @@ -111,6 +111,7 @@ > > static struct rte_mempool *mp; > static struct rte_mempool *mp_cache, *mp_nocache; > +static struct rte_mempool *default_pool; > static int use_external_cache; > static unsigned external_cache_size = RTE_MEMPOOL_CACHE_MAX_SIZE; > > @@ -337,6 +338,31 @@ struct mempool_test_stats { Similar observations as [PATCH 1/2], the context above is not correct. it should be test_mempool_perf(void) > if (mp_cache == NULL) > goto err; > > + /* Create a mempool based on Default handler */ > + default_pool = rte_mempool_create_empty("default_pool", > + MEMPOOL_SIZE, > + MEMPOOL_ELT_SIZE, > + 0, 0, > + SOCKET_ID_ANY, 0); > + > + if (default_pool == NULL) { > + printf("cannot allocate %s mempool\n", > + RTE_MBUF_DEFAULT_MEMPOOL_OPS); > + goto err; > + } > + if (rte_mempool_set_ops_byname(default_pool, > + RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL) < 0) { > + printf("cannot set %s handler\n", > + RTE_MBUF_DEFAULT_MEMPOOL_OPS); > + goto err; > + } > + if (rte_mempool_populate_default(default_pool) < 0) { > + printf("cannot populate %s mempool\n", > + RTE_MBUF_DEFAULT_MEMPOOL_OPS); > + goto err; > + } > + rte_mempool_obj_iter(default_pool, my_obj_init, NULL); > + > /* performance test with 1, 2 and max cores */ > printf("start performance test (without cache)\n"); > mp = mp_nocache; > @@ -351,6 +377,20 @@ struct mempool_test_stats { > goto err; > > /* performance test with 1, 2 and max cores */ > + printf("start performance test for %s (without cache)\n", > + RTE_MBUF_DEFAULT_MEMPOOL_OPS); > + mp = default_pool; > + > + if (do_one_mempool_test(1) < 0) > + goto err; > + > + if (do_one_mempool_test(2) < 0) > + goto err; > + > + if (do_one_mempool_test(rte_lcore_count()) < 0) > + goto err; > + > + /* performance test with 1, 2 and max cores */ > printf("start performance test (with cache)\n"); > mp = mp_cache; > > @@ -384,6 +424,7 @@ struct mempool_test_stats { > err: > rte_mempool_free(mp_cache); > rte_mempool_free(mp_nocache); > + rte_mempool_free(default_pool); > return ret; > } > > Other than the above trivial comment: Acked-by: Shreyansh Jain