From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 49257235 for ; Wed, 27 Feb 2019 22:48:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2019 13:48:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,420,1544515200"; d="scan'208";a="119622510" Received: from istokes-mobl1.ger.corp.intel.com (HELO [10.251.88.219]) ([10.251.88.219]) by orsmga006.jf.intel.com with ESMTP; 27 Feb 2019 13:48:54 -0800 To: Andrew Rybchenko , dev@dpdk.org Cc: stephen@networkplumber.org References: <1550678275-4959-1-git-send-email-ian.stokes@intel.com> <1550678275-4959-2-git-send-email-ian.stokes@intel.com> <095ee887-0fcf-a5ad-ef8e-435e4b812ed9@solarflare.com> From: Ian Stokes Message-ID: Date: Wed, 27 Feb 2019 21:48:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <095ee887-0fcf-a5ad-ef8e-435e4b812ed9@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 1/6] ethdev: add min/max MTU to device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 21:48:57 -0000 On 2/25/2019 7:40 AM, Andrew Rybchenko wrote: > On 2/20/19 6:57 PM, Ian Stokes wrote: >> From: Stephen Hemminger >> >> This addresses the usability issue raised by OVS at DPDK Userspace >> summit. It adds general min/max mtu into device info. For compatiablity, >> and to save space, it fits in a hole in existing structure. >> >> The initial version sets max mtu to normal Ethernet, it is up to >> PMD to set larger value if it supports Jumbo frames. >> >> Also remove the deprecation notice introduced in 18.11 regarding this >> change. >> >> Signed-off-by: Stephen Hemminger >> Signed-off-by: Ian Stokes >> --- > > [...] > >> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c >> index 0d192a24b..f089af94d 100644 >> --- a/lib/librte_ethdev/rte_ethdev.c >> +++ b/lib/librte_ethdev/rte_ethdev.c >> @@ -2527,6 +2527,8 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) >> dev_info->rx_desc_lim = lim; >> dev_info->tx_desc_lim = lim; >> dev_info->device = dev->device; >> + dev_info->min_mtu = ETHER_MIN_MTU; >> + dev_info->max_mtu = ETHER_MTU; > > I think it should be set to UINT16_MAX to avoid breakage of jumbo frame > support just after the patch. When all in tree drivers are updated, it > can be > set to ETHER_MTU, but it should in with UINT16_MAX value. > > with above issue fixed > Acked-by: Andrew Rybchenko > Thanks for the feedback Andrew, I've made the change and submitted a v1 of the series (link below), I've added your ack to this patch specifically in the series also if that's ok. http://mails.dpdk.org/archives/dev/2019-February/125319.html Thanks Ian