From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AAB33428FD;
	Sun,  9 Apr 2023 10:09:27 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 525B74067E;
	Sun,  9 Apr 2023 10:09:27 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id F1FF540141
 for <dev@dpdk.org>; Sun,  9 Apr 2023 10:09:25 +0200 (CEST)
Received: from [192.168.1.126] (unknown [188.242.181.57])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 0074262;
 Sun,  9 Apr 2023 11:09:24 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 0074262
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1681027765;
 bh=EJGKmfAB8volk0EJwbGvdhx/nFySN0W8R/CjLg7ZCWk=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=hkQR+M5CuSrcktK87fVrFQJDcxokOAeBkVER5ax0eNJTTXNEF2Buqa5o4pXZylVD/
 xa3mTeF8psWpa+oLHlFDdZ+mtJIUuTrtsjdgXCB46/rnwcMXXBPf8T3ilQ9QYKxLbD
 mFyQlD9sAKz5w50hLanFwtcyobAUwlue3f3fZF7c=
Message-ID: <be59fff0-57b5-6705-baa9-d715104f65ea@oktetlabs.ru>
Date: Sun, 9 Apr 2023 11:09:24 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 06/44] net/sfc: fix segment fault when parse devargs
Content-Language: en-US
To: Chengwen Feng <fengchengwen@huawei.com>, thomas@monjalon.net,
 ferruh.yigit@amd.com, Roman Zhukov <roman.zhukov@oktetlabs.ru>,
 Andrew Lee <andrewle@xilinx.com>,
 Robert Stonehouse <rstonehouse@solarflare.com>,
 Andy Moreton <amoreton@xilinx.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
References: <20230314124813.39521-1-fengchengwen@huawei.com>
 <20230320092110.37295-1-fengchengwen@huawei.com>
 <20230320092110.37295-7-fengchengwen@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20230320092110.37295-7-fengchengwen@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 3/20/23 12:20, Chengwen Feng wrote:
> The rte_kvargs_process() was used to parse KV pairs, it also supports
> to parse 'only keys' (e.g. socket_id) type. And the callback function
> parameter 'value' is NULL when parsed 'only keys'.
> 
> This patch fixes segment fault when parse input args with 'only keys'.
> 
> Fixes: 9e7fc8b8f3be ("net/sfc: add device parameter to choose FW variant")
> Fixes: c22d3c508e0c ("net/sfc: support parameter to choose performance profile")
> Fixes: 63d588ff2692 ("net/sfc: libefx-based driver stub")
> Fixes: df1bfde4ff0d ("net/sfc: factor out libefx-based Rx datapath")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>