DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ori Kam <orika@mellanox.com>, Dekel Peled <dekelp@mellanox.com>,
	"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
	"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
	"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation
Date: Wed, 21 Nov 2018 15:19:04 +0000	[thread overview]
Message-ID: <be62621b-ff6f-21e7-4d8b-14d36e32f70c@intel.com> (raw)
In-Reply-To: <AM4PR05MB3425E42B3C0AF4EF9E76B6BEDBD90@AM4PR05MB3425.eurprd05.prod.outlook.com>

On 11/20/2018 8:23 AM, Ori Kam wrote:
> 
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
>> Sent: Monday, November 19, 2018 6:55 PM
>> To: wenzhuo.lu@intel.com; jingjing.wu@intel.com;
>> bernard.iremonger@intel.com
>> Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Shahaf Shuler
>> <shahafs@mellanox.com>; Dekel Peled <dekelp@mellanox.com>
>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP encapsulation
>>
>> Set MPLS label value in appropriate location at mplsoudp_encap_conf,
>> so it is correctly copied to rte_flow_item_mpls.
>>
>> Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation")
>> Cc: orika@mellanox.com
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>> ---
>>  app/test-pmd/cmdline.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index 1275074..40e64cc 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -15804,10 +15804,10 @@ static void
>> cmd_set_mplsoudp_encap_parsed(void *parsed_result,
>>  	struct cmd_set_mplsoudp_encap_result *res = parsed_result;
>>  	union {
>>  		uint32_t mplsoudp_label;
>> -		uint8_t label[3];
>> +		uint8_t label[4];
>>  	} id = {
>>  		.mplsoudp_label =
>> -			rte_cpu_to_be_32(res->label) & RTE_BE32(0x00ffffff),
>> +			rte_cpu_to_be_32(res->label<<4) &
>> RTE_BE32(0x00ffffff),
>>  	};
>>
>>  	if (strcmp(res->mplsoudp, "mplsoudp_encap") == 0)
>> --
>> 1.8.3.1
> 
> Acked-by: Ori Kam <orika@mellanox.com>

Hi Ori, Dekel,

What is the scope of this patch? Briefly how critical it is and what will be
broken and what is exposure of it?

  reply	other threads:[~2018-11-21 15:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19 16:54 Dekel Peled
2018-11-20  8:23 ` Ori Kam
2018-11-21 15:19   ` Ferruh Yigit [this message]
2018-11-21 15:39     ` Ori Kam
2018-11-22  9:04 ` Adrien Mazarguil
2018-11-22  9:56   ` Dekel Peled
2018-11-22 10:14     ` Adrien Mazarguil
2018-11-22 16:18       ` Dekel Peled
2018-11-22 16:39         ` Ferruh Yigit
2018-12-04 13:51 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2018-12-04 21:23   ` Ori Kam
2018-12-06  8:17     ` Dekel Peled
2018-12-06  9:38       ` Ori Kam
2018-12-11 17:28         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be62621b-ff6f-21e7-4d8b-14d36e32f70c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=orika@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).