From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A07B2A0C50; Wed, 21 Jul 2021 14:40:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E6904014D; Wed, 21 Jul 2021 14:40:10 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 3C1BD40143 for ; Wed, 21 Jul 2021 14:40:08 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10051"; a="198696047" X-IronPort-AV: E=Sophos;i="5.84,258,1620716400"; d="scan'208";a="198696047" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2021 05:40:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,258,1620716400"; d="scan'208";a="662100309" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 21 Jul 2021 05:40:06 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 21 Jul 2021 05:40:06 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 21 Jul 2021 05:40:05 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 21 Jul 2021 05:40:05 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 21 Jul 2021 05:40:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GAUSwpaFy3nLWbX3D42px+qXlvFFgJXtC+7yU7hKDV+T9EspsBe1/qCKOwKQ16tH9loNoXi7iFObOcvZQ4KjvQyDEjnf6Q2YVwefkB39kjBfTVXaTCl7ENJ/XXdKw0pv0aTkNpxakSuYXhvyggWlTTBJfv7B0aRV4W//2Vcq1sNcgY4nK/vnAm2DJTjtZMc4TYaKpOs0zHzcbklB4qI2luVXeUxdM3DyYT5Dw+Zs5GPbuDcJvrwTFdiQrnL/DtE6cwy7Vg2v8B42CD8su2i4Nh1dgT3Ec3+HRqirDuu/QlgdKx8TmmgFuFb8PPEmNU7TEPnKlHd18iJre06G1te7fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a2sxa7y9QS0zbODDqF5s/r+App1gUx2FnJm1unwqdGI=; b=bKR2LhnyjCJkjtJiLrBMOc1L4eC5Czdd8bj7YByvIVoP+nJbIVvZSNfHYzK7HB0gL088eK5QCk4bPRo6iXG39qb5N58x4OeQtuPNSTBEqNhAlFheMCml3ojMhbWiE9+E3Ok4GyNzTO/MEGLSJjRrSQLdtEuhBodEpsPvT6JguWjg1iEX0qiqQLB7hm1aSiLOVHHpNYhwhSzsCJdoLx2zmjvHUs+gnsP9My6nH9Y+y3zSuiozH6T8xKWj/nK5cdBVui+Av7Lee2PVG4i6NwpuOUsPuCHQKiYagz8bzThEYzXWsgDsMkg/yPBaqSQ6ojJ2QRaHyETOh8hU2V/395ZMaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a2sxa7y9QS0zbODDqF5s/r+App1gUx2FnJm1unwqdGI=; b=o6NYoMJwmgT0htWcgxSQYs6l0RfDBWUvz8w7mkr3T+6kHdUAb2/KAbd/FzmBk+BDlXbEZgSabDtgdlVbSp37m7k4eIocq5o4KMaynYvFW0Ahkij4n8k9c1dOWZteop8qfaBxSWJB4M2wlgM7siXBgReiSjUkF/wem+3pBqbgK54= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by SJ0PR11MB5165.namprd11.prod.outlook.com (2603:10b6:a03:2ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24; Wed, 21 Jul 2021 12:39:55 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::a018:c8bc:f54e:514c]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::a018:c8bc:f54e:514c%7]) with mapi id 15.20.4331.034; Wed, 21 Jul 2021 12:39:55 +0000 To: Andrew Rybchenko , Jerin Jacob , Xiaoyun Li , Ajit Khaparde , Somnath Kotur , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , "Chas Williams" , "Min Hu (Connor)" , "Nithin Dabilpuram" , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , "Marcin Wojtas" , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Yisen Zhuang" , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , "Zyta Szpak" , Liron Himi , Heinrich Kuhn , Harman Kalra , "Nalla Pradeep" , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Maciej Czekaj , Jiawen Wu , Jian Wang , "Maxime Coquelin" , Chenbo Xia , Yong Wang , Konstantin Ananyev , Radu Nicolau , "Akhil Goyal" , David Hunt , John McNamara , Thomas Monjalon CC: References: <20210709172923.3369846-1-ferruh.yigit@intel.com> <20210709172923.3369846-4-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 21 Jul 2021 13:39:38 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0136.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::15) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0136.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Wed, 21 Jul 2021 12:39:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1f06172-7ff4-4bc7-cbdc-08d94c44a4b5 X-MS-TrafficTypeDiagnostic: SJ0PR11MB5165: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h+NNOZ/4FcTdIZ3EoAituylHF+7vuuRdKGfW1UKE2SZN5Hv73SQiHqWnt9mr/p7d6ugqI0RnHmG756YijmV04BnA40QU928AYYF3SKGeD3NSqx6XS6/H6kqWIj2O8w+UzeUdJJu3gR4d9c/WjyGqADde0LNgHP/d5yHPLQoSp/D8Cy85fYcJB1/8eMkXRpXLi7N8Zm3kHNAfwqi4MtmtDqIYQ5Gb2YYrXf/1RC+Jqw64w/GnnBiGjgzcatl4CrBza3CGn59i3JKTX09N+UgaWMPI4sgfFtGQXPOBpvIZEKosjUYDa6gAQxaKCg9HeD8u3ZXl3Yag6Szy/Ptvt29oM7YU7RDzb/cq9wq72d3IbD0hJFj9gET7N0o7MWscgIIPPSM95hqIYtwe3PuYoQBf4Z3ryS5FPzqmOSYEUhb5z8+Fxj/EJ2bBprLlDlYO+DHfFQiK0Q3a8EJkZBp63yaskVQFNa+HKgnggTC+tZZ6l56Sz9UIK2Nm2NOD2/q0Gn9nwdbUfKnEaj/GX1g1jYwvB0lv6bOqeKkDoZOMT0hpIe8WB14LDsXot1BxC6A/H1lBQ9/qwyl55yHEMHYdn9+eIBGhqz0d0IiUuluzG7iQ4xBw6oIe9qZgSAvGMa5Ypj1zfYjKKX0ofwEXmd/rsCu6Y5pRIfcG8iJ2rEEvInxwCgDwNdaSrxQh8F7R7hfbFgNP/7S4HohK6Jlk/YGfk2lYPMj+uf8w+Eti4UuznerPRO0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(136003)(366004)(376002)(346002)(2906002)(36756003)(4326008)(66556008)(66476007)(66946007)(44832011)(186003)(86362001)(8936002)(6486002)(31696002)(26005)(4744005)(5660300002)(53546011)(956004)(2616005)(1191002)(16576012)(110136005)(478600001)(6666004)(316002)(7406005)(7366002)(7416002)(31686004)(38100700002)(921005)(8676002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFlwWXBSSCtyOVpWcTZIREtqMmdqRXA2eGo1SVRsRlI4Tm5DdXR3ZkJBb0NM?= =?utf-8?B?bGxrN2ovTlJDdks2WTczNUlOdjZyNHM2Mi9leGxSbmo3RlFxYWQvdlJncFNo?= =?utf-8?B?QmFWTUU1Q1ZxMklWeE5vUEVCdktqTXlVS09PQmszU25wQnM5OFV4ckRrc281?= =?utf-8?B?Wnh3YVVlVGNSYTlIRlpic2FmTEtraXhnYVhETHlBSUs1bDF4dzJRLy9jTDNZ?= =?utf-8?B?ZEhwdmJmc1pCM1RNNSt6RngyK0dvTFpMUUxOemJKaktoTldLdW5wQmtlZFJi?= =?utf-8?B?SHZQZUtNNmhvU2JpaVhDS1MwUVhjenJhMVZuckt1OFlPMXVjN3UvWE1OcGdi?= =?utf-8?B?eW5OUzV6RTZoMTR5dDJYb3luNDk4UGxQT0JmUVRiemNVbU01d29iU3VtRjFD?= =?utf-8?B?bVY4YkFGdm5SMWoxa2wraXFCcVZHdXNwNUFLR0dZNnZBMEpOM0hBNzJHcC94?= =?utf-8?B?c3V3T290cWpTVzlUQWx1QmszS1U3dzVVeTZCZzc2eHVGbitOYWY5NVhyclR5?= =?utf-8?B?YW40dlFkcWRXeEVSb2psZ1lFYzVBM21wRkh2Ny93ME1MUXVvUkFwSTN4UUhi?= =?utf-8?B?NHNKOXJJVHpud2oyQmc2Vko3UTNDeUhhTkxYK1VGdkI4WVN2cHFKUnBLQkhI?= =?utf-8?B?R2w0aUMwaEVVOEJVaVV6SUJvcUplU25rZmE2TUVlT1hDVzlqeXlZZitmZExw?= =?utf-8?B?WHRaZ2tNU3pEcjA0MFFSOStzektzc1ZpWXhoV0VxeW15ekEvNUVHempKWTNo?= =?utf-8?B?TU9zUXhxOFp4b0hnMncydUtKOEg4aEcvamk3M0JjaGVhQ0NzZjFTTE5TT2Yx?= =?utf-8?B?QUttUTJlTDRmY0tQY1dTSDd5S3dIOWpjay9MaEhOTjBra3dnNXduSEdqQ1h3?= =?utf-8?B?eVg4ekpxcVl1QzRBQkpBSkt1b3N4SFVCaWFUMGJoL3k2UkpxV0pNQm1XSlg0?= =?utf-8?B?M252T3UvR2RkOVlFMVpCdEM2dzU3dHpoakFvZVoxYjNvR0pvbWdCNFg1R2Z6?= =?utf-8?B?a2N5S041Q3VLTU1Sei9ReCtWQUFHUWVMemVXaHdjUXRFNWVnKysrZHNXN3hq?= =?utf-8?B?eldVYkdGRGZQQU52dTY5Wlkrak1WMFA4UHg0dDl5VGdPRnZkcldWUndNdlNr?= =?utf-8?B?MEwyeVMydVBvTDJyOG9selUwdFRVT1EyYVc4Q0pueDI0UUJFQjIwclpDK1N6?= =?utf-8?B?b0F6OVNrTVp3a1lQMFBrRWxRUktGNXY0STBwaVo1VzFhcDgrWUlSWmRoU2Zh?= =?utf-8?B?dWpRNTg1V2tRVUtoYlBGcWQ1cTM2L282Z21sejIyYmJKYUN1K2xUQlFVYThI?= =?utf-8?B?Y05KOStVeDg0eitkVU8zQTIzMHZpM21VSUN2b2FxK1lyZzhZU1BHU1U0TnhE?= =?utf-8?B?S1VqaTZvVWRtL3J6T2hRdXgzZDF5MExkZzkrWmFQZERET3RNQzBoZFM2a01D?= =?utf-8?B?NFptQmdzOU11UWFVcmUzdGZUcHd0aTQvWm1XOHJSTlV0aUZaUnJpNUFvVVRR?= =?utf-8?B?dmRxU1kyS1B1NHFlQVNSWldmQzJ0Tmp6SE9Xb2NvS3laV1dQZG1FcDEyUHVH?= =?utf-8?B?d2lwYUxJV1c0VkdmNE81OGNST3Q1aWk4Z1FhU1gxZHZkNUwySldHbm96Kzc3?= =?utf-8?B?d0pLY3NwVTlwNUNVa3JvRk5sS0lEMUg5aklkUnRDNWc2bVliQy83dHA3MU5i?= =?utf-8?B?eE1kSmhSSzFhTlBCeEVjeHIxWVZWdEVwMkNYMkxDV2RrTVVLcWlVb3dENDNK?= =?utf-8?Q?QytIOGaAG7Il2nfLPXmODd0CBAWIE78boVxnugh?= X-MS-Exchange-CrossTenant-Network-Message-Id: f1f06172-7ff4-4bc7-cbdc-08d94c44a4b5 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2021 12:39:55.7527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: quh9DxaijA1XT0dzIMtqrsykHaiUIOTaiVUo9EKTy+Qmv2qj9x6dVzuyGLXBUr7dtyx+F0FoVl/dt7qXWQJ30g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5165 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: remove jumbo offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/13/2021 3:07 PM, Andrew Rybchenko wrote: <...> > >> diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h >> index 3b4d9c3ee6f4..1ae78fe71f02 100644 >> --- a/drivers/net/e1000/e1000_ethdev.h >> +++ b/drivers/net/e1000/e1000_ethdev.h >> @@ -468,8 +468,8 @@ void eth_em_rx_queue_release(void *rxq); >> void em_dev_clear_queues(struct rte_eth_dev *dev); >> void em_dev_free_queues(struct rte_eth_dev *dev); >> >> -uint64_t em_get_rx_port_offloads_capa(struct rte_eth_dev *dev); >> -uint64_t em_get_rx_queue_offloads_capa(struct rte_eth_dev *dev); >> +uint64_t em_get_rx_port_offloads_capa(void); >> +uint64_t em_get_rx_queue_offloads_capa(void); > > I'm not sure that it is a step in right direction. > May be it is better to keep dev unused. > net/e1000 maintainers should decide. > It is possible to keep dev as unused, but these are driver internal functions and 'dev' is not used now, when it is needed it is easy to add it back.