From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4392C2BAE for ; Mon, 11 Dec 2017 20:00:12 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 11:00:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="10998319" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.161]) ([10.241.225.161]) by FMSMGA003.fm.intel.com with ESMTP; 11 Dec 2017 11:00:09 -0800 To: Amr Mokhtar , dev@dpdk.org Cc: thomas@monjalon.net, anatoly.burakov@intel.com, pablo.de.lara.guarch@intel.com, niall.power@intel.com, chris.macnamara@intel.com References: <1512682857-79467-1-git-send-email-amr.mokhtar@intel.com> <1512682857-79467-2-git-send-email-amr.mokhtar@intel.com> From: Ferruh Yigit Message-ID: Date: Mon, 11 Dec 2017 11:00:08 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512682857-79467-2-git-send-email-amr.mokhtar@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 2/5] bbdev: PMD drivers (null/turbo_sw) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 19:00:12 -0000 On 12/7/2017 1:40 PM, Amr Mokhtar wrote: > - bbdev 'null' PMD enabled by default > - bbdev 'turbo_sw' PMD disabled by default Can you please separate PMDs into their own patches. > - 'turbo_sw' requires the external FLEXRAN SDK libraries > > Signed-off-by: Amr Mokhtar <...> > +static const struct rte_bbdev_ops pmd_ops = { > + .setup_queues = NULL, > + .intr_enable = NULL, > + .start = NULL, > + .stop = NULL, > + .close = NULL, No need to set NULL ones. <...> > +RTE_PMD_REGISTER_VDEV(DRIVER_NAME, bbdev_null_pmd_drv); > +RTE_PMD_REGISTER_ALIAS(DRIVER_NAME, bbdev_null_pmd); No need to add ALIAS macro, it is for backward compatibility. > +RTE_PMD_REGISTER_PARAM_STRING(DRIVER_NAME, > + BBDEV_NULL_MAX_NB_QUEUES_ARG"= " > + BBDEV_NULL_SOCKET_ID_ARG"="); > + > +int bbdev_logtype; > +RTE_INIT(null_bbdev_init_log); > +static void > +null_bbdev_init_log(void) > +{ > + bbdev_logtype = rte_log_register("pmd.null_bbdev"); What about two layer hierarchy in logtype name, "pmd.bbdev.null" ? <...>