From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89729A09E4; Thu, 28 Jan 2021 23:32:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0263B40682; Thu, 28 Jan 2021 23:32:35 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id DA1EB4067A for ; Thu, 28 Jan 2021 23:32:33 +0100 (CET) IronPort-SDR: ClK2n8oSOcAVXK0gi1wSEyrfryZq6N6uo20TjBDEQiiDKT1l2DrxJdAG5xAGHbQZhhRpfefq+m 1K8VysH/mLQg== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="159498212" X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="159498212" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 14:32:31 -0800 IronPort-SDR: OMYSFXPvJJPernRCa37lfa9UbnLYrUufGZp6up46raQC662rYJAPy+6Nsp6onV3qUDDgs+TtdK qZnI3ajyaXiA== X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="389027759" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.127]) ([10.213.197.127]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 14:32:30 -0800 To: Jiawei Wang , viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net Cc: dev@dpdk.org References: <1611632982-415500-1-git-send-email-jiaweiw@nvidia.com> From: Ferruh Yigit Message-ID: Date: Thu, 28 Jan 2021 22:32:26 +0000 MIME-Version: 1.0 In-Reply-To: <1611632982-415500-1-git-send-email-jiaweiw@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix the sample RSS issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/26/2021 3:49 AM, Jiawei Wang wrote: > When the RSS with null key was set in sample actions list, it > caused the segmentation fault since the RSS key pointer was > NULL while did the memory copy. > > This patch adds the RSS key NULL pointer checking before copying > to fix the segmentation fault issue. > > Fixes: 11b1b0eddade ("app/testpmd: support RSS in sample action") > > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.