From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E79B42DD4; Tue, 4 Jul 2023 14:01:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B9B440E03; Tue, 4 Jul 2023 14:01:50 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 5D72A40042 for ; Tue, 4 Jul 2023 14:01:49 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id F310C1F3BA for ; Tue, 4 Jul 2023 14:01:48 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id F17561F2B2; Tue, 4 Jul 2023 14:01:48 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED, AWL, NICE_REPLY_A, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.6 X-Spam-Score: -1.5 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id C0F2D1F3B9; Tue, 4 Jul 2023 14:01:47 +0200 (CEST) Message-ID: Date: Tue, 4 Jul 2023 14:01:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC] eventdev: remove single-event enqueue operation To: Jerin Jacob , =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Cc: jerinj@marvell.com, dev@dpdk.org, Pavan Nikhilesh , Timothy McDaniel , Hemant Agrawal , Sachin Saxena , Harry van Haaren , Liang Ma , Peter Mccarthy References: <20230609174205.150027-1-mattias.ronnblom@ericsson.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023-06-30 06:37, Jerin Jacob wrote: > On Fri, Jun 9, 2023 at 11:18 PM Mattias Rönnblom > wrote: >> >> Eliminate non-burst enqueue operation from Eventdev. >> >> The effect of this change is to reduce Eventdev code complexity >> somewhat and slightly improve performance. >> >> The single-event enqueue shortcut provided a very minor performance >> advantage in some situations (e.g., with a compile time-constant burst >> size of '1'), but would in other situations cause a noticeable >> performance penalty (e.g., rte_event_enqueue_forward_burst() with run >> time-variable burst sizes varying between '1' and larger burst sizes). >> >> Signed-off-by: Mattias Rönnblom > >> >> -typedef uint16_t (*event_enqueue_t)(void *port, const struct rte_event *ev); >> -/**< @internal Enqueue event on port of a device */ >> - >> typedef uint16_t (*event_enqueue_burst_t)(void *port, >> const struct rte_event ev[], >> uint16_t nb_events); >> @@ -45,8 +42,6 @@ typedef uint16_t (*event_crypto_adapter_enqueue_t)(void *port, >> struct rte_event_fp_ops { >> void **data; >> /**< points to array of internal port data pointers */ >> - event_enqueue_t enqueue; >> - /**< PMD enqueue function. */ > > Can we remove "dequeue" as well? Seems likely, but I have no data on that option. > In any event, Please send a deprecation notice as it is an ABI change, > and we need to get merge the deprecation notice patch for v23.07. > I can review the deprecation notice patch quickly as soon as you send > it to make forward progress. > OK. > >> event_enqueue_burst_t enqueue_burst; >> /**< PMD enqueue burst function. */ >> event_enqueue_burst_t enqueue_new_burst; >> @@ -65,7 +60,7 @@ struct rte_event_fp_ops { >> /**< PMD Tx adapter enqueue same destination function. */ >> event_crypto_adapter_enqueue_t ca_enqueue; >> /**< PMD Crypto adapter enqueue function. */ >> - uintptr_t reserved[6]; >> + uintptr_t reserved[7]; >> } __rte_cache_aligned; >>