From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CC74A0542; Tue, 6 Sep 2022 11:35:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1851B40143; Tue, 6 Sep 2022 11:35:13 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2072.outbound.protection.outlook.com [40.107.100.72]) by mails.dpdk.org (Postfix) with ESMTP id D265A400D6 for ; Tue, 6 Sep 2022 11:35:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MX3p8gtnxoRVvIxNx/t4Ws6sC0F/m4Sz8WXCzkaJGpS7SVOcNBpZ5fpaz0oipRcFjbArtRQ8a4PvksATvr09pqq81mSHonfQwX6dL9/TajAqEz5dURw8sK9BthTd/clW26byKSNS5bhEf9kDI0RTRQLqiEA8Ou7+lybYZiDd5iIp8sISQhemlSUdohs2f22a616hhdj6xpgce/29x1nXivgRkwYanARexC9bHlnCzl3c/rTHtVh1VXvscw49fPmhWydOL7v+KKc+yicYecWRq2y0hZqvpYPfrMIca9AtzZZ5fEWVLUtQFxqUu1kqrPBSQXNFCIYmk8CVNhwuricelQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3w8Z0NnPZDuYNJQtzHmVDxHYNqr0PjAHy3C7Ub0A538=; b=INR4H0+dO2sX8HZwISWgStMpQXbzmlhRXOo3FUWKFPDR5FEj3ZoKChe9dQ26Vy70vVpZI6A/hNmSpSti2+xMstd+GrzpHS7hnsL8H/Fbsft/Ycc9PHU5UJhKMYqjOQcRsW7Uw+BAUdliWEI9hTW8sqpVT7HnPeG+1hZtRPqOspWLC2pYJ4RmdloKuzGA0BYEEG36Z2dKt3ryoqZNg9u2288XRSTt7eJi2veypn6EkpIn8ikgVHqvMeiU9zA/zw/R70Q8zXNbrvk+b5J2J5m7I3ocDm0MLRQk4NY4DTBgxHN+qf3RPE5GB6tNicPKEvF14D4njvLEsHUhCh9BHUVcDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3w8Z0NnPZDuYNJQtzHmVDxHYNqr0PjAHy3C7Ub0A538=; b=OpwA5GRrL+ygHn97b8VyzODV2dTVxzrd1IpS/JjAOA5ljDgx/NeNmCkVgMxOBFEWbLvC2xbZ3TUmJNszR80SPOVI0VebBQZjYcqK/bve9f10M5EEth8DnVmG47AprTpwVHwg9JgqTmDuaHarjhwXsgNvcuBRy/yzB//EQYhYrUM= Received: from DS7PR05CA0104.namprd05.prod.outlook.com (2603:10b6:8:56::16) by SA0PR02MB7418.namprd02.prod.outlook.com (2603:10b6:806:e0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Tue, 6 Sep 2022 09:35:10 +0000 Received: from DM3NAM02FT025.eop-nam02.prod.protection.outlook.com (2603:10b6:8:56:cafe::87) by DS7PR05CA0104.outlook.office365.com (2603:10b6:8:56::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.5 via Frontend Transport; Tue, 6 Sep 2022 09:35:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT025.mail.protection.outlook.com (10.13.4.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 09:35:09 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 6 Sep 2022 10:35:08 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Tue, 6 Sep 2022 10:35:08 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com Received: from [10.71.194.74] (port=57208) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oVUz6-0002IE-BG; Tue, 06 Sep 2022 10:35:08 +0100 Message-ID: Date: Tue, 6 Sep 2022 10:35:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 01/12] net/nfp: move app specific attributes to own struct Content-Language: en-US To: Chaoyong He , "dev@dpdk.org" CC: oss-drivers , Niklas Soderlund References: <1660299750-10668-1-git-send-email-chaoyong.he@corigine.com> <1660299750-10668-2-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c92e5248-05f6-4940-7e91-08da8feb1775 X-MS-TrafficTypeDiagnostic: SA0PR02MB7418:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 94w2FV3+5AHLbU+3Yid9E0+LXNQ4zJZdxwuF4bG7la6WNcTmRnxMv6HmFDDV1EKXH+30g0rMmguI2Mrh+EbFCSxcS57r23dpP4S1kXQ7oUzfmZtjOPZ8nAfhlDDvyMWS+bM94v4H22O0IPs9AyV9LXGZbSulTo/hu8EYLB6X3feZjHEm1MUraJkQQhrtvKvB1la8gyrtEgri9yts8g7pEIcXkhMpn41/fKMAKjRSyYQWTrP0qVf7I7Y2HPRrIrvqXXPu8vMWYcst1cnkIS9QWMnmZ/oN0ZbIz05G7gVNeKDNRmqtezlnL8EE00CBr5rir74xPIqRF/7p4fygMO44+F8lpE00SBC9qm1B+Wd4rLrqHNCK0O6qm30ScMFOhG7nGiK47dqDcq8EKv4ttXlleOzloL8aZz4mJJ8y7YyT9wKs2gIhNcGp9RovNrvAv3JDUcG3fez/B3wUH2e4bMuCMqzZkMmebmpr+L/ZkzTcTCEFeNDdS7A60DttvbOg1zikBaLS98shRZgoihd3J2z0dXWp9yPMDNO9Z4Zcs9oY25HUawDXtbqDGR6u3uEp76DX+AUdtFEwLJZmHQiLFpftAG2uB5Y86sLilaVm7/DALWjiLhpHJJIKbuIFNuMAM8nFsAkT8NtQfNlPL+fQLGt3/lHOj0vVHHak6bk9fprtbW3mL/itmGBypgmFGN7+yyX2oDhDaaw0CwuhV8Z1811qF3xvs8uvYLROVWVe1RzTod6ztBV44Tjf4EM4TSaI7JoijiJIiYbUaleU0Jo4dGEQ5A+qDp2p+qe9RqnP3X5TkG12aayXKTxNiKYgdjw3uVN7+T5YFe4/QnRdXxnz8jLMew== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(346002)(136003)(39860400002)(46966006)(36840700001)(40470700004)(36860700001)(41300700001)(5660300002)(66574015)(54906003)(316002)(26005)(47076005)(31696002)(2906002)(53546011)(110136005)(426003)(40480700001)(40460700003)(44832011)(186003)(70586007)(2616005)(82310400005)(7636003)(336012)(82740400003)(8676002)(356005)(4326008)(83380400001)(478600001)(31686004)(70206006)(36756003)(9786002)(8936002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 09:35:09.7821 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c92e5248-05f6-4940-7e91-08da8feb1775 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT025.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR02MB7418 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/6/2022 10:20 AM, Chaoyong He wrote: > >> From: Ferruh Yigit >> Sent: Monday, September 5, 2022 11:38 PM >> To: Chaoyong He ; dev@dpdk.org >> Cc: oss-drivers ; Niklas Soderlund >> ; Heinrich Kuhn >> >> Subject: Re: [PATCH v7 01/12] net/nfp: move app specific attributes to own >> struct >> >> On 8/12/2022 11:22 AM, Chaoyong He wrote: >>> The NFP Card can load different firmware applications. Currently only >>> the CoreNIC application is supported. This commit makes needed >>> infrastructure changes in order to support other firmware applications >>> too. >>> >> >> App (or firmware application) is a little confusing, why not just call it FW? >> >> Same for code variable/struct names, and other patches. > > We decided to not just use "FW", as this is an overloaded term for the NFP. > There is also the lower-level management FW, which is flashed to the card and > is mostly separate to the application firmware, although they do interact with > each other. > The application firmware is the software (application) that runs on the card's flow > processors, is loaded during run time, and determines the behavior of the card. > To avoid confusion with the different types of firmware we decided to call this > the app_firmware - this is also similar to what is happening in the nfp kernel driver. > > To avoid further confuse, we will change the places where just use "app" to be "app_fw" instead. > OK to 'app_fw' >>> Clearer separation is made between the PF device and any application >>> specific concepts. The PF struct is now generic regardless of the >>> application loaded. A new struct is also made for the CoreNIC >>> application. Future additions to support other applications should >>> also add an applications specific struct. >>> >>> Signed-off-by: Chaoyong He >>> Signed-off-by: Heinrich Kuhn >>> Reviewed-by: Niklas Söderlund >