From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E36C4201; Mon, 12 Nov 2018 10:18:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2018 01:18:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,494,1534834800"; d="scan'208";a="99535302" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.9.8]) ([10.252.9.8]) by orsmga003.jf.intel.com with ESMTP; 12 Nov 2018 01:18:15 -0800 To: Rami Rosen Cc: Ferruh Yigit , dev@dpdk.org, john.mcnamara@intel.com, stable@dpdk.org References: <9e7f9bd5-b71b-4758-133e-16b1c8e6abbe@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Mon, 12 Nov 2018 09:18:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 09:18:18 -0000 On 10-Nov-18 11:03 AM, Rami Rosen wrote: > HI Anatoly, > >> Do all other distros have lspci in package called pciutils? If not, i >> prefer to keep it the way it is. > > Your original patch have: > > + if ret != 0: > + print("'lspci' not found - please install 'lspci'") > > And I suggest to consider changing it to: > > >> + if ret != 0: > >> + print("'lspci' not found - please install pciutils') >> > > Sorry about my ignorance: which distro has a package named "lspci", if at all? > > The official project that include the lspci utility is called > "pciutils": see: http://mj.ucw.cz/sw/pciutils/ > You can see that a package named "pciutils" is available in great many > distros, like: > Fedora, OpenSuSE, CentOS, RHEL, Ubuntu, Debian, Mandriva and Mageia, > according to the following links: > > http://www.rpmfind.net/linux/rpm2html/search.php?query=pciutils&submit=Search+... > https://packages.ubuntu.com/trusty/pciutils > https://packages.debian.org/search?keywords=pciutils > https://rpms.remirepo.net/rpmphp/zoom.php?rpm=pciutils > > Regards, > Rami Rosen > Hi, Thanks, that's good to know, will fix in v2. -- Thanks, Anatoly