From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA10D43279; Fri, 3 Nov 2023 14:23:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF18B4027F; Fri, 3 Nov 2023 14:23:47 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2087.outbound.protection.outlook.com [40.107.237.87]) by mails.dpdk.org (Postfix) with ESMTP id 4225E40273 for ; Fri, 3 Nov 2023 14:23:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cUingjub50PDzJVVcDXcUidHdEnxo+683WuPSbVJFGAOxqd4Fcb/KtDST+4mk5DL5hyRkPsFta/ymNCUxR+kfNybnE1p5PUPPLUM8mKPBKizZoCGVmh1yXBR/JjHFAz9d8JFK/NU4rU7F/pE84Kirigjt5483QoMpTiYqsdVmPyWBb5VhDff95KevBUxCTr04H84Xa+DP6IS04ymtMR8bp+Sz5e93EPGqpED9Wlff3PAlI7M81DTz47laM/XTrQDGwgvdKOSSXmZudUbKVgX/ds8Zr1ELMlsFAGn609/CiNCNPO2GOzh7vZWTpGBu9LiUWBeRIqfNn/49Iy5z9NNFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHfMiQfKEnI7Y8n62RTaAZHBC1yiL+1WhSB/ba5i+I4=; b=ij7d/2pPWSIBwrhj4vcIgHbId5lNgCsqzIJFn+26wkMLrLZhE5Mju4henZO1sImsy5VfOS1xnuXhI45v5mc8IRqVOqhKGXUHHlmrxHx04Rw9NmUoNhDKnfEgWM82kXJoUotK+H8H0jcOSqfYmaKmnOKeWVdgwpiH2yN9YE2fcmgg1e4DdUTLWD4ACJXLRIpAZyTGLJAMdBmsnY6Ha39tqzWUP1Pl5bIZY+tkRZ/r7cGTvHi/PcgRQkfIqXuwgzb/bcr/YrYy1obDgmnpy9a6Ngtv5CuimfckNiTFwEhefe3r3Lgmwtvbv3UCG1gJ8TBT4Idyv6jppqY2K3cO4PbX9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vHfMiQfKEnI7Y8n62RTaAZHBC1yiL+1WhSB/ba5i+I4=; b=LWvjK7Yg3gpE3T/kbzJEJhXD8rWy7MH4s9Ct0tCmbMeV3/e/9gePPqoPdR2yBh9JeP5e6K9N2Wv8Q9CzIAvOVbvtLhqC2Q7OhQN8b1DrNMDaB3FPjMnKrS/33sBfiHIMGQ9bcOsp4JT/21Ylxxw4146Xp3NfFUDvuC97/sTVTQE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4213.namprd12.prod.outlook.com (2603:10b6:610:a4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 13:23:44 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.019; Fri, 3 Nov 2023 13:23:44 +0000 Message-ID: Date: Fri, 3 Nov 2023 13:23:33 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] net/sfc: use new API to parse kvargs Content-Language: en-US To: Chengwen Feng , thomas@monjalon.net, Andrew Rybchenko Cc: dev@dpdk.org, stephen@networkplumber.org References: <20230314124813.39521-1-fengchengwen@huawei.com> <20231103073811.13196-1-fengchengwen@huawei.com> <20231103073811.13196-4-fengchengwen@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231103073811.13196-4-fengchengwen@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cb::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4213:EE_ X-MS-Office365-Filtering-Correlation-Id: e064d02b-1df3-4fe5-8e8d-08dbdc701a59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S1iDfZK7QFpXcAgjOMIrKLcQ0ovaJx53zj0gM2WlwpBuyHO7y1o1nO4laODUHzsVhqIYQpUNGN8AZ16m90gjglHvkKoVRppzsR+v+fVa6lwh1v/1F0Y7ZHUmhdsaOJg88xsRDjcJqYRRSy8IQX0fV0HrtJJz4GpNuHR1v3nbfw4Ty6bDlP7Ayc9Wz0t9yVRSD21k1gHh+6wFfHlj672oCGeXpuO0ApvdmRIHgjQhyUeDM50Scr9u7fjXqFWqWYyH01oXzRf0wFq445PcP/418jtIXKxAsh7GrMV4syPcc2qWjaFQxt8vxUdXTZoAKnj0HDgjhX0aCe4/Nqbt11kt5qbAKB7HEAJZ9nKaDXf6ZPUd5Pjb1K23otk4x1qI+JV+3+8HD1H4wN5ARKQk8ItPguLrrHcgPnQ/0n/MKP70n+jz2oH5tnHtJJsBCF0M5MfR2HVJQJs0D1OpsHYnhxLI0KuFXDl87cvod7n7URtoUIqL7WDKRXRGBBlw8B1Nsd/+VEiGTObQszeFpOSyIn23DdRRucZAgvdW2lEGhHVfmhOhJvMkDMEyVqqIi1pMCBKFNcwSYggNwYL+bIagLCeBUx3hGalH18hPUK5zgNFHSAMoJ0fd6dTzOu47ISACL+WqI5r2fOcu75Crg8yfJUi9rQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(366004)(346002)(136003)(396003)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(2616005)(26005)(6512007)(478600001)(6666004)(6506007)(2906002)(53546011)(83380400001)(44832011)(5660300002)(41300700001)(66946007)(110136005)(4326008)(66556008)(8936002)(8676002)(6486002)(66476007)(316002)(38100700002)(86362001)(31696002)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0ZDeTFSbWxJbElEUEVFTEg5ZkVqRGcxS0RmUGtXOEkySEZnK004RFVyQW54?= =?utf-8?B?MlcyeVMxa3FacThSQzljYldzbDI4dlgxbzh4NEJZdzJma0hOZExDWjkxdjBW?= =?utf-8?B?RGJOUFUvVUt4VHRpMW1FRTgxdXdUTmU4WmxsVVNxeWE5MWVMZGFqaFUxd3dv?= =?utf-8?B?WmgyUDJ4U29BWjFhRzN6ajc4T1U2K0MycHpCMzFldDg1VVJQL2hzSVM0SElj?= =?utf-8?B?WUFteXcwL1YrTllZeWoxeEZScWsrUkoydkJrSS9UMS81MTM0WUNXTHEycTRl?= =?utf-8?B?NGY2Y29LMjk5Nm9YQ3hzaVdPRVpna1NqVlNoWi9qdkl1Ymk4aDFqRTlic0t3?= =?utf-8?B?MHc0dURZS0pjRWlzZ3FsZjh6U3lnYXM5SFlrdDN4ZVJZb3F6RGZ1NjB1enR1?= =?utf-8?B?bWRWaTh5TmgycHhvRzRiai9sVThqV1RyTGgza0NlVEdIcytjVktZR21XOFNM?= =?utf-8?B?UkthRE5jenR4elJLYmFCMzFMbjZkdVZLRUpCUTg5S3Y0U3RHdWl3UzFaNHRi?= =?utf-8?B?aUlzNGVMREc2TjZPaThaOUF2OE1rQ3lQMHRrdlhnL0lPSjRtbEw5cnVaOWNq?= =?utf-8?B?S1BaTlMxUktwMjB0ZkcyWkdXUlE1eWxNdDhISUxIRzZzdCszOU54YkhWSHJQ?= =?utf-8?B?U2I3S0NjYmV4clU5WTVjd2tnQ2tnYjZMWXVyOUp2L3pPS1k3UGV2MHRmNG1p?= =?utf-8?B?NlFZbW4rWERkTXBleXV6VXpXYkpIditFU0puTnU5Z3RaaXlTU3VCR0NyWXZN?= =?utf-8?B?eXUzODRPWG1GSnpQc0xLTDMvSDk4d1F2am1obGVNWExJNjV2WDFjL2Z6QllQ?= =?utf-8?B?amt3V1dqSng2T1p2Tk5sVDNNV1BEdkVBNHlScjg5ak1YRzZtY29tenpvallE?= =?utf-8?B?UjJmMVQ4QldSNDFwM1BodmMrQW8weUVYVzl3QWxqQ1h5RjhrRmNZVXkzM1l6?= =?utf-8?B?MXRqL2c0ZHZzZnJLRkhHQXkzTjR6RGZ3OVFOZFVtSW5rM2c5ZHZ5clUreFJM?= =?utf-8?B?d2tqdTEweHJMeW14TTdsVmsrcythTGtKZDQrbHZ1RXoxL3NqWmpVaGhBVzZE?= =?utf-8?B?SndQcWhET3IxbUhNKzAyTml3ZXQ5NXpIK2kydDhzM0puQkNWam5FYWYwSXBa?= =?utf-8?B?akx1VzFOTTF3dXk4SzNRWXlkY01rR1BLSHY0cTVqOVVhZlB6WFlWZlpyU2Jt?= =?utf-8?B?b09rRmJKbXIxbFdFSFRFSzhzM2VYOENTV2dpelhHYVVsam40NnBpa0xpa1V1?= =?utf-8?B?aXRGYitlc1hYeUdHbnJwelRBMlNTZG5Ma3J5Ukd5MmRlT3VwZmJPZ0dFM0k4?= =?utf-8?B?eUNMZEFXR1hhcnpsTGhnb3NCMHpSdjg3d2pzZnd5RVJLbks5WnpBakVtT1NV?= =?utf-8?B?anQ5b205dzdKZ0ZDODRUYXBNbWhCNUZ1eHdmL2IrYldyMkFrZjhDbWZVRlhs?= =?utf-8?B?dzJlaEtBcitaaFpISTYrT3UxL1BrSDBKa0FCY2c3Y3RLa2xFY0hxSnAzUkF2?= =?utf-8?B?bzJFODZsYnpYMzhIMFRINmRGZG55M0E2NWhlWkVHMS8rcFhkS29PRUtkcDk0?= =?utf-8?B?UHZEMHdvV1NqbWw2K0lIWlRwL1M5K0JvOHdIbVc0U212dmtwYkl4bVEyTS9p?= =?utf-8?B?dGwwTGhJYjFVejl5bHptVUxlU3ZPaEdZdEIyME1YSGdvUm9ZMTVMcHlsQjhX?= =?utf-8?B?T2xxdG9sOHNBZVZ4bSs0eFhFTUpzMjF0ZXRremhwV2hFYXRrVXg1MDdSUjQv?= =?utf-8?B?Q1JEZ0J2N3NQRlBKazhCZkd2MVpONG5Kb1RKQUNjOTBVeUtCNHNydERaUnR3?= =?utf-8?B?QWtmV2VMNlNNUXJMK3Yxd2liNStZWWZMdTZaWWVXUE44eEFJWFdJeURKd3R6?= =?utf-8?B?azlZOVNnODVSdUZaVGY1b3BVLzBsekMzTEJhWUVaUC9kdlhibE1IeHB4ejkx?= =?utf-8?B?bkZkVURrQkxUZWdiZ2VySUtVQjZrRmRSNHIvcVMrYlhWMjUvaFJteTJtNHF2?= =?utf-8?B?M0JldnQ0a1diYy9yQmRZaEx3aVlLN0pYYWhDaEVuS3QvRUpjdksvU2pnSnY0?= =?utf-8?B?eW16SjhKdHRpcFFISU1sK2xxc0NaUWZKUDlmbVlHbDNRbkFKcGJVUEUwaGhG?= =?utf-8?Q?JvuJ5Gyio7JtkchzhJtjodz0V?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e064d02b-1df3-4fe5-8e8d-08dbdc701a59 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 13:23:44.1876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B4ra3IEVjb1494/7wju5J0RBp9ABiovxxzLrmXa6+ownVOl1hQwc7lqaijTp44Q4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4213 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/3/2023 7:38 AM, Chengwen Feng wrote: > The sfc_kvargs_process() and sfc_efx_dev_class_get() function could > handle both key=value and only-key, so they should use > rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. > > Signed-off-by: Chengwen Feng > --- > drivers/common/sfc_efx/sfc_efx.c | 4 ++-- > drivers/net/sfc/sfc_kvargs.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c > index 2dc5545760..3ebac909f1 100644 > --- a/drivers/common/sfc_efx/sfc_efx.c > +++ b/drivers/common/sfc_efx/sfc_efx.c > @@ -52,8 +52,8 @@ sfc_efx_dev_class_get(struct rte_devargs *devargs) > return dev_class; > > if (rte_kvargs_count(kvargs, RTE_DEVARGS_KEY_CLASS) != 0) { > - rte_kvargs_process(kvargs, RTE_DEVARGS_KEY_CLASS, > - sfc_efx_kvarg_dev_class_handler, &dev_class); > + rte_kvargs_process_opt(kvargs, RTE_DEVARGS_KEY_CLASS, > + sfc_efx_kvarg_dev_class_handler, &dev_class); > } > > rte_kvargs_free(kvargs); > diff --git a/drivers/net/sfc/sfc_kvargs.c b/drivers/net/sfc/sfc_kvargs.c > index 783cb43ae6..24bb896179 100644 > --- a/drivers/net/sfc/sfc_kvargs.c > +++ b/drivers/net/sfc/sfc_kvargs.c > @@ -70,7 +70,7 @@ sfc_kvargs_process(struct sfc_adapter *sa, const char *key_match, > if (sa->kvargs == NULL) > return 0; > > - return -rte_kvargs_process(sa->kvargs, key_match, handler, opaque_arg); > + return -rte_kvargs_process_opt(sa->kvargs, key_match, handler, opaque_arg); > } > > int looks good to me