From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA326A0C41; Wed, 15 Sep 2021 18:48:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B55A44068F; Wed, 15 Sep 2021 18:48:51 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0BE7F4014F for ; Wed, 15 Sep 2021 18:48:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="219191881" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="219191881" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:48:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="482411682" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga008.jf.intel.com with ESMTP; 15 Sep 2021 09:48:48 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:48:48 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 09:48:48 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 09:48:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d8NUTt9/NS3lyy1VIp74GllAva0Yb2ULYIYOM0EA2w0mOALze0NEg37nzBaYYEfdzflgKBCOZ5qWCyFjYbwW3iDYfuOcgA86Q4WknhYZVTRTXnuAjLmQMN6wNd+09y7urMohNKRMlMSk50Xh4t+yhzlv9Oaa2YAdX0w0bOyTPXxMdVco7aUS4c/MgKd7bBJX1bn35X5xCnd8UQVV3s7FP31MiCqbJ2knc14Hkabxembg2HdIwy6ZATT1q6TUi/rHS6BAXHxf3th6Llf0cp25OlM2D8xTolPaE6afWthvWcUq0NbXG9i6H5h7vMYeaAkf8XKVIFv/zYvrpY0g6E2pdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Es9YYnlWtPNlBUy8S9r+vuoqAsLjwtcTrhgu4KTzw8I=; b=neVi4cL22pgkh487F6Qb7WP2qVCivriSAks9VtGAiRZs/aLVyTmGHA9bN/f0WI3FV5KCtiR9ukxyZZN4l1ySKPDn4RiQFVfQJH2c1ceK5O6K8StkkO7FAogQs1ulhUXpttLqEUG20/LgVlx6PBEJn7A+mbd4WZmgdLJJ0tY3SfAW15YkQCm7WsjFLVZ/XnxHrTulAGzyE8udcBxp2RPREdY+IS29FqYP9c1GwueS/mKRnqmN58lEhUVNzbKC0W60aTaED8O2+4UiA7D+Sc7KZHBT0gqutvhLXoQ09w9hzJ9ajfnn7QhhOq7mAEbHM0Ku42tXu+FeC5kYA9dJ8r+FjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Es9YYnlWtPNlBUy8S9r+vuoqAsLjwtcTrhgu4KTzw8I=; b=jgBCmhWL+LoSKVDgDuA6fNHuyEWlGYavM3vOR/dhEh95z90Ts7eHR9KwQa8pZjtYdnlR/KanSqVy6knJEN6CXNzaKOwV/xbNAjPrHVaYFQdJrb7iT7CTlEAXAMkcOkHCJH77A+p0pUfZ0nMMjv/I3X4Ym2Lyj4C7xiQCPBeJsZc= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5112.namprd11.prod.outlook.com (2603:10b6:510:3b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Wed, 15 Sep 2021 16:48:41 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 16:48:41 +0000 To: Jiawen Wu , References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-6-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 15 Sep 2021 17:48:36 +0100 In-Reply-To: <20210908083758.312055-6-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:10:232::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:10:232::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 16:48:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 970ae8b6-fea9-4091-fa33-08d97868ac4d X-MS-TrafficTypeDiagnostic: PH0PR11MB5112: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:529; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q3h/HWLxp4KhYEU+loU6LtVaqQi2g7X5RBspTRuKD0IFGWonUDQLd7JPqIGGMlkje+uIi3bnDQsAIMwuhATjMArSP0dCgm15QeHYdrvrLeJTYV5XNsx9Ej3boAO7vloYauzhFrKDjJgYjoaHStDC3V03l4SF57KnfjXM4uUXDLNKPk3Y+nbkne28ltIF+y03+gHYiRDpBi0LEffbPDh48/Gg0XCarRCPbbGN5G4RxZJavinZmYebwzhj/D+AuBMdd5PLFjk3rDtX9U+cbwiOpsK0lnJNamEWX1OJPaF7AZkEJEEuWkYdNjFUK4KArXWHOy6e9tqaSNcE1LbXCoEL5ot0fnBYPhD8qxU0dEQf3SEOfuRwhiDbXfek0EkdUsCvrj3ylWUn5rwGyBNDg3LYFtBFNcTx5aL1Mz4MWD09mzgZSAGcq02Y3Z99ksQYWXjPXzGSXFiAJ8MV06skqyEZPVVKXKoiWmlppVOxP7N9P+MC566gNzRGInlDm+D7S8fo8Dkl763ESVXgfg57/6zy3DCNjhTPsWr6E/UssXQj1HFG0Yay7wipxTU6nLbFKnXswg/hVSpJben7kO17Z+rpG+eDIkDXrCbocFH3trDle2EGqYaEdFYvD+udTB+JQyPIdWAyVrlT65b31C24ZYd/qwzw07MRa8HUYAjgkkbuf/Dvh6eOyDe/6IlU9+c2jZ9XWbTiwEw6qRkM9aw1pMbdaw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(478600001)(6486002)(5660300002)(8936002)(36756003)(6666004)(31696002)(86362001)(2616005)(956004)(44832011)(2906002)(38100700002)(66946007)(186003)(66556008)(66476007)(8676002)(83380400001)(316002)(26005)(53546011)(31686004)(4744005)(16576012)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d01wQ0dickNPbFBCWGdjenhEazNHOFhEVVY5QnVQZzhIY2o2cGtab1p4NjYy?= =?utf-8?B?cmFTYnR1ejNQTlN5bjEzMFRSeExaSU5tY2M0S285K3REejF2WWJaK0VtWWtR?= =?utf-8?B?YmlFclcxTHNpMnFpQ21VYlVQMkl3ODYrMXRRYUNTRUtxRWQwOURsNXVtVWh6?= =?utf-8?B?dWRqdk5nQkZMRWlybFFqa3RUbEszMTVQWEdjQVlaSmlRaVJsWW5qZjZ3enZF?= =?utf-8?B?bjdvL1pIM0hhelBQTXlKWVlWQU1USTFoMVg2YnlPWVdkV1ZVaEJUZDk3akpp?= =?utf-8?B?eFNCSU9zUGVVUW91SUZ6YU1iWVhQWkg5U0w0SzJRTmlUdWEwZ3h5alNZdnJr?= =?utf-8?B?WlVBSmJMaStFY1JjZlIrb013bjNibVRrRUVSbUZLRi9SQ3Y4SzhNRmNkMW9p?= =?utf-8?B?a29MUUhKY085aU9GTy9QU3JZL0lEZkNVUWV0cHZSVGdINm9rczZaTHVQSmRS?= =?utf-8?B?R05LaitDbEtib1hRWGVkUHI3WnMvS0dWV2I5UDZ3V3hDWnNmZ1ZBS0p4Z0pT?= =?utf-8?B?aitQbnJ0SXZDR3Z3VVBUNVNxcnB6RDBSVC8ycmJBTVRyd2tEVGl3YThxNWNv?= =?utf-8?B?SWFIVi9NU0ZUWTRMSUhoUXZhVFhXMncwa3FTbkdiNit0KzJaTU9xUytRQ1hS?= =?utf-8?B?aUVmUVViTCt3U3Q2N2daUzJTTi90QzBYOGNyQWpXWmhLd2ZnNVE1T3lINzE0?= =?utf-8?B?RCtxeDVnYXFibW1nZzBFbm9rcjc2blJQWFFYVjNKNjF5cC9zU3NBWjZZa1BV?= =?utf-8?B?VHdRVExNV3dmcHhPaExQcHlwTmpweGNMcFJaY0pJN0JmS1FIRUowakJhRXE2?= =?utf-8?B?VFhSUU1FVFFXVmJQSjhpSm5Rd1NpMHpwaDc1SllNZWtEL2JnYVVzbFlkcWZU?= =?utf-8?B?SFRscWZKQ0FTQXJZSmFuUzVrRzJYWG9CM1VtRWY3M1EvUkloWU8wYm1IRG9E?= =?utf-8?B?bmtTT2pmdjE1WFpMeWVvR0JNV3g4TkpGNS9qTC93NTR3MUNoVVAyTmltODBh?= =?utf-8?B?T2V3MHRNb2svUFljUm5ya1o5djVQL2xUNk1QNkt4YVBXUlBnWHFBOThtTnd3?= =?utf-8?B?eld0NzR6cTJtNWFYOXc3Vng3QWpmV2FVN2IveFBlZVJQLy9OVklpZUFWa3Js?= =?utf-8?B?QXlFWUp4WC91M3pzcnNlT1FBR2Q1a25UWVNyWjljNmU5cnpZM1gxcUlISW0w?= =?utf-8?B?b1J4Rnk1T3ZHaEZaNUJXZFM5RmdXTWVGQ0I0Y095aDEraE40RHZVYmRJR051?= =?utf-8?B?Z2JWZ1JURGNKa1ljSHgxVXRaNHlOYmlaVVMwOHl1WHVTQWpwdjZQbEI5OFM4?= =?utf-8?B?VDAwKytEbzhCWFQ1eHk5YnIxeFozZmFTVHZpRlUzK3pxcXdZaXhyZ0xYakFH?= =?utf-8?B?b2FYNXJ4OUFibThSSE12cy9IVHFPZUE4MmJsVXJXL1pNTmRrU1ZMOTJ4ZGI0?= =?utf-8?B?T0ZvdUlGbGtIdk84dzV0L0gyaS96UWlSZmJpa2J2dHhpMEp6a3NJNmIvWEFo?= =?utf-8?B?N3dtcVo0eW5lS0ZQOVFnNFlUSW4xY0FPTUhkRzh2WU5jTjBYRlV4emltaU9x?= =?utf-8?B?enp0SDVWOWQ4eGVaNDFKM0hjMXBoSHQ1azJCeFB5TjhTK2NITG1iWTBMVlBW?= =?utf-8?B?cE5obGtqZlpwOXJWeTA5ZTRtUDhkcGRyZVF3Ri9RaVhZSm1HVWxwaU1aSmtV?= =?utf-8?B?dzJxZW5IU256aE56aUlQRFExSjgxNnVxR2Y4UTdoM0RjdGVFQXZBZ1lGTUpi?= =?utf-8?Q?vO/qhVdlp/IhZ2o2Nktl2Mk6eLHsZvlONvozwVX?= X-MS-Exchange-CrossTenant-Network-Message-Id: 970ae8b6-fea9-4091-fa33-08d97868ac4d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:48:41.4310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nk5+ICvAMZnz20a3L//VDe7Ye6rjVYCCW2gZKH6rDiGknn6776THZvtZgBo232uRpWKwG3RlPabxxmdNNkdvKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 05/32] net/ngbe: support CRC offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support to strip or keep CRC in Rx path. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 1 + > drivers/net/ngbe/ngbe_rxtx.c | 53 +++++++++++++++++++++++++++++-- > drivers/net/ngbe/ngbe_rxtx.h | 1 + > 3 files changed, 53 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini > index 32f74a3084..2a472d9434 100644 > --- a/doc/guides/nics/features/ngbe.ini > +++ b/doc/guides/nics/features/ngbe.ini > @@ -10,6 +10,7 @@ Link status event = Y > Queue start/stop = Y > Scattered Rx = Y > TSO = Y > +CRC offload = P Again, can you please describe why it is supported partially?