From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0B4EF4C8E for ; Wed, 13 Mar 2019 12:47:31 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2019 04:47:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,474,1544515200"; d="scan'208";a="151927098" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.66]) ([10.237.220.66]) by fmsmga004.fm.intel.com with ESMTP; 13 Mar 2019 04:47:29 -0700 To: Thomas Monjalon , Shahaf Shuler Cc: "dev@dpdk.org" , Yongseok Koh , "ferruh.yigit@intel.com" , "nhorman@tuxdriver.com" , "gaetan.rivet@6wind.com" References: <1698312.TEgN2QzQvo@xps> <1907286.xmCKSEcAjO@xps> From: "Burakov, Anatoly" Message-ID: Date: Wed, 13 Mar 2019 11:47:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <1907286.xmCKSEcAjO@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 3/6] bus: introduce device level DMA memory mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 11:47:32 -0000 On 13-Mar-19 11:19 AM, Thomas Monjalon wrote: > 13/03/2019 12:12, Shahaf Shuler: >> From: Thomas Monjalon >>>> +/** >>>> + * Device level DMA map function. >>>> + * After a successful call, the memory segment will be mapped to the >>>> + * given device. >>>> + * >>>> + * @note: Memory must be registered in advance using rte_extmem_* >>> APIs. >>> >>> Could we make more explicit that this function is part of the "external >>> memory API"? >> >> How do you suggest? > > There could be an explicit comment. > >> This function belongs to rte_dev therefore the rte_dev prefix. better rte_dev_extmem_dma_map ? > > Not sure about the prefix. Anatoly? > IMO this is a dev API. The fact that its purpose is to use it with extmem is coincidental. -- Thanks, Anatoly