From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8B8FA0352; Mon, 21 Feb 2022 18:36:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 443154068C; Mon, 21 Feb 2022 18:36:58 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id B22AD4013F; Mon, 21 Feb 2022 18:36:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645465017; x=1677001017; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=fuhBc7wqBYTPfbZdWsfCFTnjOrro7LT09hI9WdyAJsY=; b=Z8qkMIwlo/aNutYfhNECk1tQDhDc69WHD1eda/vWwvqWyNrjBQFpO69L QskHFSVs5+E/d4noY5yMAFc1SvC/E4+U034BU1WjVgD1vHo0hzdHC7+Ma U+gfz3ndR6KLLxH7rmn/w+gAQeEziXLoRad3A3rbDnQm/QjCDgvGcBa+C RqOlTzwNUIUnszOEr8Z+vCFijFczjot8/YYakSD+CCr4rXLB7qp00aqd2 zbrXEpGaq0Zhf52tLr0pRW8LFVxDqCxYBWHr6Zl+N/t/EeyDv4uNWPHNA TyO602GUHLtqId6JXCc/bdXxXw6xjq6w04ySSJmsTwNlD2TaWR5gwUaEN A==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="251499663" X-IronPort-AV: E=Sophos;i="5.88,386,1635231600"; d="scan'208";a="251499663" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2022 09:36:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,386,1635231600"; d="scan'208";a="490506688" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 21 Feb 2022 09:36:55 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 21 Feb 2022 09:36:55 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 21 Feb 2022 09:36:55 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 21 Feb 2022 09:36:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PGlrdqe7k7lLTYP4eBYekN9eSsilU54xOwek8ndv43npdzI2y1okW6LMPy8fp8+coN21Ellk8GMeLQK2Hx4Qk7jjoBHeZiljToH8CkzLucHNL6mXeGkmbxU+JMuuDuERn80ZJ6PUxUWG1VTBBIlrHJpbG0fvuNLLr3M9WI7mnPedZKA+gk1eHuq7lp4pDStF4I2vEeSFeh3xN13Tx6bCrPgRBoDjos1TGrICgb1GX8UTpGnLYA3krlPL2D1i25RAKJ0/h1/2Jjyopto/cie1kBYVNdEk8luTcXxbmLRQs2eU+NK2SRCYXpAuY7LI/6s0jCZx1GHpwW6mTug4aMsrSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ImVD5pqS98WDkln2O58CGszs1sk5s6eD16xRh8lWEVw=; b=kEbyzz1ePCvybXyrC5H5eNPy6CddctG7xMNQ4GmvYyqUwdrPi5P9GD1G3lvG1hsexFeBrPSUkLpm6X/vpo/AK5c57wnryaZaKiJRpmWFNWmKmD0Lknx0Uy0VX2cJEGw14oVgBNHgVQuQwXmm4lhTWnWa2bhRCwHs91BDLsa4XGeoRm57b9uxTF1dnG1P8uV+/SzybfMZMXDO3UTsRpEJ4/2kWBTE0AOHwISx9zeYCWBnySp6ziwJ8xUGzUDfXXXrLEcsSmAewt2EbBFRuLpOcQyc9b0lAP6ZCkM/h7BHuylf4Qpt0cnGsrpghR+8vHIFgMDD8p0NwjXl2JqI1tss/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CO1PR11MB4866.namprd11.prod.outlook.com (2603:10b6:303:91::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Mon, 21 Feb 2022 17:36:53 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 17:36:53 +0000 Message-ID: Date: Mon, 21 Feb 2022 17:36:47 +0000 Content-Language: en-US To: Raja Zidane , CC: , References: <20220220120954.29784-1-rzidane@nvidia.com> <20220221132423.14343-1-rzidane@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH V4] app/testpmd: fix GENEVE parsing in csum forward mode X-User: ferruhy In-Reply-To: <20220221132423.14343-1-rzidane@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0016.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c450f6f5-09ef-48e7-0f21-08d9f560bf70 X-MS-TrafficTypeDiagnostic: CO1PR11MB4866:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BuRKsnr/dI2tjUSZVdQVOOdZ8Jz1qlL7xu26cMfrS8vjtcAu6Wx9MCLIuU9e0q0JL0E5KSZgJwhxeU98EaQhwvTCGQBuX46mL13DAGAofN0J1vus4OAuD8WtzqmixPUcf2UopV/W4TwM7kCLmFP4GtWYEVH7WtbWmgMIirFGHcBTep7WJJftamRKq5Evcp0bAjK+vCtLDdUVFV13ZIHCYzuW+hGZ8DU0JTKmjW1dge+LnZLnj99e28Dhc8Gq5zwZJPGZP+jUGP25gnv4xvUIP7M0fplIRo0ZXLfbRuecUI4UHkW1r+icc1MIidaXGjTZQ4EBzK7GBil1zjuZ0P7WJqF2BG9YRls0g5onHRBk+wYdGRCPzQYcmpv14WtVVYGHykTiZNZ1O/O5ts+ndyr1SmZjaa5zfFtbTZM06LUptfoHdlQJ9HURF2z93bynyF2da3HAQ0UsJQUCELrgOEOPs20JhvNZqrvFS6ImyiuC+SAl+5G8CZovwa643Rxxuz8dvxPBJgw30INVU98q3Pm5n3Ey2HoKWy6ES67x3VkUpwvcZxg6fJH+kEDm3BubPE5/0+KJhxcvcCPMfz+N3BCp0aTJzwhRQ2B6hb6xEzPr0NrBElDIhBzvuviAq6pY+MHBmtGeWbQFS9EM1tAjQ01LrsVPj/+lQ54G3rIALvhHXrQaewYGLsla0DaCshQHX3T9WjUGNT6kStVQvn3LPfstnA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(82960400001)(2906002)(2616005)(6512007)(38100700002)(31696002)(5660300002)(86362001)(186003)(26005)(44832011)(316002)(31686004)(83380400001)(66556008)(53546011)(6506007)(6486002)(6666004)(8676002)(508600001)(36756003)(4326008)(66476007)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aG5nQmwzTFhoaDRvZlJBYWEwR3NRS1ZZQUpVQS92c24wSHhyMm1BNm13d2V6?= =?utf-8?B?Q3JMQ2NxeGR3dlVqQm90QjhEUXNXRWs5L3R1bFg5QUVpelQ0VHdXTGg5WHlh?= =?utf-8?B?eUZxT0ZQdmNEcHgwQ3lQblY5SitadG16dm0wcWZUZndtRzU2TnUxZjFocWNk?= =?utf-8?B?RVJ1ZHMwN0J0ODA3a09SWjkxbnJUc2MyYjVKclBqMEZSK3dUVlllRWltMkZy?= =?utf-8?B?RDE5Zy9oQVhMb2txanY2NGoyK0t1WSt2ZWNaRWRpaXRucmluNzViMDlxU09i?= =?utf-8?B?T3QxZkNkdktreHZZdkhPK2xtOXllSEpETnhkSVVybHBQZmJxRFg5dHEwZ0xh?= =?utf-8?B?UWVoK2I3cER2RWxMcVJ2N0xOSE1uRWxZWE9qRDZON1Rucis4TGZucXprQThT?= =?utf-8?B?UzhSWGJxZjRod2pyZDlHSW8xWVFCS2x6dEdoMnJEMUZOZlNHYlczZWdJcVBv?= =?utf-8?B?YWdEZ1BPdCtUVWZvSnYrbms1dzBOT3hHdHYycWhPNHptdE5DSmNrazNyc3N1?= =?utf-8?B?U0w1VEZlZ0FqdDVicC9LaU8yQ1VUaTdRaEpNNHU2UjhJSTErcHR0QW00K2V1?= =?utf-8?B?ODM3T0lmUjBSUWdkVks3cWJVQjVrUGVuNmtoVFFDVVpTQThCeHNRdXdrKzVz?= =?utf-8?B?Rkp5cFJaTGNZOG1ZNnViTm9EbVU1Mk9qQzYrVGpSVDlsN25TM1ZHcXZaMTlN?= =?utf-8?B?eVdvWlRhcWRUVDZoUW1sMFI4Yno2TjBuOHNCK2tkVk5HcENqb2k1NzVIbEJ2?= =?utf-8?B?cmh2QjU2ZE9PTTZGNW01NHZ4cy9hRC9uV0V2cldjN0djWWJFOS9IRERPaGJT?= =?utf-8?B?MmJ5dVVTZW1HcjJJNk05S0Q1M2hEQUFqWVFmajQ5alB2dnBBVmxOaHVLTjVO?= =?utf-8?B?VU1qRnYzZ3RaejBzRkkwcGVVYVBBN2ZWdmVUYU1sU0pidk1IWlNmd1l0UHdH?= =?utf-8?B?azhDUVZOb1lqR1dBVDE4Y0laZXpVdCtIZlhzN3B0N1NETUJuRzkxRFJKOE85?= =?utf-8?B?M0d3anBCcFZqY2NZRm94R2Yvc0hoZVhOWjJ1TXY0S29lWmEySzJsM2liUTdB?= =?utf-8?B?WmFFT2p1d1NxZStVbHIxdUsxYzlxSWZ4WTlDYVh0UGdreGhaeUpwa0dRb3NP?= =?utf-8?B?bkNaMmkzamZsWERQYml3elVubisxdXZXVXZ6cU5XemdkYkhpQjgrRnM1SGdZ?= =?utf-8?B?VEg4aEIzdm9GekdtaHlJclpiWVE3YmY3amhrRXF1UDdFQzNxNVk2TS9Iankv?= =?utf-8?B?R3V5bm9EVk1XVk1XZ21EYXhpTWNxWitLN1dzdWN1OGtJL21KVnBnUW1Eb1ha?= =?utf-8?B?c29aeXRYTUUvOFdvNVpEZjhxejZxd0xPRUI1b0ZOVW01dU5GNFFIOENyUlJW?= =?utf-8?B?TnU3RXgwMnEyNklRdjNJQ0cyOVJIeE5CWFRTbU9lNkZISmwzalhRZkxqNVZO?= =?utf-8?B?NktHR0xPUTA0dVdZS0ROUGtrTkREZGJkTWVJaVRyTWk5ZXhaaUkySmRDblJa?= =?utf-8?B?MW5Xbm5tbGFzMlg3ZU5tTDJ0VjVsaXU5aldkVmFwM0FBc1ZhYXpzY1k5clpM?= =?utf-8?B?YS9IRi9HZE9aa2Q5V3haNGxzY2ZMbkVEU0hSRnY4Q0dpMmtpSWJKL1dSaXRD?= =?utf-8?B?TkVySHRNTDRBNlphQzVUK2tTTjJ4NkhmTE5lTWpDekptR1ZFeUkxcFZIeHJx?= =?utf-8?B?cXNldHdGK0tEeVhqZDFtZnJWM1EreTNGNC9uQ3F4QndWZHpKamFHWE43ak1V?= =?utf-8?B?Z2o4QWZaQy9uQ0wraWxka29ZVENFYmJoY3EvbkZ4Y09nZ2RNTGprK1FLeSs2?= =?utf-8?B?NjFZaUZSWks5N3lZbGMvS0lMUEpGM1ZZdkQvOWdlOUs1QlhtTzFieVRhY3RG?= =?utf-8?B?dVZZSmtaKytwNkNkZFRpNk1FRFBJOGs4WUxocnVaMDdJUytjbTVyWnJQRFFO?= =?utf-8?B?emx1M0h6aGNRcUZ0TVNSVWt6MzJBZTBOdzdDV0kycWlEQ3VrN0NqNExDS3B2?= =?utf-8?B?NjV1UW5WT2x5N3dRVHJuczdGYlhKL3RxbytDR1VSbVNGMXBqOFhyRXZicktk?= =?utf-8?B?QWhuL2dqSndNTC9veUtFWGl4ZTJnSDV4cWhDbmo0S1psL3B0M0ZtWi9tOE9Y?= =?utf-8?B?dmg2Qi9nYXFDVW1NUlRQa09MeGJVYWdBWTlPVVdTaVB0SWNHdUVpS2tGVGVK?= =?utf-8?Q?DMoPtfB4p/mssqoCpz3Cnlk=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c450f6f5-09ef-48e7-0f21-08d9f560bf70 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 17:36:53.3666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gEtxyTKAW30GOHd2kp2+uPjqzrt4r+kkYk91t9hWM2Ikm1/ISZqYcTGmuXHHf2NFQldebXWRfBuyPS7tv1RH4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4866 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/21/2022 1:24 PM, Raja Zidane wrote: > The csum FWD mode parses any received packet to set mbuf offloads for the > transmitting burst, mainly in the checksum/TSO areas. > In the case of a tunnel header, the csum FWD tries to detect known tunnels > by the standard definition using the header'sdata and fallback to check the > packet type in the mbuf to see if the Rx port driver already sign the > packet as a tunnel. > In the fallback case, the csum assumes the tunnel is VXLAN and parses the > tunnel as VXLAN. > When the GENEVE tunnel was added to the known tunnels in csum, its parsing > trial was wrongly located after the pkt type detection, causing the csum to > parse the GENEVE header as VXLAN when the Rx port set the tunnel packet > type. > > Remove the fall back case to VxLan. > Log error of unrecognized tunnel if no tunnel was parsed successfully. > > Fixes: c10a026c3b03 ("app/testpmd: introduce vxlan parsing function in csum fwd engine") > Cc:stable@dpdk.org > > Signed-off-by: Raja Zidane Moving Aman's ack from previous version: Acked-by: Aman Singh Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.