From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 7A72158CB
 for <dev@dpdk.org>; Mon, 17 Sep 2018 13:07:51 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 17 Sep 2018 04:07:50 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,385,1531810800"; d="scan'208";a="233560260"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39])
 ([10.237.221.39])
 by orsmga004.jf.intel.com with ESMTP; 17 Sep 2018 04:07:46 -0700
To: Beilei Xing <beilei.xing@intel.com>, qi.z.zhang@intel.com
Cc: dev@dpdk.org
References: <1532655382-4612-1-git-send-email-beilei.xing@intel.com>
 <1536636941-63922-1-git-send-email-beilei.xing@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Openpgp: preference=signencrypt
Message-ID: <bf3607e2-4847-d9be-4d6d-2e2ffe8746dc@intel.com>
Date: Mon, 17 Sep 2018 12:07:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1536636941-63922-1-git-send-email-beilei.xing@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: add alarm handler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 11:07:51 -0000

On 9/11/2018 4:35 AM, Beilei Xing wrote:
> This patch adds alarm handler, and then i40e
> PF will use alarm handler instead of interrupt
> handler when device is started and Rx interrupt
> mode is disabled. This way will save CPU cycles
> during receiving packets.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

<...>

> +static void
> +i40e_dev_alarm_handler(void *param)
> +{
> +	struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
> +	struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +	uint32_t icr0;
> +
> +	/* Disable interrupt */
> +	i40e_pf_disable_irq0(hw);
> +
> +	/* read out interrupt causes */
> +	icr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);
> +
> +	/* No interrupt event indicated */
> +	if (!(icr0 & I40E_PFINT_ICR0_INTEVENT_MASK)) {
> +		PMD_DRV_LOG(INFO, "No interrupt event");

Hi Beilei, Qi,

This prints an "info" level log each 50ms which makes console unusable.

This patch already merged in master repo.
So can you please send another patch to remove the log?

Thanks,
ferruh