From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
thomas@monjalon.net, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: document libnuma requirement for NUMA systems
Date: Fri, 1 Feb 2019 10:28:44 +0000 [thread overview]
Message-ID: <bf5f4f4e-6415-71d2-5e47-501634613d8d@intel.com> (raw)
In-Reply-To: <f2c7592f-b1f9-36be-f913-fb55c7d01a3d@redhat.com>
On 31-Jan-19 6:14 PM, Kevin Traynor wrote:
> On 01/31/2019 05:05 PM, Anatoly Burakov wrote:
>> Since 18.05, libnuma is pretty much required on Linux when using
>> non-legacy mode, because without it, we cannot know where our
>> hugepages are located [1].
>>
>> In legacy mode, libnuma is not required because we can still sort
>> pages by sockets, as we use pagemap lookup method to figure out
>> socket ID's for pages.
>>
>> So, document libnuma as required for NUMA systems and non-legacy
>> mode.
>>
>> [1] https://mails.dpdk.org/archives/dev/2018-December/120490.html
>>
>
> Might as well add to the stable docs also. Picking this commit as it's
> where both mode are available
>
> Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode")
> Cc: stable@dpdk.org
Yup, thought of that right after leaving office yesterday! :)
>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>> doc/guides/linux_gsg/sys_reqs.rst | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst
>> index 8ec3af491..23cfc27ab 100644
>> --- a/doc/guides/linux_gsg/sys_reqs.rst
>> +++ b/doc/guides/linux_gsg/sys_reqs.rst
>> @@ -70,6 +70,14 @@ Compilation of the DPDK
>>
>> * libnuma-dev in Debian/Ubuntu;
>>
>> + .. note::
>> +
>> + On systems with NUMA support, `libnuma-dev` (aka `numactl-devel`) is a
>> + recommended dependency when `--legacy-mem` switch is used, and a
>> + *required* dependency if default memory mode is used. While DPDK will
>> + compile and run without `libnuma` even on NUMA-enabled systems, both
>> + usability and performance will be degraded.
>> +
>> * Python, version 2.7+ or 3.2+, to use various helper scripts included in the DPDK package.
>>
>>
>>
>
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-02-01 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 17:05 Anatoly Burakov
2019-01-31 18:14 ` Kevin Traynor
2019-02-01 10:28 ` Burakov, Anatoly [this message]
2019-02-01 10:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf5f4f4e-6415-71d2-5e47-501634613d8d@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
--cc=marko.kovacevic@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).