From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 227B6A0540; Tue, 24 May 2022 17:32:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6DFE400EF; Tue, 24 May 2022 17:32:02 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2041.outbound.protection.outlook.com [40.107.220.41]) by mails.dpdk.org (Postfix) with ESMTP id 4F60E400D6 for ; Tue, 24 May 2022 17:32:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aRG3wyH0gQD/jWKFQBcJNu+GF8/PO83u7syNcYNmacIDBCI1OwtEB3NFY1Ik446wUf/789OuWxcKJLsyiG55j2f+sUohNk0WkAvtBnECdy7GXoYvAIisiHVJMJoUw8voZxQedRYPJkJNWNnTz5Xr2P4H4JEKf7VYs4UB+U6PumuhF3919u4AdjvzMnkrziPjZdMUjALAA39Ld/nYQrEyBshMIqdT/svWIIYsffFBZSn6GkfUaM0k5vdE2x74kQ0XojITBHPgiaSNjdJ6/B0EcesFYyLlvW/3H4rEnh0K9zI/QcPY+7srbzfFnid6uqJTBLEs3QEZE8VKL+SU3ExnjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d/Ci+npElCZlJrkWSMtGcd8jT3LtPeNfVVJu2r7nLlQ=; b=iaFutDlNw9CyZb0EeOg2I6r0+MP1YEhIUAmva9jeYUiyRY0mSlbUL78S53A7+VlMEp+WwxhAznjjd1PnsXHL/KvQWOP3l2fDkFc9ja9S8A33EbymIRUI/L7QLGVRkM7i406/8lcSxSoLjcbcB46Hp3kpgPfV4YwAmGAJMu/mndSVLQu7ve9jCAwIV/9U4xRv9syqfSi3jiJhp6fZJbPLXN6lz2tyNpV49V3u9t7FN4c0bSkjJmMWJRcgv63QpMvKPGEO3ZvgvSlOODudc8L7TBhNGtmdvZxL8FZDFyzmy6ZyeyeV00ykc1Gwp2n6bF5lNFigRrobj3scUimK6a6QOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=broadcom.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d/Ci+npElCZlJrkWSMtGcd8jT3LtPeNfVVJu2r7nLlQ=; b=qav6F0fFgyWF0lmRmU/AQuWdK3Gr+7QRWT12xdHX9PlNiqwPXi8VxsFI1Hda5Vh5JNiY20apmOhdj1y4ltJOK6uOq2TwzpA1MbsOdy4XNhoZf+VxvqS+Tl5X75suoKlC0scVtE0f2NWea9L0n7cgsLu8HXtjp1dIwt6vR1eblC8= Received: from DS7PR05CA0081.namprd05.prod.outlook.com (2603:10b6:8:57::6) by BL3PR02MB8284.namprd02.prod.outlook.com (2603:10b6:208:347::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 15:31:58 +0000 Received: from DM3NAM02FT031.eop-nam02.prod.protection.outlook.com (2603:10b6:8:57:cafe::78) by DS7PR05CA0081.outlook.office365.com (2603:10b6:8:57::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.7 via Frontend Transport; Tue, 24 May 2022 15:31:58 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT031.mail.protection.outlook.com (10.13.4.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Tue, 24 May 2022 15:31:58 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 24 May 2022 16:31:56 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 24 May 2022 16:31:56 +0100 Envelope-to: ajit.khaparde@broadcom.com, kishore.padmanabha@broadcom.com, michael.baucom@broadcom.com, thomas@monjalon.net, david.marchand@redhat.com, dev@dpdk.org Received: from [10.71.116.185] (port=9295) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1ntWVo-0000z0-9v; Tue, 24 May 2022 16:31:56 +0100 Message-ID: Date: Tue, 24 May 2022 16:31:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [dpdk-dev] [PATCH v2 06/12] net/bnxt: combine default and regular flows Content-Language: en-US To: Ajit Khaparde CC: Kishore Padmanabha , Mike Baucom , Thomas Monjalon , David Marchand , References: <20201009111130.10422-1-somnath.kotur@broadcom.com> <20201010041153.63921-1-ajit.khaparde@broadcom.com> <20201010041153.63921-7-ajit.khaparde@broadcom.com> From: Ferruh Yigit In-Reply-To: <20201010041153.63921-7-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6eeba8d9-5a42-4631-a0d4-08da3d9a8a90 X-MS-TrafficTypeDiagnostic: BL3PR02MB8284:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xG7jbVXUbgEHt1QibFlTKdjtxMt8HrRfnoiyeM2gSyqjlq6DVBtO23Rr7WxhkasR7bG+ej3RIXslwV0PQ5CXjpuYsfdX64y0ZilnpRcxS870hcqXY4MM8M+zdJS7rKK+e/mCftxLODUBC5kyX3yP5WXJhiO88hPguPpS0o2QROdEFuBRhMxRWeqr/yAu4H0q/95ihn1wn73IpNvwlfixOBjGefbsK+UwYoze+91c+THe9deO6MKnjG6J1l6I4fZfyx5o/FXeU0afxoGdga4pV0nhW3MK2JXTFnpbV2rQVPhTNSBJwexrYtKI+dBBgOxO4WneWl+JVAQ83gA+bh7KLYUdXM3hVPpp0jOBnzgycuwADAASG2PoqPzl4lds0nm+2qU3njX0MyJpGnSLo4g1nvpMM8sZA/C/URSMKLCq5M0Hw+/lP/9hOxSrezHBIJvZbd+tRfeNF/H1rZYbldrIH7WEmJzlEEEVTiyhFg9Y9h4947RyL7WiPY45tn1ho55kTZt07HSysw6uiZ5RACsXP/uh9GwSOHUQylMZOl7TT7NpcQ7iIXeneFx9TLgSfFhh1oMWF0CxqtuZ1kSAugcvZ6gymsb3QSK4tNDwZuZTvcX51ggDBBXE+B6NJ7HHXnZE1Qll9dhJY+S907JZw2RjO62G7jpe/8yZTLHNZ6g29x37qcmm061dlmM06Jzzcc/LBro/mhbn0Mi/gwEO7nQGYOX0a9kBZhEyAyW+hjPFBc8= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(83380400001)(8676002)(316002)(54906003)(6916009)(508600001)(35950700001)(70586007)(53546011)(44832011)(70206006)(4326008)(86362001)(7636003)(31696002)(8936002)(26005)(356005)(9786002)(336012)(5660300002)(2616005)(36756003)(47076005)(40460700003)(31686004)(2906002)(82310400005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 15:31:58.2526 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6eeba8d9-5a42-4631-a0d4-08da3d9a8a90 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT031.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR02MB8284 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/10/2020 5:11 AM, Ajit Khaparde wrote: > From: Kishore Padmanabha > > The default and regular flows are stored in the same flow table > instead of different flow tables. This should help code reuse > and reducing the number of allocations. > So combine default and regular flows in flow database. > > Signed-off-by: Kishore Padmanabha > Reviewed-by: Mike Baucom > Reviewed-by: Ajit Khaparde <...> > * > * returns 0 on success or negative number on failure > */ > -int32_t ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > - uint32_t idx) > +int32_t > +ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > + enum bnxt_ulp_fdb_type flow_type) Above change is causing build error [1] because the function declaration [2] differs from definition. Reproduced by latest gcc [3]. [1] ../drivers/net/bnxt/tf_ulp/ulp_flow_db.c:962:1: error: conflicting types for ‘ulp_flow_db_flush_flows’ due to enum/integer mismatch; have ‘int32_t(struct bnxt_ulp_context *, enum bnxt_ulp_fdb_type)’ {aka ‘int(struct bnxt_ulp_context *, enum bnxt_ulp_fdb_type)’} [-Werror=enum-int-mismatch] 962 | ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from ../drivers/net/bnxt/tf_ulp/ulp_flow_db.c:12: ../drivers/net/bnxt/tf_ulp/ulp_flow_db.h:211:1: note: previous declaration of ‘ulp_flow_db_flush_flows’ with type ‘int32_t(struct bnxt_ulp_context *,uint32_t)’ {aka ‘int(struct bnxt_ulp_context *, unsigned int)’} 211 | ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, | ^~~~~~~~~~~~~~~~~~~~~~~ [2] > +ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > + uint32_t idx); > [3] gcc 13.0.0 "gcc (GCC) 13.0.0 20220524 (experimental)")