From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3B78A108A for ; Mon, 6 Mar 2017 10:24:26 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2017 01:24:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,252,1484035200"; d="scan'208";a="72653028" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.191.192]) ([10.254.191.192]) by fmsmga005.fm.intel.com with ESMTP; 06 Mar 2017 01:24:23 -0800 To: Vasily Philipov , "dev@dpdk.org" References: <74798f347a5b1fad28037b713ad83048c227a2ca.1487685098.git.vasilyf@mellanox.com> <74798f347a5b1fad28037b713ad83048c227a2ca.1487770570.git.vasilyf@mellanox.com> <1964838c-9f28-1680-705d-148bcf0e816c@intel.com> Cc: Adrien Mazarguil , =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= , Thomas Monjalon , Neil Horman From: Ferruh Yigit Message-ID: Date: Mon, 6 Mar 2017 09:24:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 09:24:27 -0000 On 2/23/2017 10:44 AM, Vasily Philipov wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >> Sent: Wednesday, February 22, 2017 21:05 >> To: Vasily Philipov ; dev@dpdk.org >> Cc: Adrien Mazarguil ; Nélio Laranjeiro >> >> Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the >> header file >> >> On 2/22/2017 1:42 PM, Vasily Philipov wrote: >>> Make some structs/defines visible from different source files by >>> placing them into mlx4.h header. >>> >>> Signed-off-by: Vasily Philipov >>> --- >>> drivers/net/mlx4/mlx4.c | 183 >>> ++-------------------------------------------- >>> drivers/net/mlx4/mlx4.h | 187 >>> +++++++++++++++++++++++++++++++++++++++++++++++- >>> 2 files changed, 189 insertions(+), 181 deletions(-) >>> >>> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index >>> 79efaaa..82ccac8 100644 >>> --- a/drivers/net/mlx4/mlx4.c >>> +++ b/drivers/net/mlx4/mlx4.c >>> @@ -1,8 +1,8 @@ >>> /*- >>> * BSD LICENSE >>> * >>> - * Copyright 2012-2015 6WIND S.A. >>> - * Copyright 2012 Mellanox. >>> + * Copyright 2012-2017 6WIND S.A. >>> + * Copyright 2012-2017 Mellanox. >> >> Can someone knowledgeable about Copyright help please? >> >> What is the year field in Copyright line for? >> And above change updates Copyright from 2012 to 2012-2017, is this correct? >> > > The year line was changes in order to show when the file was changed the last time... I see, but I don't know if the year field is for last updated date marker, specially when there are multiple copyright holders. Overall I don't know why second date is required at all, assuming first date shows the start date of the work and sets the copyright coverage date. A comment from who knows more about these issues is welcome. Thanks, ferruh