From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Reshma Pattan <reshma.pattan@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
"Shreyansh Jain" <shreyansh.jain@nxp.com>,
Ashish Gupta <ashish.gupta@cavium.com>,
"Fiona Trahe" <fiona.trahe@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
"Declan Doherty" <declan.doherty@intel.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>,
Shahed Shaikh <shahed.shaikh@cavium.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Keith Wiles <keith.wiles@intel.com>,
"Nipun Gupta" <nipun.gupta@nxp.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals
Date: Fri, 5 Oct 2018 18:55:56 +0300 [thread overview]
Message-ID: <bf870874-bc3d-a142-119b-608aea894536@solarflare.com> (raw)
In-Reply-To: <20181005162612.31906-1-ferruh.yigit@intel.com>
On 10/5/18 7:26 PM, Ferruh Yigit wrote:
> Some global variables can indeed be static, add static keyword to them.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
<...>
> diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c
> index 000cd0b20..e71ddd001 100644
> --- a/drivers/net/sfc/sfc_rx.c
> +++ b/drivers/net/sfc/sfc_rx.c
> @@ -1126,7 +1126,7 @@ sfc_rx_qfini(struct sfc_adapter *sa, unsigned int sw_index)
> /*
> * Mapping between RTE RSS hash functions and their EFX counterparts.
> */
> -struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = {
> +static struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = {
I'd prefer "static const" in fact
> { ETH_RSS_NONFRAG_IPV4_TCP,
> EFX_RX_HASH(IPV4_TCP, 4TUPLE) },
> { ETH_RSS_NONFRAG_IPV4_UDP,
<...>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2018-10-05 15:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 3:40 [dpdk-dev] [PATCH] fix static variables Ferruh Yigit
2018-10-05 8:38 ` Rao, Nikhil
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals Ferruh Yigit
2018-10-05 15:55 ` Andrew Rybchenko [this message]
2018-10-28 11:04 ` Thomas Monjalon
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name Ferruh Yigit
2018-10-05 16:27 ` Maxime Coquelin
2018-10-08 12:18 ` Shreyansh Jain
2018-10-10 5:56 ` Zhang, Tianfei
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 3/4] fix global variable issues Ferruh Yigit
2018-10-07 12:21 ` Jerin Jacob
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 4/4] lib: reduce global variable usage Ferruh Yigit
2018-10-07 12:22 ` Jerin Jacob
2018-10-08 8:45 ` Shreyansh Jain
2018-10-08 9:11 ` Ferruh Yigit
2018-10-08 9:27 ` Shreyansh Jain
2018-10-07 12:18 ` [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals Jerin Jacob
2018-10-08 9:43 ` Shreyansh Jain
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 " Ferruh Yigit
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 2/4] drivers: prefix global variables with module name Ferruh Yigit
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 3/4] fix global variable issues Ferruh Yigit
2018-10-29 6:57 ` Hyong Youb Kim
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 4/4] lib: reduce global variable usage Ferruh Yigit
2018-10-29 1:35 ` Thomas Monjalon
2018-10-10 6:23 ` [dpdk-dev] [PATCH] fix static variables Zhang, Tianfei
2018-10-11 6:56 ` Xing, Beilei
2018-11-02 10:58 ` [dpdk-dev] " Tomasz Cel
2018-11-02 11:09 ` Cel, TomaszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf870874-bc3d-a142-119b-608aea894536@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=akhil.goyal@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=ashish.gupta@cavium.com \
--cc=beilei.xing@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=fiona.trahe@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=harish.patil@cavium.com \
--cc=hemant.agrawal@nxp.com \
--cc=jasvinder.singh@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=nipun.gupta@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=reshma.pattan@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=shahed.shaikh@cavium.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).