From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C477A0547; Fri, 12 Mar 2021 11:52:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4562160858; Fri, 12 Mar 2021 11:51:59 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id B49E74067E for ; Fri, 12 Mar 2021 11:51:57 +0100 (CET) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DxjJG5nBDz17JWh for ; Fri, 12 Mar 2021 18:50:06 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.498.0; Fri, 12 Mar 2021 18:51:53 +0800 To: Ferruh Yigit , References: <1615356985-24722-1-git-send-email-humin29@huawei.com> <1615356985-24722-5-git-send-email-humin29@huawei.com> <773749fe-6420-0729-6cf0-e8aea4c5095c@intel.com> <9b2df798-6f9b-018e-30bd-0bed86d336cd@huawei.com> From: "Min Hu (Connor)" Message-ID: Date: Fri, 12 Mar 2021 18:51:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/3/12 18:02, Ferruh Yigit 写道: > On 3/12/2021 1:51 AM, Min Hu (Connor) wrote: >> >> >> 在 2021/3/12 2:25, Ferruh Yigit 写道: >>> On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: >>>> From: Hongbo Zheng >>>> >>>> Adjust the format of hns3 RAS related structures to resolve >>>> the static check warnings of reviewbot_c.This patch has no >>>> impact on function. >>>> >>>> The correspond warnings of reviewbot_c: >>>> When struct and union members are initialized, each member >>>> is initialized on a separate line. >>>> >>>> Signed-off-by: Hongbo Zheng >>>> Signed-off-by: Min Hu (Connor) >>> >>> <...> >>> >>>>   static const struct hns3_hw_error ppu_mpf_abnormal_int_st1[] = { >>>> -    { .int_msk = 0xFFFFFFFF, >>>> -      .msg = "rpu_rx_pkt_ecc_mbit_err", >>>> -      .reset_level = HNS3_GLOBAL_RESET }, >>>> -    { .int_msk = 0, >>>> -      .msg = NULL, >>>> -      .reset_level = HNS3_NONE_RESET} >>>> +    { >>>> +        .int_msk = 0xFFFFFFFF, >>>> +        .msg = "rpu_rx_pkt_ecc_mbit_err", >>>> +        .reset_level = HNS3_GLOBAL_RESET >>>> +    }, { >>>> +        .int_msk = 0, >>>> +        .msg = NULL, >>>> +        .reset_level = HNS3_NONE_RESET >>>> +    } >>>>   }; >>> >>> Hi Connor, >>> >>> This looks like just a syntax change, I wonder what is mentioned >>> 'reviewbot_c' that generates a warning? >> Hi, Ferruh, the description of 'reviewbot_c' may be misleading, >> actually, it means "Huawei General Coding Specification". code from >> Our company should follow that, thanks > > Got it, you can remove the reference it if it is not publicly > accessible, otherwise it doesn't add any values and it may be confusing. OK , I will fix it in V3, thanks. > .