From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"phil.yang@arm.com" <phil.yang@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix physic port socket initialization
Date: Wed, 17 Oct 2018 14:04:38 +0100 [thread overview]
Message-ID: <bfa38902-0033-58c7-b253-217f6c80292d@intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580102FE7FA3@IRSMSX106.ger.corp.intel.com>
On 10/17/2018 12:02 PM, Ananyev, Konstantin wrote:
>
>
>> -----Original Message-----
>> From: phil.yang@arm.com [mailto:phil.yang@arm.com]
>> Sent: Wednesday, October 17, 2018 2:37 AM
>> To: dev@dpdk.org
>> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: [PATCH v2] app/testpmd: fix physic port socket initialization
>>
>> Once the lcore list setting excluded the socket which physic device
>> attached, it will cause failure. Meanwhile, it will disable Testpmd
>> cross NUMA scenario.
>>
>> Fixes: dbfb8ec ("app/testpmd: optimize mbuf pool allocation")
>>
>> Signed-off-by: Phil Yang <phil.yang@arm.com>
>> Reviewed-by: Gavin Hu <Gavin.Hu@arm.com>>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied to dpdk-next-net/master, thanks.
What about 3rd item discussed before,
`port-numa-config` and `rxring-numa-config`
Currently if all cores and devices are in socket 0, there is no way for user to
ask allocating memory from socket 1. Again this happened after optimization patch.
For above case, when `port-numa-config` used to ask memory from socket 1:
`port-numa-config=(0,1)` testpmd will give error because no memory can be
allocated from socket 1.
What do you think, if user explicitly requested memory to be allocated from a
socket via `port-numa-config` and `rxring-numa-config`, and if that socket is
valid, add that socket into socket_ids[] so that mempool allocated for that socket?
next prev parent reply other threads:[~2018-10-17 13:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 10:14 [dpdk-dev] [PATCH] " Phil Yang
2018-10-16 10:40 ` Ananyev, Konstantin
2018-10-17 1:41 ` Phil Yang (Arm Technology China)
2018-10-17 1:36 ` [dpdk-dev] [PATCH v2] " Phil Yang
2018-10-17 11:02 ` Ananyev, Konstantin
2018-10-17 13:04 ` Ferruh Yigit [this message]
2018-10-18 2:37 ` Phil Yang (Arm Technology China)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa38902-0033-58c7-b253-217f6c80292d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=phil.yang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).