From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 423C71BA2C
 for <dev@dpdk.org>; Wed, 25 Oct 2017 23:37:33 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga105.jf.intel.com with ESMTP; 25 Oct 2017 14:37:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,433,1503385200"; d="scan'208";a="167619608"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.45])
 ([10.241.225.45])
 by fmsmga006.fm.intel.com with ESMTP; 25 Oct 2017 14:37:31 -0700
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, Roger B Melton <rmelton@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
References: <20171012172435.34700-1-rmelton@cisco.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B6D1EA1@shsmsx102.ccr.corp.intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <bfb6d0e2-d3cd-b633-bbed-1910fb1d0278@intel.com>
Date: Wed, 25 Oct 2017 14:37:31 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B6D1EA1@shsmsx102.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order
 for i35x LB packets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Oct 2017 21:37:33 -0000

On 10/15/2017 5:43 PM, Lu, Wenzhuo wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Roger B Melton [mailto:rmelton@cisco.com]
>> Sent: Friday, October 13, 2017 1:25 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
>> Cc: dev@dpdk.org; Roger B Melton <rmelton@cisco.com>
>> Subject: [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB
>> packets
>>
>> When copying VLAN tags from the RX descriptor to the vlan_tci field in the
>> mbuf header,  igb_rxtx.c:eth_igb_recv_pkts() and
>> eth_igb_recv_scattered_pkts() both assume that the VLAN tag is always little
>> endian.  While i350, i354 and /i350vf VLAN non-loopback packets are stored
>> little endian, VLAN tags in loopback packets for those devices are big endian.
>>
>> For i350, i354 and i350vf VLAN loopback packets, swap the tag when copying
>> from the RX descriptor to the mbuf header.  This will ensure that the mbuf
>> vlan_tci is always little endian.
>>
>> Signed-off-by: Roger B Melton <rmelton@cisco.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied to dpdk-next-net/master, thanks.